Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <20210112023619.5713-1-dong.menglong@zte.com.cn> <33bb1cd2-c202-0fd5-733d-b44e7e8fa92c@gmail.com>
In-Reply-To: <33bb1cd2-c202-0fd5-733d-b44e7e8fa92c@gmail.com>
From:   Menglong Dong <menglong8.dong@gmail.com>
Date:   Wed, 13 Jan 2021 22:04:57 +0800
Message-ID: <CADxym3bzFPeCXzkO1iFy+Sx7GhwRGo=VkOUzrDE4KMCjMx0v-w@mail.gmail.com>
Subject: Re: [PATCH] ata: remove redundant error print in rb532_pata_driver_probe
To:     Sergei Shtylyov <sergei.shtylyov@gmail.com>, axboe@kernel.dk
Cc:     linux-ide@vger.kernel.org, LKML <linux-kernel@vger.kernel.org>,
        Menglong Dong <dong.menglong@zte.com.cn>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

Hello, Sergei

On Tue, Jan 12, 2021 at 7:15 PM Sergei Shtylyov
<sergei.shtylyov@gmail.com> wrote:
>
> Hello!
>
> On 1/12/21 5:36 AM, menglong8.dong@gmail.com wrote:
>
[....]
> >       irq = platform_get_irq(pdev, 0);
> > -     if (irq <= 0) {
> > -             dev_err(&pdev->dev, "no IRQ resource found\n");
> > +     if (irq <= 0)
> >               return -ENOENT;
>
>    This still beaks the probe deferral. :-(
>    But that's another problem...
>
> [...]
>
> MBR, Sergei

What does this 'MBR' mean? I am a novice~~~
So, is it better to replace 'platform_get_irq' with
'platform_get_irq_optional' here?

--
 Best Regards
 Menglong Dong