Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
From:   Pawel Laszczak <pawell@cadence.com>
To:     Pawel Laszczak <pawell@cadence.com>,
        "peter.chen@nxp.com" <peter.chen@nxp.com>
CC:     "rdunlap@infradead.org" <rdunlap@infradead.org>,
        "a-govindraju@ti.com" <a-govindraju@ti.com>,
        "gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>,
        "linux-usb@vger.kernel.org" <linux-usb@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        Rahul Kumar <kurahul@cadence.com>,
        "geert@linux-m68k.org" <geert@linux-m68k.org>
Subject: RE: [PATCH v2] usb: cdnsp: fixes undefined reference to cdns_remove
Thread-Topic: [PATCH v2] usb: cdnsp: fixes undefined reference to cdns_remove
Thread-Index: AQHW6bZnkOBmLPUj90+oH08d89YqSaolngpw
Date:   Wed, 13 Jan 2021 14:37:15 +0000
Message-ID: <BYAPR07MB5381F03FB95880ABBAE10F96DDA90@BYAPR07MB5381.namprd07.prod.outlook.com>
References: <20210113141407.25473-1-pawell@cadence.com>
In-Reply-To: <20210113141407.25473-1-pawell@cadence.com>
Accept-Language: en-US
Content-Language: en-US
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-Network-Message-Id: 408056bd-2d19-46e6-24f8-08d8b7d0b8f7
X-MS-Exchange-CrossTenant-originalarrivaltime: 13 Jan 2021 14:37:15.6081
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: d36035c5-6ce6-4662-a3dc-e762e61ae4c9
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: 7mPydoQ8QIWTUKF20Jp0r5iwwgNufrv1JKju1IePWR68qI6szAX7FdsqHBPpAq274xmomZPBFFrdd3oNlioXdctZBLiVS0ArhlagmYfOxLY=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR07MB5384
X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.343,18.0.737
 definitions=2021-01-13_07:2021-01-13,2021-01-13 signatures=0
X-Proofpoint-Spam-Details: rule=outbound_check_notspam policy=outbound_check score=0 mlxscore=0
 lowpriorityscore=0 bulkscore=0 suspectscore=0 spamscore=0 clxscore=1011
 mlxlogscore=999 adultscore=0 phishscore=0 priorityscore=1501
 impostorscore=0 malwarescore=0 classifier=spam adjust=0 reason=mlx
 scancount=1 engine=8.12.0-2009150000 definitions=main-2101130090
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi Peter,

Can you replace the previous version with this one.=20
The v1 still has problem with undefined reference when CONFIG_PCI or CONFIG=
_ACPI are disabled.

V2 fixes this issue.=20

Thanks,
Regards,
Pawel Laszczak


>From: Pawel Laszczak <pawell@cadence.com>
>Sent: Wednesday, January 13, 2021 3:14 PM
>To: peter.chen@nxp.com
>Cc: rdunlap@infradead.org; a-govindraju@ti.com; gregkh@linuxfoundation.org=
; linux-usb@vger.kernel.org; linux-
>kernel@vger.kernel.org; Rahul Kumar <kurahul@cadence.com>; geert@linux-m68=
k.org; Pawel Laszczak <pawell@cadence.com>
>Subject: [PATCH v2] usb: cdnsp: fixes undefined reference to cdns_remove
>
>Patch fixes the following errors:
>ld: drivers/usb/cdns3/cdnsp-pci.o: in function `cdnsp_pci_remove':
>cdnsp-pci.c:(.text+0x80): undefined reference to `cdns_remove'
>ld: drivers/usb/cdns3/cdnsp-pci.o: in function `cdnsp_pci_probe':
>cdnsp-pci.c:(.text+0x34c): undefined reference to `cdns_init'
>
>Issue occurs for USB/CDNS3/CDNSP kernel configuration:
>CONFIG_USB=3Dm
>CONFIG_USB_CDNS_SUPPORT=3Dy
>CONFIG_USB_CDNS3=3Dm
>CONFIG_USB_CDNS3_PCI_WRAP=3Dm
>CONFIG_USB_CDNSP_PCI=3Dy
>
>Reported-by: Randy Dunlap <rdunlap@infradead.org>
>Signed-off-by: Pawel Laszczak <pawell@cadence.com>
>---
>changelog:
>v2
>- added missing condition
>
> drivers/usb/cdns3/Makefile | 8 ++++++++
> 1 file changed, 8 insertions(+)
>
>diff --git a/drivers/usb/cdns3/Makefile b/drivers/usb/cdns3/Makefile
>index 3f9b7fa8a594..61edb2f89276 100644
>--- a/drivers/usb/cdns3/Makefile
>+++ b/drivers/usb/cdns3/Makefile
>@@ -26,7 +26,15 @@ obj-$(CONFIG_USB_CDNS3_TI)			+=3D cdns3-ti.o
> obj-$(CONFIG_USB_CDNS3_IMX)			+=3D cdns3-imx.o
>
> cdnsp-udc-pci-y					:=3D cdnsp-pci.o
>+
>+ifdef CONFIG_USB_CDNSP_PCI
>+ifeq ($(CONFIG_USB),m)
>+obj-m						+=3D cdnsp-udc-pci.o
>+else
> obj-$(CONFIG_USB_CDNSP_PCI) 			+=3D cdnsp-udc-pci.o
>+endif
>+endif
>+
> cdnsp-udc-pci-$(CONFIG_USB_CDNSP_GADGET)	+=3D cdnsp-ring.o cdnsp-gadget.o=
 \
> 						   cdnsp-mem.o cdnsp-ep0.o
>
>--
>2.17.1