Received: by 2002:a05:6a10:2785:0:0:0:0 with SMTP id ia5csp416563pxb; Wed, 13 Jan 2021 06:55:32 -0800 (PST) X-Google-Smtp-Source: ABdhPJzNyWyklZK6Wp2dxMjm7vZEZ4EDgQTWpTRcrJBaQvSsgxKquYhsZCLk8+mYCu6Ob7PX9fIv X-Received: by 2002:a50:f9cc:: with SMTP id a12mr1984090edq.335.1610549731871; Wed, 13 Jan 2021 06:55:31 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1610549731; cv=none; d=google.com; s=arc-20160816; b=nlCcvHSUSnP0Zk/SEfJU8zTVrd4pqJgpS9P7rUnMM0a3eMvVRFqaczW4VludAcsOn+ yZzRq93olqvvspuNaQ45dAAhgjQTUpp7zxNbdUFPS2Pb9J/Zcqs896UKwiUGFoWaBZj0 SzKD5mS0drsjDYUDbr2F7Ng30FpuBuKjCAvCoTEZiu30bLIxlckWeFUNtpz797TX6Ek+ 7IiUjNc047WY+BhRt+3BUhc9UKF7SUTDJEZsj1DU+qSwN13Pwn59RxkY9++T9ySo4Sx6 8HoS5spqSczHrMRPCF1WZIB/csXwJP/DwfxGHjqtks8EaiwRMjMQ3vGz/Cmm++W7zC8k a1MA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=DvtlGdT5MHeh268WloE5stTLPTvRDEZ8rCCQAdX9t84=; b=IayILqN/VggL0RGwpTvyIOqQiqdZSUe13z8Km8oFZ9Eegmcw6O/wJ41F063lwwBt74 1ox+5SrJRbkQeR2mdEDJczMQe7l+6f4Gn2eZHORdQwEPTAz9fxOe+XbUU7tZDDj/4R3k BqKg3lreCGk/ipG2PRCrYjP/87rJRljPgVZsO7tZDYaoSwEOO+JGhpXUm6jxsPQ3AjxB hsOXA3Wv8M2qKi9vZ/SUSZfIp20+kyPdGujLoHZHl07qnUzfx+rMP+02oVHD7tdkTdMB KV4A+/Lnj7ZYhNKvsqPqWAcYi3goSHDfUitn0kTj+LFjqytBgY73H8AYUgT+/DIu4ccA felQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=k1fbqp18; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id r19si1109279edw.476.2021.01.13.06.55.07; Wed, 13 Jan 2021 06:55:31 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=k1fbqp18; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726664AbhAMOxM (ORCPT + 99 others); Wed, 13 Jan 2021 09:53:12 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41838 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727684AbhAMOwN (ORCPT ); Wed, 13 Jan 2021 09:52:13 -0500 Received: from mail-wr1-x42d.google.com (mail-wr1-x42d.google.com [IPv6:2a00:1450:4864:20::42d]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3CAD8C06134F for ; Wed, 13 Jan 2021 06:50:49 -0800 (PST) Received: by mail-wr1-x42d.google.com with SMTP id r7so2409603wrc.5 for ; Wed, 13 Jan 2021 06:50:49 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=DvtlGdT5MHeh268WloE5stTLPTvRDEZ8rCCQAdX9t84=; b=k1fbqp18yv8PIWF/VtBZ1OCxmUUxm3DEuDCdGpp/1lf2Qusjjl6Jr0LbNjCDkAYjum 1/wwNHwC2fYs6yOsRNYBp7G/0/6EKBrI0OVlE9krnhPcy8pLZI8vfx7yCAVMlSMwGOA+ hnp7cTdcUMYNnIJqWcxy66Lo1P3xlU9yPVOVU+OePlvMmIh7A0BSVnlshSywJYQQwzbU 5uukjwiQHWY6GeoO+bNuzYazh3MQdjtKvFY6BEa2ztaEJRUBzfF1uDCo9++RfRW+OfdJ ZYE/I/DDBlwjWjQBrwAXZdAbnCrtVk//3HRL1I6mCpS4vkKtNu8uXUKBPssO/APhiy0t CkPw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=DvtlGdT5MHeh268WloE5stTLPTvRDEZ8rCCQAdX9t84=; b=r5gbIgPvniHWWvHAeDiRdck0k00zl3dTzz805VVH3kxkESZpuCEjcAL6FYxHxBrT1V Zjeu27oUVyaI/kKBM/hrGxrFdtYOIZqjEAr/bugpCfc/1vX8iYJnZuRQxTvqvoIfw2Qy Ce+BydY83/F2BgGgIxs5N+hmhsbaIlfR2FzKc3vXzD98UyLj3GocakmG+AF991vGR9fR DXfxGb9sr2F4Q7r3x3VgxDmCwR+EtOd2V8VOkvDawrspYQZ0cUYFRDBexNTsYB0AEhAz T7TPN7f4/TqpptCPZ67yLSceEHfbQkcbsNKT48+X6seXJiBn/O+WC8iBU+pxazxQHxZK JZvQ== X-Gm-Message-State: AOAM532jDpNSocIzCDYJe8nBXuc7EYzB1QjrYiBRLEhC5gO5DkgEWkN1 40I51P8IYEW2apushEh0Y6t7Dw== X-Received: by 2002:adf:eec6:: with SMTP id a6mr2949891wrp.239.1610549448015; Wed, 13 Jan 2021 06:50:48 -0800 (PST) Received: from dell.default ([91.110.221.229]) by smtp.gmail.com with ESMTPSA id t188sm3273433wmf.9.2021.01.13.06.50.47 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 13 Jan 2021 06:50:47 -0800 (PST) From: Lee Jones To: lee.jones@linaro.org Cc: linux-kernel@vger.kernel.org, Jingoo Han , Ben Dooks , linux-fbdev@vger.kernel.org, dri-devel@lists.freedesktop.org Subject: [PATCH 24/31] video: fbdev: s3c-fb: Fix some kernel-doc misdemeanours Date: Wed, 13 Jan 2021 14:50:02 +0000 Message-Id: <20210113145009.1272040-25-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20210113145009.1272040-1-lee.jones@linaro.org> References: <20210113145009.1272040-1-lee.jones@linaro.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Fixes the following W=1 kernel build warning(s): drivers/video/fbdev/s3c-fb.c:104: warning: Function parameter or member 'osd_stride' not described in 's3c_fb_variant' drivers/video/fbdev/s3c-fb.c:174: warning: Function parameter or member 'variant' not described in 's3c_fb_win' drivers/video/fbdev/s3c-fb.c:345: warning: Function parameter or member 'pixclk' not described in 's3c_fb_calc_pixclk' drivers/video/fbdev/s3c-fb.c:345: warning: Excess function parameter 'pixclock' description in 's3c_fb_calc_pixclk' drivers/video/fbdev/s3c-fb.c:742: warning: Function parameter or member 'transp' not described in 's3c_fb_setcolreg' drivers/video/fbdev/s3c-fb.c:742: warning: Excess function parameter 'trans' description in 's3c_fb_setcolreg' drivers/video/fbdev/s3c-fb.c:1142: warning: Function parameter or member 'sfb' not described in 's3c_fb_release_win' drivers/video/fbdev/s3c-fb.c:1172: warning: Function parameter or member 'win_no' not described in 's3c_fb_probe_win' Cc: Jingoo Han Cc: Ben Dooks Cc: linux-fbdev@vger.kernel.org Cc: dri-devel@lists.freedesktop.org Signed-off-by: Lee Jones --- drivers/video/fbdev/s3c-fb.c | 9 ++++++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/drivers/video/fbdev/s3c-fb.c b/drivers/video/fbdev/s3c-fb.c index ba316bd56efd7..d33d7df77a6a5 100644 --- a/drivers/video/fbdev/s3c-fb.c +++ b/drivers/video/fbdev/s3c-fb.c @@ -75,6 +75,7 @@ struct s3c_fb; * @buf_size: Offset of buffer size registers. * @buf_end: Offset of buffer end registers. * @osd: The base for the OSD registers. + * @osd_stride: The OSD stride value. * @palette: Address of palette memory, or 0 if none. * @has_prtcon: Set if has PRTCON register. * @has_shadowcon: Set if has SHADOWCON register. @@ -155,7 +156,7 @@ struct s3c_fb_palette { * @windata: The platform data supplied for the window configuration. * @parent: The hardware that this window is part of. * @fbinfo: Pointer pack to the framebuffer info for this window. - * @varint: The variant information for this window. + * @variant: The variant information for this window. * @palette_buffer: Buffer/cache to hold palette entries. * @pseudo_palette: For use in TRUECOLOUR modes for entries 0..15/ * @index: The window number of this window. @@ -336,7 +337,7 @@ static int s3c_fb_check_var(struct fb_var_screeninfo *var, /** * s3c_fb_calc_pixclk() - calculate the divider to create the pixel clock. * @sfb: The hardware state. - * @pixclock: The pixel clock wanted, in picoseconds. + * @pixclk: The pixel clock wanted, in picoseconds. * * Given the specified pixel clock, work out the necessary divider to get * close to the output frequency. @@ -733,7 +734,7 @@ static inline unsigned int chan_to_field(unsigned int chan, * @red: The red field for the palette data. * @green: The green field for the palette data. * @blue: The blue field for the palette data. - * @trans: The transparency (alpha) field for the palette data. + * @transp: The transparency (alpha) field for the palette data. * @info: The framebuffer being changed. */ static int s3c_fb_setcolreg(unsigned regno, @@ -1133,6 +1134,7 @@ static void s3c_fb_free_memory(struct s3c_fb *sfb, struct s3c_fb_win *win) /** * s3c_fb_release_win() - release resources for a framebuffer window. + * @sfb: The base resources for the hardware. * @win: The window to cleanup the resources for. * * Release the resources that where claimed for the hardware window, @@ -1160,6 +1162,7 @@ static void s3c_fb_release_win(struct s3c_fb *sfb, struct s3c_fb_win *win) /** * s3c_fb_probe_win() - register an hardware window * @sfb: The base resources for the hardware + * @win_no: The ID of the window to be registered * @variant: The variant information for this window. * @res: Pointer to where to place the resultant window. * -- 2.25.1