Received: by 2002:a05:6a10:2785:0:0:0:0 with SMTP id ia5csp437153pxb; Wed, 13 Jan 2021 07:18:59 -0800 (PST) X-Google-Smtp-Source: ABdhPJxd8Do/7CFaUot2b5RaXVlfc4256nGBkcZ4ZHrZq6Ga7+U435F5RzKcIQ7U1fIexwa3TRDB X-Received: by 2002:a17:906:26d7:: with SMTP id u23mr1898827ejc.210.1610551138853; Wed, 13 Jan 2021 07:18:58 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1610551138; cv=none; d=google.com; s=arc-20160816; b=OVQ1V869QGcHbuLCoCz8EER/8T10GGKKD3v3DJrhqU+euMSxfMqe3shDdRhEJWGPbp g48gZRH/cNJDyXxy4vZ/dU8SkBGP31cwezcPVsmshOoU1Cll/BqC43NxvPSxW5M+k70k ZhwMqQVXJKQcTQbs7+CPgYtFB1xW1Tp9wS4rXFxq1sf4LD65OvSfhCs1AlS7Xofi4Q5v 5VvPMT1F9aivFjjf1NKGaDrS+UiHhFyQLQ8Vhq/9gboZuNx6CkJzBsOfxNdOnpw4uIai wPPGO4u54mDKDdfRk2gE47upPfz/dGDQdfYsPk47bYwLK2M5388ms3p7080hixcGMGoi flgg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:date:cc:to:from:subject:message-id :dkim-signature; bh=FFwSMGnjHPCEZG/p5ENas76+2RF2zeo2Gl3j/YpLT+Y=; b=f0BebfiBaG/QwCc+7Bl/n771sOyGANjb+7fA0tbYnRvPy9Dal1tu3fxDBgFvS/wjBZ DKQlpcBzk7slM4SgUZcV+g4ic/+LxDcLR3euysMJZxiNd5X+65qaF/lpibJtPCd915Ix owftrP1qBT04bf7GJKZvEx0U+tGCJ2M1c/bu69QjLO8AnYCd0fJxFaJv1mqJfdV3ZgOP iKlLvutRrf2KQ5G1VFOEzxhdF5TEYQpY7UkafOx+PNrG4CJyucHxLUeOmp1MOGyHAnUM OZyFNzHioun90QMw5iqJJY1jJuS5wgJIaPjQOStqCKgPl39QQQTw9brpMLdX6p34o47x iRTw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@ibm.com header.s=pp1 header.b=NSIBCVXO; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=ibm.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id q25si1138427edw.87.2021.01.13.07.18.27; Wed, 13 Jan 2021 07:18:58 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@ibm.com header.s=pp1 header.b=NSIBCVXO; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=ibm.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726502AbhAMPRX (ORCPT + 99 others); Wed, 13 Jan 2021 10:17:23 -0500 Received: from mx0b-001b2d01.pphosted.com ([148.163.158.5]:12894 "EHLO mx0a-001b2d01.pphosted.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1725949AbhAMPRW (ORCPT ); Wed, 13 Jan 2021 10:17:22 -0500 Received: from pps.filterd (m0098413.ppops.net [127.0.0.1]) by mx0b-001b2d01.pphosted.com (8.16.0.42/8.16.0.42) with SMTP id 10DFCsJ0012977; Wed, 13 Jan 2021 10:16:37 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=message-id : subject : from : to : cc : date : in-reply-to : references : content-type : mime-version : content-transfer-encoding; s=pp1; bh=FFwSMGnjHPCEZG/p5ENas76+2RF2zeo2Gl3j/YpLT+Y=; b=NSIBCVXOq4h/cHxyOvxZIsuO9TCbF6bHQxYRc9mRiTDG5kBGfnP0pp/0KVzmzk5GSSyO kYh7tI2iOWFDLSTs7E9pvAVFu+twYhwGGmqY2dluZ6oXdzilslgROCfngE2iqoHmdeWM MPRIprntvp7G+LV4bwqbRVDBpAW0BdAKaAIBqnCnjgIMPwU2iVsiLk5ZCdOtGKn44pwW 215HNO3bgleTanxUiomNC6TPA96Awhbwn2LBIDE7B4vJgnN9LbDVtwC3yVykkmNKQCwM R9ll3af3sV2ySLuIDzOoNaEXwIaAeRj/v0k1xYN7BU4YKK9fzhDrif4xwGQTM6b61DKM OQ== Received: from ppma04ams.nl.ibm.com (63.31.33a9.ip4.static.sl-reverse.com [169.51.49.99]) by mx0b-001b2d01.pphosted.com with ESMTP id 3623a383bd-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 13 Jan 2021 10:16:37 -0500 Received: from pps.filterd (ppma04ams.nl.ibm.com [127.0.0.1]) by ppma04ams.nl.ibm.com (8.16.0.42/8.16.0.42) with SMTP id 10DF8FmV012643; Wed, 13 Jan 2021 15:16:35 GMT Received: from b06avi18878370.portsmouth.uk.ibm.com (b06avi18878370.portsmouth.uk.ibm.com [9.149.26.194]) by ppma04ams.nl.ibm.com with ESMTP id 35y448d6y2-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 13 Jan 2021 15:16:35 +0000 Received: from b06wcsmtp001.portsmouth.uk.ibm.com (b06wcsmtp001.portsmouth.uk.ibm.com [9.149.105.160]) by b06avi18878370.portsmouth.uk.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 10DFGSUo29950208 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 13 Jan 2021 15:16:28 GMT Received: from b06wcsmtp001.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id CACC6A4054; Wed, 13 Jan 2021 15:16:32 +0000 (GMT) Received: from b06wcsmtp001.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 11142A4066; Wed, 13 Jan 2021 15:16:31 +0000 (GMT) Received: from sig-9-65-221-171.ibm.com (unknown [9.65.221.171]) by b06wcsmtp001.portsmouth.uk.ibm.com (Postfix) with ESMTP; Wed, 13 Jan 2021 15:16:30 +0000 (GMT) Message-ID: <19977f2dbe6d25d7b38bdca4628bd1dded1142d9.camel@linux.ibm.com> Subject: Re: [PATCH] [v2] evm: Fix memleak in init_desc From: Mimi Zohar To: Dinghao Liu , kjlu@umn.edu Cc: James Morris , "Serge E. Hallyn" , Dmitry Kasatkin , linux-integrity@vger.kernel.org, linux-security-module@vger.kernel.org, linux-kernel@vger.kernel.org Date: Wed, 13 Jan 2021 10:16:30 -0500 In-Reply-To: <20210110080253.32345-1-dinghao.liu@zju.edu.cn> References: <20210110080253.32345-1-dinghao.liu@zju.edu.cn> Content-Type: text/plain; charset="ISO-8859-15" X-Mailer: Evolution 3.28.5 (3.28.5-14.el8) Mime-Version: 1.0 Content-Transfer-Encoding: 7bit X-TM-AS-GCONF: 00 X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.343,18.0.737 definitions=2021-01-13_07:2021-01-13,2021-01-13 signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 suspectscore=0 mlxscore=0 lowpriorityscore=0 clxscore=1015 spamscore=0 adultscore=0 bulkscore=0 malwarescore=0 priorityscore=1501 impostorscore=0 mlxlogscore=834 phishscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2009150000 definitions=main-2101130090 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Dinghao, On Sun, 2021-01-10 at 16:02 +0800, Dinghao Liu wrote: > When kmalloc() fails, tmp_tfm allocated by > crypto_alloc_shash() has not been freed, which > leads to memleak. > > Fixes: d46eb3699502b ("evm: crypto hash replaced by shash") > Signed-off-by: Dinghao Liu This patch is now queued, with an updated patch description, in next- integrity-testing. thanks, Mimi