Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Wed, 13 Jan 2021 16:34:08 +0100
From:   Oleg Nesterov <oleg@redhat.com>
To:     Marcus Huewe <suse-tux@gmx.de>,
        Andrew Morton <akpm@linux-foundation.org>
Cc:     linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ptrace: Remove redundant code in ptrace_attach
Message-ID: <20210113153408.GA26690@redhat.com>
References: <53924ce0d6f0c15575b5d7dbef2a8038bc27b4ed.1610544906.git.suse-tux@gmx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <53924ce0d6f0c15575b5d7dbef2a8038bc27b4ed.1610544906.git.suse-tux@gmx.de>
User-Agent: Mutt/1.5.24 (2015-08-30)
Precedence: bulk

Acked-by: Oleg Nesterov <oleg@redhat.com>


On 01/13, Marcus Huewe wrote:
>
> In case of a PTRACE_SEIZE request, the PT_SEIZED flag is always set
> at the beginning of ptrace_attach. Hence, there is no need to set
> it again (neither "flags" nor "seize" are modified in between/after
> the initial assignment).
> 
> Signed-off-by: Marcus Huewe <suse-tux@gmx.de>
> ---
>  kernel/ptrace.c | 2 --
>  1 file changed, 2 deletions(-)
> 
> diff --git a/kernel/ptrace.c b/kernel/ptrace.c
> index 61db50f7ca86..059fce2ad53c 100644
> --- a/kernel/ptrace.c
> +++ b/kernel/ptrace.c
> @@ -402,8 +402,6 @@ static int ptrace_attach(struct task_struct *task, long request,
>  	if (task->ptrace)
>  		goto unlock_tasklist;
> 
> -	if (seize)
> -		flags |= PT_SEIZED;
>  	task->ptrace = flags;
> 
>  	ptrace_link(task, current);
> --
> 2.29.2
>