Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
IronPort-SDR: /cpoqSpCx5YQU+hlCYuGwrkq+EiqdycGSOkYiIGyL9OSeHmIgriPQVPrZyzhNxqNp0snAE5wDY
 LkQ8slqVB8yH3h/S6oMKENi4yUNq/L25Pz2U0HjmaJDxt46nWn2gC+Hoa/CbOa6liXvmOQT02r
 D4m6UP84koB9DfGQs4PFfbwewsuDh4+5QFd7R51ltak7urCaEny9ihPK8q40i9Yrhzsw8C/3IO
 OZCi7dNhrpsTaZrYButorsvQOk0ZMn8Zc6plhPRWA0fDqnb++CnzOE5+NE9PQ9ifP61yfwW/RC
 Fkk=
From:   Johannes Thumshirn <Johannes.Thumshirn@wdc.com>
To:     Li Feng <fengli@smartx.com>,
        "martin.petersen@oracle.com" <martin.petersen@oracle.com>,
        Keith Busch <kbusch@kernel.org>, Jens Axboe <axboe@fb.com>,
        Christoph Hellwig <hch@lst.de>,
        Sagi Grimberg <sagi@grimberg.me>,
        "open list:NVM EXPRESS DRIVER" <linux-nvme@lists.infradead.org>,
        open list <linux-kernel@vger.kernel.org>
CC:     "lifeng1519@gmail.com" <lifeng1519@gmail.com>
Subject: Re: [PATCH] nvme: reject the ns when the block size is smaller than a
 sector
Thread-Topic: [PATCH] nvme: reject the ns when the block size is smaller than
 a sector
Thread-Index: AQHW6cYiQ8r0UOC3okaYJHPdW7DXCw==
Date:   Wed, 13 Jan 2021 16:18:26 +0000
Message-ID: <SN4PR0401MB35985C08E5FFCDF0F5817A9D9BA90@SN4PR0401MB3598.namprd04.prod.outlook.com>
References: <20210113160621.98615-1-fengli@smartx.com>
Accept-Language: en-US
Content-Language: en-US
wdcipoutbound: EOP-TRUE
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-Network-Message-Id: 5b11ee09-8063-4ebe-8c8b-08d8b7dedb54
X-MS-Exchange-CrossTenant-originalarrivaltime: 13 Jan 2021 16:18:26.2579
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: b61c8803-16f3-4c35-9b17-6f65f441df86
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: teadxG2QjroiHl9WQq6Mo3r8R6jk9O6Jo/GX192p1+kbfK7xzKOI9TLiHygmU62ju7wYj3mXPwCfeLInZbDucDR+0LR7NBOQe7zyhzDA1DY=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN6PR04MB4160
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 13/01/2021 17:07, Li Feng wrote:=0A=
> The nvme spec(1.4a, figure 248) says:=0A=
> "A value smaller than 9 (i.e., 512 bytes) is not supported."=0A=
> =0A=
> Signed-off-by: Li Feng <fengli@smartx.com>=0A=
> ---=0A=
>  drivers/nvme/host/core.c | 6 ++++++=0A=
>  1 file changed, 6 insertions(+)=0A=
> =0A=
> diff --git a/drivers/nvme/host/core.c b/drivers/nvme/host/core.c=0A=
> index f320273fc672..1f02e6e49a05 100644=0A=
> --- a/drivers/nvme/host/core.c=0A=
> +++ b/drivers/nvme/host/core.c=0A=
> @@ -2161,6 +2161,12 @@ static int nvme_update_ns_info(struct nvme_ns *ns,=
 struct nvme_id_ns *id)=0A=
>  =0A=
>  	blk_mq_freeze_queue(ns->disk->queue);=0A=
>  	ns->lba_shift =3D id->lbaf[lbaf].ds;=0A=
> +	if (ns->lba_shift < 9) {=0A=
> +		pr_warn("%s: bad lba_shift(%d)\n", ns->disk->disk_name, ns->lba_shift)=
;=0A=
> +		ret =3D -1;=0A=
> +		goto out_unfreeze;=0A=
> +	}=0A=
> +=0A=
>  	nvme_set_queue_limits(ns->ctrl, ns->queue);=0A=
>  =0A=
>  	if (ns->head->ids.csi =3D=3D NVME_CSI_ZNS) {=0A=
> =0A=
=0A=
=0A=
But this only catches a physical block size < 512 for NVMe, not any other b=
lock device.=0A=
=0A=
Please fix it for the general case in blk_queue_physical_block_size().=0A=
=0A=
Thanks,=0A=
	Johannes=0A=