Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <20190208131738.27668-1-andrejs.cainikovs@netmodule.com>
 <20190208131738.27668-2-andrejs.cainikovs@netmodule.com> <080346c5-eace-f0bc-ef3a-0354988b9fb4@pengutronix.de>
In-Reply-To: <080346c5-eace-f0bc-ef3a-0354988b9fb4@pengutronix.de>
From:   Ezequiel Garcia <ezequiel@vanguardiasur.com.ar>
Date:   Wed, 13 Jan 2021 15:49:18 -0300
Message-ID: <CAAEAJfAJs4fpTX=_caS3f7GA1V-bouVQ_G913MXb80Cn_DmFWw@mail.gmail.com>
Subject: Re: [PATCH 1/2] can: c_can: support 64 message objects for D_CAN
To:     Marc Kleine-Budde <mkl@pengutronix.de>
Cc:     Andrejs Cainikovs <Andrejs.Cainikovs@netmodule.com>,
        Wolfgang Grandegger <wg@grandegger.com>,
        "linux-can@vger.kernel.org" <linux-can@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        Patrick Zysset <Patrick.Zysset@netmodule.com>,
        "Federico Rossi (fede.a.rossi@gmail.com)" <fede.a.rossi@gmail.com>,
        Maximiliano Sonnaillon <msonnaillon@gmail.com>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

Hi Andrejs, Marc,

On Wed, 24 Jul 2019 at 06:48, Marc Kleine-Budde <mkl@pengutronix.de> wrote:
>
> On 2/8/19 2:17 PM, Andrejs Cainikovs wrote:
> > D_CAN supports up to 128 message objects, comparing to 32 on C_CAN.
> > However, some CPUs with D_CAN controller have their own limits:
> > TI AM335x Sitara CPU, for example, supports max of 64 message objects.
> >
> > This patch extends max D_CAN message objects up to 64.
>
> Please don't make this a kconfig option.
>
> According to you description this is a HW feature, so please add the max
> number of messe objects to "struct c_can_driver_data" and adjust the
> drvdata accordingly.
>
> > static const struct of_device_id c_can_of_table[] = {
> >       { .compatible = "bosch,c_can", .data = &c_can_drvdata },
> >       { .compatible = "bosch,d_can", .data = &d_can_drvdata },
> >       { .compatible = "ti,dra7-d_can", .data = &dra7_dcan_drvdata },
> >       { .compatible = "ti,am3352-d_can", .data = &am3352_dcan_drvdata },
> >       { .compatible = "ti,am4372-d_can", .data = &am3352_dcan_drvdata },
> >       { /* sentinel */ },
> > };
>
> You probably have to pass it via "struct c_can_priv" so that it's
> available in the c_can.c
>

I came here to make the same suggestion :-)

Andrejs, do you think you could respin this patch? Or perhaps I can find
some time to do that myself, if that's OK with you.

Thanks,
Ezequiel