Received: by 2002:a05:6a10:2785:0:0:0:0 with SMTP id ia5csp649055pxb; Wed, 13 Jan 2021 12:24:09 -0800 (PST) X-Google-Smtp-Source: ABdhPJzUa2uU04I3lkujubsxRdhmR4x76KD15XJDQAx8kdO8gwNqgFdXEbEXKpEBynfMWRVpJGyU X-Received: by 2002:a17:906:15ca:: with SMTP id l10mr2672790ejd.402.1610569449464; Wed, 13 Jan 2021 12:24:09 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1610569449; cv=none; d=google.com; s=arc-20160816; b=jou3EyWgfi873GKsGqHhNaoySIIonsk+RD4BSafJCvo4JsIMPTYQ/9wCvgoiI5anh2 VUfWsCMWM9EfS7hr9B+m/zhS1iFzNkIxdA0ohWIbncSiq1oG1fR1QMtbZ3pBIpyB7Zg1 wbFSqhPVK8ozFZjRtETBn/875M2GP9zbti9hVjuluxWjoWy2ItROD3xXpl5Ids/Ofrks dRPSgGSOC7W9hHpojDz2D7S+UAHNSRmr/srZeFt90v7ZSpgS2RE2cRiY7ihQfqLBgZjv CKTM26tn5paKsvNAPyIX0a0XVCLn38+d6MjoBQeLvVRPS3Pf/us/NhoclEYDodiiUd+K yfxg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:user-agent:message-id:date:to:cc:from:subject :references:in-reply-to:content-transfer-encoding:mime-version :dkim-signature; bh=u6R4AQJwna1Zvnrc86J9azzfneuprQEtwwFsQuVc3og=; b=gbBQd+DBORTLSONORWkRH6C8mNblNcXzpBxTyRBn/wottBD9sh9aLBAToQc9Lm13m+ Drk4t/ywEOey8fUdduVyhxgeqAPGSrAv5ZVoJ9CPKNEIDbc+uMOBPOG1r/KRlrmurcQ9 6noYPAsG97dpwT+4Vlw4aEN594mzmniRZhRFSIPjpdkCCXp2q/GAOqoQG55P93zDrEpS GQ0rA6W76FA3XomMfqZf9w/anvWtrHjAsLdakqVf0HLp1mR+4PMIz+p9lxuz8OMicvpx J//b1wYctJC98hisfw1us1EdkvHQGWNsV71DGh3MoZVcFkrRrmyDv1DkZIW6V5W0MxlQ ygVA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@chromium.org header.s=google header.b=iGXcSZ3v; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id h11si1581621edw.275.2021.01.13.12.23.45; Wed, 13 Jan 2021 12:24:09 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@chromium.org header.s=google header.b=iGXcSZ3v; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728934AbhAMUWB (ORCPT + 99 others); Wed, 13 Jan 2021 15:22:01 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57046 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728931AbhAMUWA (ORCPT ); Wed, 13 Jan 2021 15:22:00 -0500 Received: from mail-pl1-x62d.google.com (mail-pl1-x62d.google.com [IPv6:2607:f8b0:4864:20::62d]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 811C7C061786 for ; Wed, 13 Jan 2021 12:21:20 -0800 (PST) Received: by mail-pl1-x62d.google.com with SMTP id g3so1724891plp.2 for ; Wed, 13 Jan 2021 12:21:20 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=mime-version:content-transfer-encoding:in-reply-to:references :subject:from:cc:to:date:message-id:user-agent; bh=u6R4AQJwna1Zvnrc86J9azzfneuprQEtwwFsQuVc3og=; b=iGXcSZ3vf/7+lrMXeBvMLEppSiK1QOGxXONM1Ag/hWB8KQDBSrKEAAFvMTVAdX8mo2 904o7LBICMF1rvrHUaBQjuc6HXgMDjU58eUM9Bo7IEbtvn1CjU0CPmJprq1EE7mt5lrJ kMGx+WtjLTWHCgokFZwc9UoaNZ94W7yzydDh4= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:content-transfer-encoding :in-reply-to:references:subject:from:cc:to:date:message-id :user-agent; bh=u6R4AQJwna1Zvnrc86J9azzfneuprQEtwwFsQuVc3og=; b=siLlUBD5+d1u34Mjvt+S1YLZvNeZE3IXegN5SBPATd1YizPAhn+4cwBXoldcD1m7VL +Lykkpwyx2Pr43NpIVO4E5lXCHDY+okFB4OArQMFWsBsGuJzIqDrZ+P59CTPLhXv1eP/ Bgl23zwDBdq0E3ZBVdzGADYSFIwQmgM03GMMKMbe/LWP+6UBccSwnLMOo+4Xv6aaCWyU Eh9o/Um1Rc12llif0gS1LrbGUAdoAQWD4OTUommmopWXjboj5Q3KxVEKvJBygf1nLSKD 4XgPk856AocO156Uv+exXmeRetnn80sf2qH2fKXoEL8r9D8xHiDGA3/GlaO2iA2JoZJt /l1g== X-Gm-Message-State: AOAM532yhPAGkLqMAKwxkDajWMAsRFRNQhILDlRaidaw+E9eGUW7yyeC GyGGy6Z0O2X9Wk0MPrH5VuJpXw== X-Received: by 2002:a17:90a:3e4f:: with SMTP id t15mr1038628pjm.57.1610569279973; Wed, 13 Jan 2021 12:21:19 -0800 (PST) Received: from chromium.org ([2620:15c:202:201:3e52:82ff:fe6c:83ab]) by smtp.gmail.com with ESMTPSA id g26sm3323866pfo.35.2021.01.13.12.21.19 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 13 Jan 2021 12:21:19 -0800 (PST) Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable In-Reply-To: <17a116011ae60194834210a4a0c877b3@codeaurora.org> References: <1610051425-20632-1-git-send-email-khsieh@codeaurora.org> <1610051425-20632-2-git-send-email-khsieh@codeaurora.org> <161039491877.3661239.1387205899512360969@swboyd.mtv.corp.google.com> <17a116011ae60194834210a4a0c877b3@codeaurora.org> Subject: Re: [PATCH 1/2] drm/msm/dp: postpone irq_hpd event during connection pending state From: Stephen Boyd Cc: dri-devel@lists.freedesktop.org, robdclark@gmail.com, sean@poorly.run, tanmay@codeaurora.org, abhinavk@codeaurora.org, aravindh@codeaurora.org, airlied@linux.ie, daniel@ffwll.ch, linux-arm-msm@vger.kernel.org, freedreno@lists.freedesktop.org, linux-kernel@vger.kernel.org To: khsieh@codeaurora.org Date: Wed, 13 Jan 2021 12:21:17 -0800 Message-ID: <161056927774.3661239.6186577459996584479@swboyd.mtv.corp.google.com> User-Agent: alot/0.9.1 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Quoting khsieh@codeaurora.org (2021-01-13 09:44:24) > On 2021-01-11 11:55, Stephen Boyd wrote: > > Quoting Kuogee Hsieh (2021-01-07 12:30:24) > >> irq_hpd event can only be executed at connected state. Therefore > >> irq_hpd event should be postponed if it happened at connection > >> pending state. This patch also make sure both link rate and lane > >=20 > > Why does it happen at connection pending state? > plug in need two state to complete it. > advance to connection pending state once link training completed and=20 > sent uevent notification to frame work. > transition to connected state after frame work provided resolution=20 > timing and start transmit video panel. > Therefore irq_hpd should not be handled if it occurred before connected=20 > state. > >=20 > >> are valid before start link training. > >=20 > > Can this part about link rate and lane being valid be split off into > > another patch? > >=20 > ok, i will spilt this patch into two. > I will merge irq_hpd event part into 2nd patch (drm/msm/dp: unplug=20 > interrupt missed after irq_hpd handler). It looks like Rob already picked this patch up https://gitlab.freedesktop.org/drm/msm/-/commit/2b5f09cadfc576817c0450e01d4= 54f750909b103