Received: by 2002:a05:6a10:2785:0:0:0:0 with SMTP id ia5csp835127pxb; Wed, 13 Jan 2021 17:51:13 -0800 (PST) X-Google-Smtp-Source: ABdhPJylNy2POYji9DHnTZI/Zr7zlo3ZWqWNaJtjmauNqEWIF7eBQKJtkEplxrKQ8Iv4iv6PY7Kl X-Received: by 2002:a17:906:6448:: with SMTP id l8mr3717720ejn.357.1610589073280; Wed, 13 Jan 2021 17:51:13 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1610589073; cv=none; d=google.com; s=arc-20160816; b=nBz5Jb2YXmFKLnHy26kJwMo8oUZrTIZTOgGFD8UmAqHy2pABKqDTT5QYvzW6aqWpYu vF/dulqyZiswL0tdffiTLLizMShl3DPt6Fpsnm+iZx4zaQBkFihidnjRY0EiTdmM4rn1 Dksvd4kkZtS9/5895PRivDqjQ31XFDrwLjcQ5wp5YLn3ogUiTRpv35gUPjrMX86tXxsk 7SMf+jq49l7fF4mArCO28LpMIA81Q1jOnuRwluMe1J00kK9rSQxJyj9T3/euP1zT9Mwl x2xFUKXzsqfiWFL3OL4ZwAXeV8n/dMS+qPJGUdYt7AsJd6FU7jBVIP1Fv7bX3Oq0yxIu ZISQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:cc:to:from:subject:mime-version:message-id:date :reply-to:sender:dkim-signature; bh=M4LPvVO0tM+kRKTIgz3UZuoOLiPTa+F2++4IgfISsGU=; b=ELFJjWmKkjfeOwXDn+VM6WJF1CpCJmFFCmOLlvWZrmnZ6nbSn+a9QXZhlC0gDdhybV X2MqggBqDBuRREXfgO5qplwgK8dF7lN23YkQWjuF8uLFPm4CMmALcWEAFCOJPIHKE98h aUYAiJa1URHQ10i4m2acDbLYmjppMhoj61bvHf6aUrPRRxB5umsQb7vwY36xqMUeIEFU 9c0+th31k2mQ9RQWIfyHzo7B5rd18Vqe0N+RTY4TP1NSnnVo+BF7BjFXLLueVdZ4D973 LyOj+w+bRd/nmY1TYp0Hl/6MhSmgQVxVZ5FzpquxpjRsQfCZsyTL6NBBj9v++lPxeoIv S3wQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@google.com header.s=20161025 header.b=i7ZE3PF3; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=google.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id x12si1735149ejw.662.2021.01.13.17.50.50; Wed, 13 Jan 2021 17:51:13 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@google.com header.s=20161025 header.b=i7ZE3PF3; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=google.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728439AbhANBso (ORCPT + 99 others); Wed, 13 Jan 2021 20:48:44 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55676 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729925AbhANAi0 (ORCPT ); Wed, 13 Jan 2021 19:38:26 -0500 Received: from mail-qt1-x84a.google.com (mail-qt1-x84a.google.com [IPv6:2607:f8b0:4864:20::84a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1B0CFC061786 for ; Wed, 13 Jan 2021 16:37:34 -0800 (PST) Received: by mail-qt1-x84a.google.com with SMTP id l6so2984568qtr.9 for ; Wed, 13 Jan 2021 16:37:34 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=sender:reply-to:date:message-id:mime-version:subject:from:to:cc; bh=M4LPvVO0tM+kRKTIgz3UZuoOLiPTa+F2++4IgfISsGU=; b=i7ZE3PF376aaxN+KR1fKdzuL+kCPx/rAU4BbsW6Zsv5hRh80qwO4OekpJ/Q3LNVd+S buGljMOzOYmqZJeNpGO+/eE7DBn0+kPAz0VC1jUNpCJzIfth1ks/WwaKXag+n4X0BTu2 2+o6sUyFYRn/yMn6sLiKJyQy2zSUYTDdkE3MFN3HaP9mK8weIglwU1E0Ta6JTmU9Egod dMr1QOE5kLBhWsEfEVYzD/vLA/kexAyTOcKR48vd2e6V2pWr2aAqzj0pKDKaCO4f0neg zqYXqyA3VlpudbEv7MQi//44BASoZUlPGuRgBHj2eQs1UAwmRQ8GEk7uPJCbvanhHTQ0 gKYw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:reply-to:date:message-id:mime-version :subject:from:to:cc; bh=M4LPvVO0tM+kRKTIgz3UZuoOLiPTa+F2++4IgfISsGU=; b=QhJ0scgn+WKE5paYfjS9xHwvkJd1kVeRH7Yxk4nRxgvhq/Xtt+Ah1PIZKd9ulk1DtY tkd0DY9kKYts75xjJWzjmpuXhTiqA8nq/ERPXhFdS+ZOPDvIJuoGD1a/2R2+Jv/o4OS6 2SEHk5m97KtLmdDpiqyS7hO3WDO8jzUUHsFkBcr3/Ky1mXyCES4Ox95l08S0o7BPaOO5 lk5rWC3zHAE7bQHM7sonphv5Ume4p36OUtNddgYrB+nB5K09Cnv3nIN4fnTp2S70E/2E qnpW8WzMVX+F6az22Owti0aSopg5muGs2ZhjXjSh41XvKwQJulEgvMHcEQvZeUu9eWSv cGwg== X-Gm-Message-State: AOAM530wNP46IGWxPGwUBenFsrnETLafoWoLmARoYwKTjBuo2pQH4KoV YqLuL0yQAzyY9YZfT76djlFxsCeuRvo= Sender: "seanjc via sendgmr" X-Received: from seanjc798194.pdx.corp.google.com ([2620:15c:f:10:1ea0:b8ff:fe73:50f5]) (user=seanjc job=sendgmr) by 2002:a25:1b05:: with SMTP id b5mr7077713ybb.298.1610584653170; Wed, 13 Jan 2021 16:37:33 -0800 (PST) Reply-To: Sean Christopherson Date: Wed, 13 Jan 2021 16:36:54 -0800 Message-Id: <20210114003708.3798992-1-seanjc@google.com> Mime-Version: 1.0 X-Mailer: git-send-email 2.30.0.284.gd98b1dd5eaa7-goog Subject: [PATCH v2 00/14] KVM: SVM: Misc SEV cleanups From: Sean Christopherson To: Paolo Bonzini , Dave Hansen , Andy Lutomirski , Peter Zijlstra Cc: Sean Christopherson , Vitaly Kuznetsov , Wanpeng Li , Jim Mattson , Joerg Roedel , kvm@vger.kernel.org, linux-kernel@vger.kernel.org, Borislav Petkov , Tom Lendacky , Brijesh Singh Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Minor bug fixes and refactorings of SEV related code, mainly to clean up the KVM code for tracking whether or not SEV and SEV-ES are enabled. E.g. KVM has both sev_es and svm_sev_enabled(), and a global 'sev' flag while also using 'sev' as a local variable in several places. Based on kvm/master, commit 872f36eb0b0f ("KVM: x86: __kvm_vcpu_halt can be static"). v2: - Remove the kernel's sev_enabled instead of renaming it to sev_guest. - Fix various build issues. [Tom] - Remove stable tag from the patch to free sev_asid_bitmap. Keeping the bitmap on failure is truly only a leak once svm_sev_enabled() is dropped later in the series. It's still arguably a fix since KVM will unnecessarily keep memory, but it's not stable material. [Tom] - Collect one Ack. [Tom] v1: - https://lkml.kernel.org/r/20210109004714.1341275-1-seanjc@google.com Sean Christopherson (14): KVM: SVM: Zero out the VMCB array used to track SEV ASID association KVM: SVM: Free sev_asid_bitmap during init if SEV setup fails KVM: SVM: Move SEV module params/variables to sev.c x86/cpufeatures: Assign dedicated feature word for AMD mem encryption KVM: x86: Override reported SME/SEV feature flags with host mask x86/sev: Drop redundant and potentially misleading 'sev_enabled' KVM: SVM: Append "_enabled" to module-scoped SEV/SEV-ES control variables KVM: SVM: Condition sev_enabled and sev_es_enabled on CONFIG_KVM_AMD_SEV=y KVM: SVM: Unconditionally invoke sev_hardware_teardown() KVM: SVM: Explicitly check max SEV ASID during sev_hardware_setup() KVM: SVM: Move SEV VMCB tracking allocation to sev.c KVM: SVM: Drop redundant svm_sev_enabled() helper KVM: SVM: Remove an unnecessary prototype declaration of sev_flush_asids() KVM: SVM: Skip SEV cache flush if no ASIDs have been used arch/x86/include/asm/cpufeature.h | 7 +- arch/x86/include/asm/cpufeatures.h | 17 +++-- arch/x86/include/asm/disabled-features.h | 3 +- arch/x86/include/asm/mem_encrypt.h | 1 - arch/x86/include/asm/required-features.h | 3 +- arch/x86/kernel/cpu/common.c | 3 + arch/x86/kernel/cpu/scattered.c | 5 -- arch/x86/kvm/cpuid.c | 2 + arch/x86/kvm/cpuid.h | 1 + arch/x86/kvm/svm/sev.c | 71 +++++++++++++------ arch/x86/kvm/svm/svm.c | 35 +++------ arch/x86/kvm/svm/svm.h | 8 +-- arch/x86/mm/mem_encrypt.c | 12 ++-- arch/x86/mm/mem_encrypt_identity.c | 1 - .../arch/x86/include/asm/disabled-features.h | 3 +- .../arch/x86/include/asm/required-features.h | 3 +- 16 files changed, 96 insertions(+), 79 deletions(-) -- 2.30.0.284.gd98b1dd5eaa7-goog