Received: by 2002:a05:6a10:2785:0:0:0:0 with SMTP id ia5csp838029pxb; Wed, 13 Jan 2021 17:56:23 -0800 (PST) X-Google-Smtp-Source: ABdhPJwBJdDx5N6CvOLKs3SAkxiSAx7ZFGKrtY/1jLXkSKRSQPhloEzm/Laa+Hxmf8MYqs3/pq6d X-Received: by 2002:a17:906:97cb:: with SMTP id ef11mr3520773ejb.379.1610589383387; Wed, 13 Jan 2021 17:56:23 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1610589383; cv=none; d=google.com; s=arc-20160816; b=gvjSrCDQhA7QYXpgZ2W+Fvj26f5MqnPjyyQX6z2tCI4LUvo8R5KE5bzfEvpqBK9JIf Jibdj5ORZcKAAJuc8SmPPNf6ZWWIMu1fGCjxcaVBvY9AwHs317bhbn4D65TxkXA5LB4i KPncsdAzPAixvfOSHpMjF3bNRty4mZ3stJO1UeqDaJhDV2bzRLqSqLdoFVDXPRjQcRxf LpwFJ8yIqHG74XHvEUpiXBIfS+HtE0hIsKSRZ255G2UvauCFmhhNrm0nkQL2jjJxNhbg xAwrUTrVPsEUD4EtcKbSWFzo4DJE2u+SUWpfYLHijaVnDU4xez5A+XxpC0rGm6ELoN9k K1zQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=yIc90bW9hdDuSreHeH201JXVN8WhV0iJyZz/kubhn2U=; b=XUg5WjnLh6Dt4sfrH0o3sK/YYxWifmNyBZhw3ddrNkSymHlxZjWIxL6oi4v6kp4fqJ QFUHKi3JOhTzZkPqKaB+025KD/P+nLeR9aPKmwnVg0IEi9J9Kba5bFBkCqAOlZaC7TZK 9a/R/Pdrfui9FSqDcqZdD26RFSlqPiwLXDN6KNxpe+0wyk0BH6wqo7kSV3Zy0LsY8KvX kUDEyrnUbsWyhgUChB/lOjkXt6EVvJfKv5YNDdOsDMimFsuetWPQ1vC3/53OFed/iDI4 BtXAZydX3MecwyAQPGtcXC0CoJ/7HUrGGZZppJ1gTxfLEDYcOPNYMTGXMpZ/AV6a6uj0 PAsA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=vXFOLIpp; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id q7si1903384edt.86.2021.01.13.17.55.59; Wed, 13 Jan 2021 17:56:23 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=vXFOLIpp; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728425AbhANByl (ORCPT + 99 others); Wed, 13 Jan 2021 20:54:41 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46378 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729649AbhAMXzB (ORCPT ); Wed, 13 Jan 2021 18:55:01 -0500 Received: from mail-ej1-x62e.google.com (mail-ej1-x62e.google.com [IPv6:2a00:1450:4864:20::62e]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 63766C06179F; Wed, 13 Jan 2021 15:54:20 -0800 (PST) Received: by mail-ej1-x62e.google.com with SMTP id q22so5638845eja.2; Wed, 13 Jan 2021 15:54:20 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=yIc90bW9hdDuSreHeH201JXVN8WhV0iJyZz/kubhn2U=; b=vXFOLIppPxJWwQ/+M9kwbl6rHSoPu1ihYrInNKuc57pOvlCIMJloYHPx/m4fRodCfs c9uDTXFot2AsQo67j+pME4UQCrtUX2Cskt4v6W0TPbLFTwG+vKWGpO7H596Nvesivddj T5u70ixQSGNfNl2NqzZI7acrDVh4q5HXhmf6tGM/neIhqDXriOADhggEHzi7ZZ9HKsJQ au+renKxLfzw2qbMCd+i1W/ICmH1lt+fWvm3lvAEPxS9OXNEIzch9hhWJnAdBPTCkjLi i7q1ZIQ0STU56IMMGL8aU/XUnA2b0E73WD2ZW3ivqJYsySVy4tQ4TUak18LIjtW2y0/d lBgg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=yIc90bW9hdDuSreHeH201JXVN8WhV0iJyZz/kubhn2U=; b=b6cuFmJZbcvOuevi7CYff9o1p4vnQ8xwXPTtkPzOTbUPOXajNiabvSloM0OL5hRf8v 1VyyOCgsWy3UiTnrdsxsZUvJPYJR/VYkKeZNj5L35sD1b33gHfggHK11k3kmYjZCC8Mi 4Ua3AcpjvOXqBR3Ogaclf8ViImYRZv/+mOv1q3Uo+hiGGObKuFFT2wMTEGJIKyNoAgpa qJQltc9Aqo3xNIn7tfToJAoXd77fLsSHLh69L5PGVz0IjFkgCpMJ+3ywhsiewGiPHRDy d2siA0fyUDBYrQxBperJZZ1tKAJTLf22tyLmsmxcyIXcw6G+9YCbDzPfrDHrxACt/osM 1Gug== X-Gm-Message-State: AOAM531m1tNECa3gEBnJITHrTod0NqSgrllTy/dFunnIp1WFbV487wJl oJjSfhjV2FGu/ipL9pQHdoo= X-Received: by 2002:a17:906:8051:: with SMTP id x17mr3168209ejw.430.1610582059123; Wed, 13 Jan 2021 15:54:19 -0800 (PST) Received: from skbuf (5-12-227-87.residential.rdsnet.ro. [5.12.227.87]) by smtp.gmail.com with ESMTPSA id c12sm1439744edw.55.2021.01.13.15.54.17 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 13 Jan 2021 15:54:18 -0800 (PST) Date: Thu, 14 Jan 2021 01:54:17 +0200 From: Vladimir Oltean To: Gilles DOFFE Cc: netdev@vger.kernel.org, Woojung Huh , UNGLinuxDriver@microchip.com, Andrew Lunn , Vivien Didelot , Florian Fainelli , "David S. Miller" , Jakub Kicinski , linux-kernel@vger.kernel.org Subject: Re: [PATCH net 5/6] net: dsa: ksz: fix wrong pvid Message-ID: <20210113235417.pnpsfiiq72a2cwkd@skbuf> References: <4d34da2534c912e290d77d4296a4aa68229fd6e6.1610540603.git.gilles.doffe@savoirfairelinux.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <4d34da2534c912e290d77d4296a4aa68229fd6e6.1610540603.git.gilles.doffe@savoirfairelinux.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Jan 13, 2021 at 01:45:21PM +0100, Gilles DOFFE wrote: > A logical 'or' was performed until now. > So if vlan 1 is the current pvid and vlan 20 is set as the new one, > vlan 21 is the new pvid. > This commit fixes this by setting the right mask to set the new pvid. > > Signed-off-by: Gilles DOFFE > --- Reviewed-by: Vladimir Oltean