Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: quoted-printable
In-Reply-To: <20210113172450.v5.2.I38e90f114f0311b8aa3bcfff750ba381c09dd3b6@changeid>
References: <20210113172450.v5.1.I025fb861cd5fa0ef5286b7dce514728e9df7ae74@changeid> <20210113172450.v5.2.I38e90f114f0311b8aa3bcfff750ba381c09dd3b6@changeid>
Subject: Re: [PATCH v5 2/2] Input: cros-ec-keyb - Expose function row physical map to userspace
From:   Stephen Boyd <swboyd@chromium.org>
Cc:     dianders@chromium.org, Philip Chen <philipchen@chromium.org>,
        Benson Leung <bleung@chromium.org>,
        Enric Balletbo i Serra <enric.balletbo@collabora.com>,
        Guenter Roeck <groeck@chromium.org>,
        Lee Jones <lee.jones@linaro.org>,
        Rajat Jain <rajatja@google.com>, linux-input@vger.kernel.org
To:     LKML <linux-kernel@vger.kernel.org>,
        Philip Chen <philipchen@chromium.org>,
        dmitry.torokhov@gmail.com
Date:   Wed, 13 Jan 2021 17:36:45 -0800
Message-ID: <161058820506.3661239.14441197324080899810@swboyd.mtv.corp.google.com>
User-Agent: alot/0.9.1
Precedence: bulk

Quoting Philip Chen (2021-01-13 17:25:13)
> diff --git a/drivers/input/keyboard/cros_ec_keyb.c b/drivers/input/keyboa=
rd/cros_ec_keyb.c
> index b379ed7628781..273e3c9ba0b03 100644
> --- a/drivers/input/keyboard/cros_ec_keyb.c
> +++ b/drivers/input/keyboard/cros_ec_keyb.c
> @@ -578,6 +590,19 @@ static int cros_ec_keyb_register_matrix(struct cros_=
ec_keyb *ckdev)
>         ckdev->idev =3D idev;
>         cros_ec_keyb_compute_valid_keys(ckdev);
> =20
> +       of_property_for_each_u32(dev->of_node, "function-row-physmap",
> +                                prop, p, key_pos) {
> +               if (i >=3D MAX_NUM_TOP_ROW_KEYS) {
> +                       dev_err(dev, "Only support up to %d top row keys.=
\n",

dev_warn? And drop the period please as we don't add them in the kernel
usually.

> +                               MAX_NUM_TOP_ROW_KEYS);
> +                       break;
> +               }
> +               ckdev->function_row_physmap[i] =3D MATRIX_SCAN_CODE(

Maybe grow some more local variables, like for function_row_physmap so
this can fit on one line?

		row =3D KEY_ROW(key_pos);
		col =3D KEY_COL(key_pos);
		map[i] =3D MATRIX_SCAN_CODE(row, col, ckdev->row_shift);

> +                       KEY_ROW(key_pos), KEY_COL(key_pos), ckdev->row_sh=
ift);
> +               i++;

We could remove this and just increment num_function_row_keys instead.
Then that condition check may be a little longer but probably still ok.


> +       }
> +       ckdev->num_function_row_keys =3D i;
> +
>         err =3D input_register_device(ckdev->idev);
>         if (err) {
>                 dev_err(dev, "cannot register input device\n");