Received: by 2002:a05:6a10:2785:0:0:0:0 with SMTP id ia5csp843697pxb; Wed, 13 Jan 2021 18:05:57 -0800 (PST) X-Google-Smtp-Source: ABdhPJx0rh05cleUdhdVE/lzCeEVhbL57D3XYoCZ0M98ahLUd0dImpwm+rdxm8qb5ao55yu4w87J X-Received: by 2002:a17:906:565a:: with SMTP id v26mr3714973ejr.332.1610589957335; Wed, 13 Jan 2021 18:05:57 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1610589957; cv=none; d=google.com; s=arc-20160816; b=SvZh2s8dojQuxNKuWaHY833B/9vKn1dFdk85fPJ5zwwYOST5y7Sk9Y52uD9g3zf7gw irBXvON/EQjsvNxjgSChL8rOXnv7+sEy58VtH3jlRxfZCySuETLBxrsCbqDtySZv5bQv OYdBR+JAmEbfHJiNDT8MnOPA365tfgHninnNIy0ZX+Tf/GglN9zdzAktqXqX89aGr22u TINZG3Y0CJWSCh716NXeDbBw/rfEp5mS1Q2HVHrBMOC7NCcegrKGmX5W2AuvgQuYO9Pg AsruqckrMzbg0Gzv7CWvbCTxu/1l1YOcXWpaAAY8DZ00r2gJIHqARcqOjVYDteTrxtjL ElOg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:cc:to:from:subject:references:mime-version :message-id:in-reply-to:date:sender:dkim-signature; bh=2NIQ1TwrG95rTm/28dxUdJZ491lS6fXAiyg3+rtP0i0=; b=MElIPx04xWWul9zz3gHYeVlkTk34IDq5CyPAflNrxPnwkVukndhXKBuhJU0n58BXvH P7M58x+r6D8/E2dd/xDAiu/OpYjNmcYfHNgJM6DmcyhR2g6lSLLjctk0195ZxEu8Le8h ZtR0nlp+8lsJyJdPIzgdJF2eNPm+IaWHnF7uEMEAsiJ1/G5frAHDbc4uW75MfSWc43lr hOeKe9oq6SL6V1/Vgc4WnkfuqD/Qs/yRDC6klZ1sPjKIbc/bXX06pkcjS9inDBjPQS6V 4u6a4pXHGMRwd6ozqMJ7K/9olI+PuHemck5L/9sof+8K/JAQ6L2Il3mhkOy0PzHK8HYg ldiw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@google.com header.s=20161025 header.b=KylcDwdW; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=google.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id g16si1850615edq.329.2021.01.13.18.05.22; Wed, 13 Jan 2021 18:05:57 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@google.com header.s=20161025 header.b=KylcDwdW; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=google.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729428AbhANCEV (ORCPT + 99 others); Wed, 13 Jan 2021 21:04:21 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57794 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729386AbhAMWg7 (ORCPT ); Wed, 13 Jan 2021 17:36:59 -0500 Received: from mail-qv1-xf4a.google.com (mail-qv1-xf4a.google.com [IPv6:2607:f8b0:4864:20::f4a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5C471C061795 for ; Wed, 13 Jan 2021 14:36:19 -0800 (PST) Received: by mail-qv1-xf4a.google.com with SMTP id m8so2822425qvt.14 for ; Wed, 13 Jan 2021 14:36:19 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=sender:date:in-reply-to:message-id:mime-version:references:subject :from:to:cc; bh=2NIQ1TwrG95rTm/28dxUdJZ491lS6fXAiyg3+rtP0i0=; b=KylcDwdWWUEUTJhqVOxgSNBrPPoATDupoPunfBGtoclQ6YJ4OUgN6vSg4nbTgkHjZB MnIKPul4jtH9KszyatKBON5g3l6fx82uawDDUKE1k+0Vu4KhSkFw8ai4wgidpEgOGc7H KM+0G4gGx+b4RhVBz68OHNF9VU5PYYC0Zc0is8X5Wy/MQWODETLb/SjVGCRq92M+Qjw7 q7U1IRaYxzFLCApilQZLvGNLh/zlkd56fEXHGTIP8ZceEEGholW/PLgPpj73oYEccQfo 5y0t7IKwzrsUrRwQmdDLXCK9MYhJRYDrmQMAP4Kd6Iqrf+ufgblHGMqlPlvu3KU7DD1h omvw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:date:in-reply-to:message-id:mime-version :references:subject:from:to:cc; bh=2NIQ1TwrG95rTm/28dxUdJZ491lS6fXAiyg3+rtP0i0=; b=FrAGyjK6Bq5RvCWbPo2LU2gw9JFwT4018f0kMNhlWtODbRpWHetY+lcKhLTGbowigl dRupPcx+c2ZVarUYrEgUrIRy4qDQByErsngrvhhWp2ifUHYnj/6yBwGxtrl+eCLV+TBT UBEzWq8jSax/tLHGwqfVO8UFp+slKRuN3YBgNaYAy5ucTDu2HXTd9BMFqrnjiQE3fedz M1vQHmORaWrjwEmpgwY5vMP9IDfq3jmQmdf6rSVlnabWBqgNwIIL588PTz1lfLyyngSi 3H1VJr39FZVA1S/NdblC0BkG7L4kmrDUK7cXjLqPTB945RcmTOHWnkuwcLhjQImmAVjl /iWQ== X-Gm-Message-State: AOAM533vRD2oQWrdcidcVEoASq/MzKXaCUxMSwzgu/PK+YnD7HnKrGdL tBkjIx3dRz84lZDPkji2et87cXcuiCTw Sender: "irogers via sendgmr" X-Received: from irogers.svl.corp.google.com ([2620:15c:2cd:2:f693:9fff:fef4:4583]) (user=irogers job=sendgmr) by 2002:a05:6214:80d:: with SMTP id df13mr4757822qvb.10.1610577378483; Wed, 13 Jan 2021 14:36:18 -0800 (PST) Date: Wed, 13 Jan 2021 14:36:09 -0800 In-Reply-To: <20210113223609.3358812-1-irogers@google.com> Message-Id: <20210113223609.3358812-2-irogers@google.com> Mime-Version: 1.0 References: <20210113223609.3358812-1-irogers@google.com> X-Mailer: git-send-email 2.30.0.284.gd98b1dd5eaa7-goog Subject: [PATCH 2/2] tools/bpftool: Add -Wall when building BPF programs From: Ian Rogers To: Alexei Starovoitov , Daniel Borkmann , Martin KaFai Lau , Song Liu , Yonghong Song , Andrii Nakryiko , John Fastabend , KP Singh , Quentin Monnet , Jean-Philippe Brucker , Tobias Klauser , Ilya Leoshkevich , netdev@vger.kernel.org, bpf@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Ian Rogers Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org No additional warnings are generated by enabling this, but having it enabled will help avoid regressions. Signed-off-by: Ian Rogers --- tools/bpf/bpftool/Makefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/bpf/bpftool/Makefile b/tools/bpf/bpftool/Makefile index f897cb5fb12d..45ac2f9e0aa9 100644 --- a/tools/bpf/bpftool/Makefile +++ b/tools/bpf/bpftool/Makefile @@ -166,7 +166,7 @@ $(OUTPUT)%.bpf.o: skeleton/%.bpf.c $(OUTPUT)vmlinux.h $(LIBBPF) -I$(srctree)/tools/include/uapi/ \ -I$(LIBBPF_PATH) \ -I$(srctree)/tools/lib \ - -g -O2 -target bpf -c $< -o $@ && $(LLVM_STRIP) -g $@ + -g -O2 -Wall -target bpf -c $< -o $@ && $(LLVM_STRIP) -g $@ $(OUTPUT)%.skel.h: $(OUTPUT)%.bpf.o $(BPFTOOL_BOOTSTRAP) $(QUIET_GEN)$(BPFTOOL_BOOTSTRAP) gen skeleton $< > $@ -- 2.30.0.284.gd98b1dd5eaa7-goog