Received: by 2002:a05:6a10:2785:0:0:0:0 with SMTP id ia5csp849512pxb; Wed, 13 Jan 2021 18:15:42 -0800 (PST) X-Google-Smtp-Source: ABdhPJwuBHlYraLmzVVpyV+Nz2fWqYPexF54sXUGGGjhX3f/+v/u8zowsP9I/nJRlJ9PWnf8Vby7 X-Received: by 2002:a17:906:4443:: with SMTP id i3mr3461968ejp.133.1610590542616; Wed, 13 Jan 2021 18:15:42 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1610590542; cv=none; d=google.com; s=arc-20160816; b=cxWxNfCh/aQNK/KbxtL6sPrZxDEuPL4WBxXPMYAtuaHny+M5HvIS8fJX7R9kYoPriF kjgVaWXAQirx6GFrl41XanL0aDtTyntcOKN0GDyrx266dSN1wIXiTUelbE+815JjRGVc 7gQgdlzl/W5YMZoIHZUlEl9arzAvVrz/j/JMVE9AaKh3cU8R3+aQOnSALzrS4cLTffxu REXszA42xL7UcTPp8TqoVTn/HJs/UbM8WXvvZcre1pnXaLsjWTd32cVj/61bg1Jy7hCR D6q7Xi62vWUUQYRZtR9i6SWSiN8eApPGGe6eNu9SOpWVVzmGcWCKKy2slmNMmmk4Gaqj dZ7w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from; bh=KqM4D5YPKlHuw2KDt4chHx+OsFGA4bCULvbeSwSRKQQ=; b=kFEHX6skZGByI1Yqd10cMOhTbVa/S3qa46teBnQaGmnw1b9aVCZOUb0qGlnhYcbzew M6UtqBrX1QZMgWIXqejlSDDHtH6nw9jxho+iz5J58rmmy1ZzsTeFKhgfVd31TtTadTqj DjjCmW/qRd+Jk69LiePouscrE9NT8fqBct6U18LixKiPIaXpXP2OqAW+VCa2e9IcmY6k AvBtC/9qlDtcedb2OhTDFmVOo5fET4E09oBpjLh5+UAtSwI2X9lHCnyD2uHhPK1PFGNJ F7iy6AizW1sp8QSYDlVUda++5s4DUoK/ksZEb+0Jti+NHrX/TH+AaUZCo9Dba6Sae1nG j/Yw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=collabora.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id e17si1757565edr.527.2021.01.13.18.15.19; Wed, 13 Jan 2021 18:15:42 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=collabora.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726929AbhANCOP (ORCPT + 99 others); Wed, 13 Jan 2021 21:14:15 -0500 Received: from bhuna.collabora.co.uk ([46.235.227.227]:38644 "EHLO bhuna.collabora.co.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729113AbhAMVbB (ORCPT ); Wed, 13 Jan 2021 16:31:01 -0500 Received: from [127.0.0.1] (localhost [127.0.0.1]) (Authenticated sender: eballetbo) with ESMTPSA id 9F71B1F45140 From: Enric Balletbo i Serra To: linux-kernel@vger.kernel.org Cc: Collabora Kernel ML , matthias.bgg@gmail.com, drinkcat@chromium.org, hsinyi@chromium.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org Subject: [PATCH] soc: mediatek: pm-domains: Don't print an error if child domain is deferred Date: Wed, 13 Jan 2021 22:30:12 +0100 Message-Id: <20210113213012.67643-1-enric.balletbo@collabora.com> X-Mailer: git-send-email 2.29.2 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Child domains can be deferred by the core because one of its resources is not available yet, in such case, it will print an error, but later it will succeed to probe. Fix that using the dev_err_probe() function so it only prints an error on a real error. Signed-off-by: Enric Balletbo i Serra --- drivers/soc/mediatek/mtk-pm-domains.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/soc/mediatek/mtk-pm-domains.c b/drivers/soc/mediatek/mtk-pm-domains.c index ae255aa7b1a9..8055fb019ba6 100644 --- a/drivers/soc/mediatek/mtk-pm-domains.c +++ b/drivers/soc/mediatek/mtk-pm-domains.c @@ -480,8 +480,8 @@ static int scpsys_add_subdomain(struct scpsys *scpsys, struct device_node *paren child_pd = scpsys_add_one_domain(scpsys, child); if (IS_ERR(child_pd)) { - ret = PTR_ERR(child_pd); - dev_err(scpsys->dev, "%pOF: failed to get child domain id\n", child); + dev_err_probe(scpsys->dev, PTR_ERR(child_pd), + "%pOF: failed to get child domain id\n", child); goto err_put_node; } -- 2.29.2