Received: by 2002:a05:6a10:2785:0:0:0:0 with SMTP id ia5csp850421pxb; Wed, 13 Jan 2021 18:17:19 -0800 (PST) X-Google-Smtp-Source: ABdhPJxLiB7dJrgYAC3jnH/JCKvlO5OwTi7O4jwv+QYB2EJgohZ5B9ofTRI1im/l3rz8fPU8eAV6 X-Received: by 2002:a17:906:6a8a:: with SMTP id p10mr3506645ejr.169.1610590638891; Wed, 13 Jan 2021 18:17:18 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1610590638; cv=none; d=google.com; s=arc-20160816; b=zT6e32ZZdDQfuHPSR3YQTLtM9cdWIiK16/B+idautxX+Wg4td5d5XEftDydF/eHIZd CdjuNGfk+eIOj58LiIMd/xR/OLN43l+EvvvSROAqIyCUJicv9gQeM6vrUL4oCLUPF8vN pPkJGfdymLiTc5mdQl2mO4zspYfwbniFZqBP6x6zZz/1zk4MwUL7Po59rxM/m0Ss/Ia8 u+kQ5pfTW1xCWdmKJhwuDVf0GaUw/Xy1Rix8I4PUua3cbwQpLD8LNyHZhdmgTmz5w6ON IJhpT5qU7eKcs7fJF3XKwrkZS0NjoKmevA78Ak45wPTta8xKYGD5qMekkG3AH3fQWYo0 qzMg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=d2ttguzfCnG+untbMAF3ReX1b0GvXmGr3xjG3ae0DH8=; b=Ju39aU6HgKkwQytsnHRX5aQc/CI+J2k7IDtspT1JLvalWTAaqZHz3fe6n0+gmUll1q J9r7MM+1DphIAXdgu2Cnc4TFae6Hj02SKSy3D9i/jyhjSsT519mOmE+drwmbXObprnBi XQa6aqChdTMDyIZOJ+UFMN5KGuv4vM7PSYKNOZ1PbHVJdM8+6007FGT5jV62828MN0Xo VTNgUuyE3+VdVt0g4qDT+ZMroZuKvnsuI0nOx8iSqCtkCUm0q+56LCfKdGXzgwRFbsMD V+c2hNpmHpeZwLRYdeLKc9eubA1GY1dOTl+PolaqkTE8zgA+XhmSbcXcW1uaw8/JDJ36 ZkIg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=EUon2zet; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id o2si1678382ejc.660.2021.01.13.18.16.55; Wed, 13 Jan 2021 18:17:18 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=EUon2zet; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728281AbhANCOj (ORCPT + 99 others); Wed, 13 Jan 2021 21:14:39 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42644 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729119AbhAMV1T (ORCPT ); Wed, 13 Jan 2021 16:27:19 -0500 Received: from mail-wm1-x331.google.com (mail-wm1-x331.google.com [IPv6:2a00:1450:4864:20::331]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8B2EFC061575; Wed, 13 Jan 2021 13:25:52 -0800 (PST) Received: by mail-wm1-x331.google.com with SMTP id y23so2928539wmi.1; Wed, 13 Jan 2021 13:25:52 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=d2ttguzfCnG+untbMAF3ReX1b0GvXmGr3xjG3ae0DH8=; b=EUon2zetws+KLoUAtv+UCUYASs/kjfnGSqsU/cXxtAXwrEkLIhFtYelWrDTx9Ss7HF nE9qWCyKVLMmarKu6JJCkho+a8YrZDHc6g6l+WigbLNcEVo1XycyM59IW+w+ZoOc8FFz 16XISwxMIECxYCxGmKv0EKGObKmlk7+gEVrKR55VXm9DFD8KsjnLo9dbVqiojF2OQ6gk 6z8xMaNuWfXjf85dz01VlKaV7TSsRRJVqZYcNHa/3BpvEZFJdnS+yb0Y4Tn7r4R4HYdI UPI6jMYsSOVoQ95rUN76LCC1tQjU0McSkfbGTj11PbKXudvQ5kLgzGl+MZsmNG5nDOme Sifg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=d2ttguzfCnG+untbMAF3ReX1b0GvXmGr3xjG3ae0DH8=; b=A9E6lC0sjO+1KdONpmK6vQdoCOatcQZ4cvTJpcg4bA52aFTmHLodvHDYrQ10ouFkZ6 WwPbNeqpT8WVmKUsmTCuJEOx9fzDsi2AR8N7CjPZ+Lvf6cZBsWoei8Qpj1QSlkQAt/dN DNNqCJ3owkfcNA+OkzJ3JRBI5NNN5+yP7+LSrB76iaSEULmxuIYh7AyjhyGfZECnYSoI 8VfD9XILTo1N9mjyRoWsa4Ayp7/Mah6jAMH9d5vAPq/Xfjxd5V8JQNamviiuGPh1jYsm QrTYqpGp9KgJ56bzLSDzhf/rIAejB6eCrYwOKNk4kflLpnfba8AW0rjKUsk7CUslbZpP wEVg== X-Gm-Message-State: AOAM530sEEVNItK8K73SUlDdn9jvjr1/HW29STfr08tICp/ItwO/O1wS ae7RqyB1d89y9TBSXc8AmS9Az83H5fWi X-Received: by 2002:a1c:9acb:: with SMTP id c194mr987942wme.43.1610573151384; Wed, 13 Jan 2021 13:25:51 -0800 (PST) Received: from localhost.localdomain ([46.53.249.51]) by smtp.gmail.com with ESMTPSA id j13sm4476553wmi.36.2021.01.13.13.25.49 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 13 Jan 2021 13:25:50 -0800 (PST) Date: Thu, 14 Jan 2021 00:25:47 +0300 From: Alexey Dobriyan To: Piotr Figiel Cc: "Eric W. Biederman" , Andrew Morton , Kees Cook , Alexey Gladkov , Christian Brauner , Michel Lespinasse , Bernd Edlinger , Andrei Vagin , mathieu.desnoyers@efficios.com, linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, posk@google.com, kyurtsever@google.com, ckennelly@google.com, pjt@google.com Subject: Re: [PATCH] fs/proc: Expose RSEQ configuration Message-ID: <20210113212547.GA487841@localhost.localdomain> References: <20210113174127.2500051-1-figiel@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20210113174127.2500051-1-figiel@google.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Jan 13, 2021 at 06:41:27PM +0100, Piotr Figiel wrote: > +static int proc_pid_rseq(struct seq_file *m, struct pid_namespace *ns, > + struct pid *pid, struct task_struct *task) > +{ > + int res = lock_trace(task); > + > + if (res) > + return res; > + seq_printf(m, "0x%llx 0x%x\n", (uint64_t)task->rseq, task->rseq_sig); may I suggest "%tx", (uintptr_t) // or %lx Mandatory 64-bit is too much on 32-bit. Or even "%tx %08x" ?