Received: by 2002:a05:6a10:2785:0:0:0:0 with SMTP id ia5csp908112pxb; Wed, 13 Jan 2021 20:17:08 -0800 (PST) X-Google-Smtp-Source: ABdhPJzMnynSrtvul0lVB2a1ZFXzFWZi0xDBNAmIVWIbmcvV8JDpNhz06NAxCWMSoqg3zjf853wD X-Received: by 2002:a17:906:4809:: with SMTP id w9mr3868809ejq.139.1610597827984; Wed, 13 Jan 2021 20:17:07 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1610597827; cv=none; d=google.com; s=arc-20160816; b=Z5Yl0KaV0WVlDwT0YudZ6JSXFx60EP2d2f1RHMYqq/phgVVK7yoDkO2oX0HgTU0W2P ylOYcAG/af5Zvucu37vQBoZnDWT8aNFTP1CvtbnVTVIkke5TgIdVJviDkENHQi5Bbl5A ElCd5oZIk5l+/EQuNczQGebWbCczHAgV+oM5ShRL/9vbEg/RqH65sX9Cfp6NxTF2SBrw nA0YSyKbEp0uvbAJ7nNig6aL7+sadcyOJ1yrUBzlpYgb10PAeKRFBmB9cvzkhrMvQy4x THTDw9VyYCr7+vOV5DZyERCM7X9iHnrtEqQ/9Ip0qFo03b7WiLmzBUumlUMFIPMzJko3 MO2g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:message-id:date:subject:cc:to:from :dkim-signature; bh=i/xZY8DpdABEtyxGJwRPJ3Gox+RIWU/dLajPoWgwjqs=; b=DQY6HU34ySiys+zApE0Ml8MUFkAesJzZGdFgIA7TrepKLFLfqGk2gIZ+/TsMXaj6d9 lGFyb65zwBNHvkqUp+KMGMlc6e6rktqDNpkCzCLJrd12r/fH+7I/hIQN5CX2DIQiFssQ r+UkRnmzfI7swbAI1QZGSvvBAKoOP7U6GSVtaTHR/daR7Ea5d72wPCW3hbnjYpKcAgFS I/LD2T0K0b1f4ezCNJPizkfXkg442Xl+/SMH3If0SQmRua3kx3NQEfl9U65i5pbo3sk8 SATgvUpHiDz7/kr9XXcn6Eyb8fs5nnQAizomwHYt+4EhRV3fM2QwVdzQk+tqKI1tYctJ xmmQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=Fv5i6Gtp; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id dd19si1896859edb.502.2021.01.13.20.16.44; Wed, 13 Jan 2021 20:17:07 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=Fv5i6Gtp; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726640AbhANEPx (ORCPT + 99 others); Wed, 13 Jan 2021 23:15:53 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46014 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725997AbhANEPx (ORCPT ); Wed, 13 Jan 2021 23:15:53 -0500 Received: from mail-pj1-x1034.google.com (mail-pj1-x1034.google.com [IPv6:2607:f8b0:4864:20::1034]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4D9CAC061575; Wed, 13 Jan 2021 20:15:07 -0800 (PST) Received: by mail-pj1-x1034.google.com with SMTP id cq1so2394174pjb.4; Wed, 13 Jan 2021 20:15:07 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id; bh=i/xZY8DpdABEtyxGJwRPJ3Gox+RIWU/dLajPoWgwjqs=; b=Fv5i6Gtp40PbeMJwpKIdACaEM36r4nswQT66xInERfTRx/Dps1FhpiZpPvE3V6CIMH lFRIuuFABGaFGdPLEe6hBwyvqU8hDz2GeAS/mOy7IEd7qoWbBVgNaeQ15tFBeBg87FD+ Zjx/wdrmdj/0C83Sq0hY1wTp4mkUEdYw0YP2zlH8uam/k1bZOY0R1baDt5wS8/DLtMQO cJDJ4iX7TJS0Ly4rLYt6xqovTsBnVfd/3BtmRDT6KqQpR26BjMYrm89l0tzYm6kSadu8 yuTKQLwQF4cOIWKPozw2hdlr7SnmkMVgdTLfe/m59IWDRJuCyTT62QidyeIbvzH4fMYY aWeA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=i/xZY8DpdABEtyxGJwRPJ3Gox+RIWU/dLajPoWgwjqs=; b=uHcVjdCDZyBUqNjWNqzM6w9MJbOEJxo2c1+ue3ndaPnUf3a2wPbLTYxLRv8qyZpop4 hyJVexbgb1TyDyMs4IPjnnDlXSiSYShrDXdlbm/Tg+Aw1mRLSiF07oZ4u5wYLDa3mVnv 4V7+GjU2ndTT8EUl10AcwLJQsEAedubNDhmw3bgnjoKauy6hbfQzszP7ZHKrzSrhkTwu hv9REQw9A4GZvYDQIEjEfIDmd2WS6QA5uPITHOTcLHYpW3brcUb1iTQWuIS2e5ynQzbn oON6yhBsrcqyFnFBlR8da/kFTZTGgIjmbi6jbx0JHZVUuMbk0/y1dlzTCRnfpFSs73X2 kZ0w== X-Gm-Message-State: AOAM531U7MlwfwL/F0XLOirHMDecobikzSl2j5leCApuh6G16XZMeuKe UHGGeL+P4axcTYgNvyw7ztA= X-Received: by 2002:a17:90a:2f22:: with SMTP id s31mr2948608pjd.192.1610597706920; Wed, 13 Jan 2021 20:15:06 -0800 (PST) Received: from localhost.localdomain ([122.10.161.207]) by smtp.gmail.com with ESMTPSA id l7sm4033523pjy.29.2021.01.13.20.15.04 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Wed, 13 Jan 2021 20:15:06 -0800 (PST) From: Yejune Deng To: edumazet@google.com, davem@davemloft.net, kuznet@ms2.inr.ac.ru, yoshfuji@linux-ipv6.org, kuba@kernel.org Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, yejune.deng@gmail.com Subject: [PATCH] tcp_cubic: use memset and offsetof init Date: Thu, 14 Jan 2021 12:14:56 +0800 Message-Id: <1610597696-128610-1-git-send-email-yejune.deng@gmail.com> X-Mailer: git-send-email 1.9.1 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org In bictcp_reset(), use memset and offsetof instead of = 0. Signed-off-by: Yejune Deng --- net/ipv4/tcp_cubic.c | 11 +---------- 1 file changed, 1 insertion(+), 10 deletions(-) diff --git a/net/ipv4/tcp_cubic.c b/net/ipv4/tcp_cubic.c index c7bf5b2..ffcbe46 100644 --- a/net/ipv4/tcp_cubic.c +++ b/net/ipv4/tcp_cubic.c @@ -104,16 +104,7 @@ struct bictcp { static inline void bictcp_reset(struct bictcp *ca) { - ca->cnt = 0; - ca->last_max_cwnd = 0; - ca->last_cwnd = 0; - ca->last_time = 0; - ca->bic_origin_point = 0; - ca->bic_K = 0; - ca->delay_min = 0; - ca->epoch_start = 0; - ca->ack_cnt = 0; - ca->tcp_cwnd = 0; + memset(ca, 0, offsetof(struct bictcp, unused)); ca->found = 0; } -- 1.9.1