Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <1610509395-107554-1-git-send-email-abaci-bugfix@linux.alibaba.com>
In-Reply-To: <1610509395-107554-1-git-send-email-abaci-bugfix@linux.alibaba.com>
From:   Baolin Wang <baolin.wang7@gmail.com>
Date:   Thu, 14 Jan 2021 12:53:47 +0800
Message-ID: <CADBw62qWmR9w+rXCjjO3_Yw9Hk_BoSFZhM7pbiRKp+bgnOfonA@mail.gmail.com>
Subject: Re: [PATCH v2] pinctrl: sprd: Simplify bool comparison
To:     Yang Li <abaci-bugfix@linux.alibaba.com>
Cc:     Orson Zhai <orsonzhai@gmail.com>,
        Linus Walleij <linus.walleij@linaro.org>,
        Chunyan Zhang <zhang.lyra@gmail.com>,
        linux-gpio@vger.kernel.org, LKML <linux-kernel@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Wed, Jan 13, 2021 at 11:43 AM Yang Li <abaci-bugfix@linux.alibaba.com> wrote:
>
> Fix the following coccicheck warning:
> ./drivers/pinctrl/sprd/pinctrl-sprd.c:690:8-23: WARNING: Comparison to
> bool
>
> Reported-by: Abaci Robot <abaci@linux.alibaba.com>
> Signed-off-by: Yang Li <abaci-bugfix@linux.alibaba.com>

You should keep other guy's reviewed-by or acked-by tag for the
following version if no other big changes. So again
Reviewed-by: Baolin Wang <baolin.wang7@gmail.com>

> ---
> Changes in v2:
>     - make "pinctrl: sprd:" as subject prefix
>
>  drivers/pinctrl/sprd/pinctrl-sprd.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/pinctrl/sprd/pinctrl-sprd.c b/drivers/pinctrl/sprd/pinctrl-sprd.c
> index 08dc193..dca7a50 100644
> --- a/drivers/pinctrl/sprd/pinctrl-sprd.c
> +++ b/drivers/pinctrl/sprd/pinctrl-sprd.c
> @@ -687,7 +687,7 @@ static int sprd_pinconf_set(struct pinctrl_dev *pctldev, unsigned int pin_id,
>                                 shift = INPUT_SCHMITT_SHIFT;
>                                 break;
>                         case PIN_CONFIG_BIAS_PULL_UP:
> -                               if (is_sleep_config == true) {
> +                               if (is_sleep_config) {
>                                         val |= SLEEP_PULL_UP;
>                                         mask = SLEEP_PULL_UP_MASK;
>                                         shift = SLEEP_PULL_UP_SHIFT;
> --
> 1.8.3.1
>


-- 
Baolin Wang