Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [PATCH] ata: remove redundant error print in
 rb532_pata_driver_probe
To:     Menglong Dong <menglong8.dong@gmail.com>, axboe@kernel.dk
Cc:     linux-ide@vger.kernel.org, LKML <linux-kernel@vger.kernel.org>,
        Menglong Dong <dong.menglong@zte.com.cn>
References: <20210112023619.5713-1-dong.menglong@zte.com.cn>
 <33bb1cd2-c202-0fd5-733d-b44e7e8fa92c@gmail.com>
 <CADxym3bzFPeCXzkO1iFy+Sx7GhwRGo=VkOUzrDE4KMCjMx0v-w@mail.gmail.com>
From:   Sergei Shtylyov <sergei.shtylyov@gmail.com>
Organization: Brain-dead Software
Message-ID: <2b6dcfbf-d534-4a2a-53e0-c942a9120a0f@gmail.com>
Date:   Thu, 14 Jan 2021 11:29:57 +0300
User-Agent: Mozilla/5.0 (Windows NT 6.3; Win64; x64; rv:78.0) Gecko/20100101
 Thunderbird/78.6.1
MIME-Version: 1.0
In-Reply-To: <CADxym3bzFPeCXzkO1iFy+Sx7GhwRGo=VkOUzrDE4KMCjMx0v-w@mail.gmail.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Precedence: bulk

Hello!

On 13.01.2021 17:04, Menglong Dong wrote:

[...]
>>>        irq = platform_get_irq(pdev, 0);
>>> -     if (irq <= 0) {
>>> -             dev_err(&pdev->dev, "no IRQ resource found\n");
>>> +     if (irq <= 0)
>>>                return -ENOENT;
>>
>>     This still beaks the probe deferral. :-(
>>     But that's another problem...
>>
>> [...]
>>
>> MBR, Sergei
> 
> What does this 'MBR' mean? I am a novice~~~

    Generally speaking, Master Boot Record. But I also use it to send you My 
Best Regards. :-)

> So, is it better to replace 'platform_get_irq' with
> 'platform_get_irq_optional' here?

    No. You should stop overriding the result to -ENOENT and pass the result
up the call chain instead. In order to do it, you should only check for (irq < 0).

> --
>   Best Regards
>   Menglong Dong

MBR, Sergei