Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Sender: kvalo=codeaurora.org@mg.codeaurora.org
DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org E11AFC433CA
From:   Kalle Valo <kvalo@codeaurora.org>
To:     Petr =?utf-8?Q?=C5=A0tetiar?= <ynezz@true.cz>
Cc:     Arnd Bergmann <arnd@kernel.org>, Felix Fietkau <nbd@nbd.name>,
        Lorenzo Bianconi <lorenzo.bianconi83@gmail.com>,
        Arnd Bergmann <arnd@arndb.de>,
        Ryder Lee <ryder.lee@mediatek.com>,
        "David S. Miller" <davem@davemloft.net>,
        Jakub Kicinski <kuba@kernel.org>,
        Matthias Brugger <matthias.bgg@gmail.com>,
        Shayne Chen <shayne.chen@mediatek.com>,
        Yiwei Chung <yiwei.chung@mediatek.com>,
        linux-wireless@vger.kernel.org, netdev@vger.kernel.org,
        linux-arm-kernel@lists.infradead.org,
        linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] mt76: mt7915: fix misplaced #ifdef
References: <20210103135811.3749775-1-arnd@kernel.org>
        <20210106135801.GA27377@meh.true.cz>
Date:   Thu, 14 Jan 2021 12:44:31 +0200
In-Reply-To: <20210106135801.GA27377@meh.true.cz> ("Petr \=\?utf-8\?Q\?\=C5\=A0t\?\=
 \=\?utf-8\?Q\?etiar\=22's\?\= message of
        "Wed, 6 Jan 2021 14:58:01 +0100")
Message-ID: <87r1mnhk6o.fsf@codeaurora.org>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.5 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

Petr =C5=A0tetiar <ynezz@true.cz> writes:

> Arnd Bergmann <arnd@kernel.org> [2021-01-03 14:57:55]:
>
> Hi,
>
> just a small nitpick,
>
>> From: Arnd Bergmann <arnd@arndb.de>
>>=20
>> The lone '|' at the end of a line causes a build failure:
>>=20
>> drivers/net/wireless/mediatek/mt76/mt7915/init.c:47:2: error:
>> expected expression before '}' token
>>=20
>> Replace the #ifdef with an equivalent IS_ENABLED() check.
>>=20
>> Fixes: af901eb4ab80 ("mt76: mt7915: get rid of dbdc debugfs knob")
>
> I think, that the correct fixes tag is following:
>
>  Fixes: 8aa2c6f4714e ("mt76: mt7915: support 32 station interfaces")
>
> I've used the af901eb4ab80 as well first in
> https://github.com/openwrt/mt76/pull/490 but then looked at it once more =
and
> actually found the probably correct 8aa2c6f4714e.

Ok, I'll change that during commit.

Felix, I'm planning to apply this to wireless-drivers and assigned this
to me in patchwork.

--=20
https://patchwork.kernel.org/project/linux-wireless/list/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatc=
hes