Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S965252AbWILOdL (ORCPT ); Tue, 12 Sep 2006 10:33:11 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S965255AbWILOdL (ORCPT ); Tue, 12 Sep 2006 10:33:11 -0400 Received: from sj-iport-6.cisco.com ([171.71.176.117]:34171 "EHLO sj-iport-6.cisco.com") by vger.kernel.org with ESMTP id S965250AbWILOdJ (ORCPT ); Tue, 12 Sep 2006 10:33:09 -0400 To: Zang Roy-r61911 Cc: Andrew Morton , jgarzik , netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [patch 3/3] Add tsi108 On Chip Ethernet device driver support X-Message-Flag: Warning: May contain useful information References: <1157962200.10526.10.camel@localhost.localdomain> <1158051351.14448.97.camel@localhost.localdomain> From: Roland Dreier Date: Tue, 12 Sep 2006 07:33:07 -0700 In-Reply-To: <1158051351.14448.97.camel@localhost.localdomain> (Zang Roy-r's message of "12 Sep 2006 16:55:52 +0800") Message-ID: User-Agent: Gnus/5.1007 (Gnus v5.10.7) XEmacs/21.4.18 (linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-OriginalArrivalTime: 12 Sep 2006 14:33:08.0012 (UTC) FILETIME=[5D85FEC0:01C6D678] Authentication-Results: sj-dkim-4.cisco.com; header.From=rdreier@cisco.com; dkim=pass ( sig from cisco.com verified; ); Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 717 Lines: 18 > +struct tsi108_prv_data { > + volatile u32 regs; /* Base of normal regs */ > + volatile u32 phyregs; /* Base of register bank used for PHY access */ Why volatile? This looks really wrong here. > + data->regs = (u32)ioremap(einfo->regs, 0x400); /*FIX ME */ > + data->phyregs = (u32)ioremap(einfo->phyregs, 0x400); /*FIX ME */ What needs to be fixed here? And why are you casting the result of ioremap to u32? Shouldn't you keep the normal return value? - R. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/