Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
To:     Viresh Kumar <viresh.kumar@linaro.org>,
        Linus Torvalds <torvalds@linux-foundation.org>,
        Robert Richter <rric@kernel.org>
Cc:     Vincent Guittot <vincent.guittot@linaro.org>,
        Arnd Bergmann <arnd@kernel.org>, oprofile-list@lists.sf.net,
        William Cohen <wcohen@redhat.com>,
        Alexander Viro <viro@zeniv.linux.org.uk>,
        anmar.oueja@linaro.org, Christoph Hellwig <hch@infradead.org>,
        linux-kernel@vger.kernel.org
References: <cover.1610622251.git.viresh.kumar@linaro.org>
 <592887f3a5baf0d2b2919617757f1f629aa4030b.1610622251.git.viresh.kumar@linaro.org>
From:   Michal Simek <monstr@monstr.eu>
Subject: Re: [PATCH 07/18] arch: microblaze: Remove CONFIG_OPROFILE support
Message-ID: <4afa1d09-cdd4-44a1-2fa2-1f6ca5657ef6@monstr.eu>
Date:   Thu, 14 Jan 2021 13:12:17 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.6.1
MIME-Version: 1.0
In-Reply-To: <592887f3a5baf0d2b2919617757f1f629aa4030b.1610622251.git.viresh.kumar@linaro.org>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 8bit
Precedence: bulk


On 14. 01. 21 12:35, Viresh Kumar wrote:
> The "oprofile" user-space tools don't use the kernel OPROFILE support
> any more, and haven't in a long time. User-space has been converted to
> the perf interfaces.
> 
> Remove the old oprofile's architecture specific support.
> 
> Suggested-by: Christoph Hellwig <hch@infradead.org>
> Suggested-by: Linus Torvalds <torvalds@linux-foundation.org>
> Signed-off-by: Viresh Kumar <viresh.kumar@linaro.org>
> ---
>  arch/microblaze/Kconfig                       |  1 -
>  arch/microblaze/Makefile                      |  2 --
>  arch/microblaze/oprofile/Makefile             | 14 ------------
>  .../microblaze/oprofile/microblaze_oprofile.c | 22 -------------------
>  4 files changed, 39 deletions(-)
>  delete mode 100644 arch/microblaze/oprofile/Makefile
>  delete mode 100644 arch/microblaze/oprofile/microblaze_oprofile.c
> 
> diff --git a/arch/microblaze/Kconfig b/arch/microblaze/Kconfig
> index f82795592ce5..25a5a3fb14aa 100644
> --- a/arch/microblaze/Kconfig
> +++ b/arch/microblaze/Kconfig
> @@ -30,7 +30,6 @@ config MICROBLAZE
>  	select HAVE_FTRACE_MCOUNT_RECORD
>  	select HAVE_FUNCTION_GRAPH_TRACER
>  	select HAVE_FUNCTION_TRACER
> -	select HAVE_OPROFILE
>  	select HAVE_PCI
>  	select IRQ_DOMAIN
>  	select XILINX_INTC
> diff --git a/arch/microblaze/Makefile b/arch/microblaze/Makefile
> index bb980891816d..b41f323e1fde 100644
> --- a/arch/microblaze/Makefile
> +++ b/arch/microblaze/Makefile
> @@ -54,8 +54,6 @@ core-y += arch/microblaze/kernel/
>  core-y += arch/microblaze/mm/
>  core-$(CONFIG_PCI) += arch/microblaze/pci/
>  
> -drivers-$(CONFIG_OPROFILE) += arch/microblaze/oprofile/
> -
>  boot := arch/microblaze/boot
>  
>  # Are we making a simpleImage.<boardname> target? If so, crack out the boardname
> diff --git a/arch/microblaze/oprofile/Makefile b/arch/microblaze/oprofile/Makefile
> deleted file mode 100644
> index 107f2f55d995..000000000000
> --- a/arch/microblaze/oprofile/Makefile
> +++ /dev/null
> @@ -1,14 +0,0 @@
> -# SPDX-License-Identifier: GPL-2.0
> -#
> -# arch/microblaze/oprofile/Makefile
> -#
> -
> -obj-$(CONFIG_OPROFILE) += oprofile.o
> -
> -DRIVER_OBJS := $(addprefix ../../../drivers/oprofile/, \
> -		oprof.o cpu_buffer.o buffer_sync.o \
> -		event_buffer.o oprofile_files.o \
> -		oprofilefs.o oprofile_stats.o \
> -		timer_int.o )
> -
> -oprofile-y := $(DRIVER_OBJS) microblaze_oprofile.o
> diff --git a/arch/microblaze/oprofile/microblaze_oprofile.c b/arch/microblaze/oprofile/microblaze_oprofile.c
> deleted file mode 100644
> index def17e59888e..000000000000
> --- a/arch/microblaze/oprofile/microblaze_oprofile.c
> +++ /dev/null
> @@ -1,22 +0,0 @@
> -/*
> - * Microblaze oprofile code
> - *
> - * Copyright (C) 2009 Michal Simek <monstr@monstr.eu>
> - * Copyright (C) 2009 PetaLogix
> - *
> - * This file is subject to the terms and conditions of the GNU General Public
> - * License. See the file "COPYING" in the main directory of this archive
> - * for more details.
> - */
> -
> -#include <linux/oprofile.h>
> -#include <linux/init.h>
> -
> -int __init oprofile_arch_init(struct oprofile_operations *ops)
> -{
> -	return -1;
> -}
> -
> -void oprofile_arch_exit(void)
> -{
> -}
> 

Acked-by: Michal Simek <michal.simek@xilinx.com>

Thanks,
Michal

-- 
Michal Simek, Ing. (M.Eng), OpenPGP -> KeyID: FE3D1F91
w: www.monstr.eu p: +42-0-721842854
Maintainer of Linux kernel - Xilinx Microblaze
Maintainer of Linux kernel - Xilinx Zynq ARM and ZynqMP ARM64 SoCs
U-Boot custodian - Xilinx Microblaze/Zynq/ZynqMP/Versal SoCs