Received: by 2002:a05:6a10:2785:0:0:0:0 with SMTP id ia5csp221762pxb; Thu, 14 Jan 2021 04:23:21 -0800 (PST) X-Google-Smtp-Source: ABdhPJy4HaX7PZvNskJQLbcsGRR8I//g11pvcxNY2ISVAUVn8PR9I7qx942OJEoVSmeiAYA8h4Gh X-Received: by 2002:a17:906:e84:: with SMTP id p4mr5219901ejf.141.1610627001163; Thu, 14 Jan 2021 04:23:21 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1610627001; cv=none; d=google.com; s=arc-20160816; b=PkJqScPYaGJgnHbdBpiCQI+hh5AqT2ZEcg8WWYvuar/Uvq9r81dx5yKRx83xvHm9WD zS6cQTcBcKW5ZV/jaUUPBoabcAsklAdfiByLg4mM58GfGF9mlktu0ctRmvpRKoonDQnk 4AYVZY30LZGZxNnyCph1xaR5XXuoxrzH3/e0c6Hscii8g8LYa31ldt+/6cyZtCtYr7A2 KDaJLumOC88ZZuHxwZ2Tza8AYH58R07RHvB4in2hph4QNFb208loP3/J8DwhswlBvmkR 8xFoRSmswBLRSKGbF2iTfJK+69Bi2XpzkiznI5gOaHodUBX1fdIa2C6+LM5mFIyJSd6y edzQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:mime-version:user-agent:references:message-id :in-reply-to:subject:cc:to:from:date:dkim-signature; bh=YoPpOyCNLGwrMbhdx768OaqvHvQ+RSQqc51xX0UX8Fk=; b=PJb73Q2SBtSamK9aA9e86mqBRL9nwQmsTWqVndchKQsSf0d9JRN0R7cn+dC8997KlH TNDbxRksfT1MBYFmV7OaXpiTGi76D9m9p/kyZcO3aAfpn6PLlokii44IdynuGOkfxHsW mPf7nsDtVvH2+ez2QKOzdek96sBzzWMl74zVaHlkLabSL9NctY33pvbOptZFxnKoo8ZM WIycRLBqrNE37IaBmdPREE0rmyIUUiU3XM6v+0IMoh4yCLReW/w6bzANPSIYW2IrV9P4 IOW1lGUyzX/3guqKSiW8sKi86PNTe0wNeQKfMFqsK9X1zTMuAgU1q+BkARIJqQFhh3N0 T3gQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=pT9I3JYb; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id ov28si2444158ejb.512.2021.01.14.04.22.55; Thu, 14 Jan 2021 04:23:21 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=pT9I3JYb; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726948AbhANMV5 (ORCPT + 99 others); Thu, 14 Jan 2021 07:21:57 -0500 Received: from mail.kernel.org ([198.145.29.99]:55408 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726329AbhANMV5 (ORCPT ); Thu, 14 Jan 2021 07:21:57 -0500 Received: by mail.kernel.org (Postfix) with ESMTPSA id 3368723A52; Thu, 14 Jan 2021 12:21:15 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1610626876; bh=N0Ht12IpJSy61TQAp8zxZTNjmqp8dhpvnST+AJm8Um0=; h=Date:From:To:cc:Subject:In-Reply-To:References:From; b=pT9I3JYbf/jZxbRev50e3QMgG134gSKbLhRCAFvRI7RzQ0lG66evQtpwLTWmr7OpO 9ySPbSxxU2zSpc/LE3TBV/QC20iq/FUqv409ydqf+9fRUgqEf6w3qc6KvbCFqNkfxN CIXsraf/p/STB9XMzzD1NXgAVH4JXrGBTGSF3A9zBOE3j2R6QGuO+SLvhMVQtdwHqv x3EYwtMX5KJyI51SLdQVXcLIUBuGXlj2CULJ1EhyPFwSWVT7WlbZbLkLVUOrSXAFZD LUapg062BeinK4HevI4OgsT/JJ4sEoy/FdlfYdX8U6B/cjcqTrC8O6WgPbjHL50bty zHMhiSb3mrTww== Date: Thu, 14 Jan 2021 13:21:13 +0100 (CET) From: Jiri Kosina To: Peilin Ye cc: Benjamin Tissoires , Phong Tran , Jason Gerecke , linux-input@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] HID: wacom: Fix memory leak in wacom_probe() In-Reply-To: <20201210112258.477636-1-yepeilin.cs@gmail.com> Message-ID: References: <20201210112258.477636-1-yepeilin.cs@gmail.com> User-Agent: Alpine 2.21 (LSU 202 2017-01-01) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 10 Dec 2020, Peilin Ye wrote: > wacom_probe() is leaking memory. Free `&wacom_wac->pen_fifo` when > hid_parse() or wacom_parse_and_register() fails. Thanks for the patch. It's however already been fixed in hid.git#for-5.11/upstream-fixes (37309f47e2f5) branch that will be going to Linus shortly. -- Jiri Kosina SUSE Labs