Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Thu, 14 Jan 2021 07:57:42 -0500
From:   Peilin Ye <yepeilin.cs@gmail.com>
To:     Jiri Kosina <jikos@kernel.org>
Cc:     Benjamin Tissoires <benjamin.tissoires@redhat.com>,
        Phong Tran <tranmanphong@gmail.com>,
        Jason Gerecke <killertofu@gmail.com>,
        linux-input@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] HID: wacom: Fix memory leak in wacom_probe()
Message-ID: <20210114125742.GA644967@PWN>
References: <20201210112258.477636-1-yepeilin.cs@gmail.com>
 <nycvar.YFH.7.76.2101141320210.13752@cbobk.fhfr.pm>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <nycvar.YFH.7.76.2101141320210.13752@cbobk.fhfr.pm>
Precedence: bulk

Hi Jiri,

On Thu, Jan 14, 2021 at 01:21:13PM +0100, Jiri Kosina wrote:
> > wacom_probe() is leaking memory. Free `&wacom_wac->pen_fifo` when
> > hid_parse() or wacom_parse_and_register() fails.
> 
> Thanks for the patch. It's however already been fixed in 
> hid.git#for-5.11/upstream-fixes (37309f47e2f5) branch that will be going 
> to Linus shortly.

Ah...  I checked linux-input@ before I started working on the bug, but
it seems that Ping sent out a patch just a few hours before I did.

Sorry for the race condition,
Peilin Ye