Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <1610612968-26612-1-git-send-email-wuht06@gmail.com>
 <1610612968-26612-3-git-send-email-wuht06@gmail.com> <20210114085233.GO4678@unreal>
 <CAG_R4_UJ0=8=31XZD-SiiuL91M02N+fn=CLNA4_5Xm7jRDE1Rg@mail.gmail.com> <20210114130624.GR4678@unreal>
In-Reply-To: <20210114130624.GR4678@unreal>
From:   Hongtao Wu <wuht06@gmail.com>
Date:   Thu, 14 Jan 2021 21:30:39 +0800
Message-ID: <CAG_R4_UdQay0xh11Snt7G+uS+1E7E0NQf1rE-JpA0fge9jeLRQ@mail.gmail.com>
Subject: Re: [RESEND PATCH v5 2/2] PCI: sprd: Add support for Unisoc SoCs'
 PCIe controller
To:     Leon Romanovsky <leon@kernel.org>
Cc:     Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>,
        Rob Herring <robh+dt@kernel.org>,
        Orson Zhai <orsonzhai@gmail.com>,
        Baolin Wang <baolin.wang7@gmail.com>,
        Chunyan Zhang <zhang.lyra@gmail.com>,
        linux-pci@vger.kernel.org, devicetree@vger.kernel.org,
        linux-kernel@vger.kernel.org, Hongtao Wu <billows.wu@unisoc.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

On Thu, Jan 14, 2021 at 9:06 PM Leon Romanovsky <leon@kernel.org> wrote:
>
> On Thu, Jan 14, 2021 at 08:00:50PM +0800, Hongtao Wu wrote:
> > On Thu, Jan 14, 2021 at 4:52 PM Leon Romanovsky <leon@kernel.org> wrote=
:
> > >
> > > On Thu, Jan 14, 2021 at 04:29:28PM +0800, Hongtao Wu wrote:
> > > > From: Hongtao Wu <billows.wu@unisoc.com>
> > > >
> > > > This series adds PCIe controller driver for Unisoc SoCs.
> > > > This controller is based on DesignWare PCIe IP.
> > > >
> > > > Signed-off-by: Hongtao Wu <billows.wu@unisoc.com>
> > > > ---
> > > >  drivers/pci/controller/dwc/Kconfig     |  12 ++
> > > >  drivers/pci/controller/dwc/Makefile    |   1 +
> > > >  drivers/pci/controller/dwc/pcie-sprd.c | 293 +++++++++++++++++++++=
++++++++++++
> > > >  3 files changed, 306 insertions(+)
> > > >  create mode 100644 drivers/pci/controller/dwc/pcie-sprd.c
> > >
> > > <...>
> > >
> > > > +static struct platform_driver sprd_pcie_driver =3D {
> > > > +     .probe =3D sprd_pcie_probe,
> > > > +     .remove =3D __exit_p(sprd_pcie_remove),
> > >                    ^^^^^^ why is that?
> > >
> >
> > Thanks for the review.
> >
> > I think that if 'MODULE' is defined, '.remove =3D sprd_pcie_remove',
> > else '.remove =3D NULL'.
> > I would appreciate hearing your opinion about this.
>
> If module not defined, these .probe and .remove won't be called.
>
> >
> > > > +     .driver =3D {
> > > > +             .name =3D "sprd-pcie",
> > > > +             .of_match_table =3D sprd_pcie_of_match,
> > > > +     },
> > > > +};
> > > > +
> > > > +module_platform_driver(sprd_pcie_driver);
> > > > +
> > > > +MODULE_DESCRIPTION("Unisoc PCIe host controller driver");
> > > > +MODULE_LICENSE("GPL v2");
> > >
> > > I think that it needs to be "GPL" and not "GPL v2".
> > >
> >
> > Many platform drivers use 'GPL v2', but others use 'GPL'.
> > I am not sure whether to use 'GPL' or 'GPL v2'.
> > Could you tell me why =E2=80=98GPL=E2=80=99 is needed here?
>
> Because GPL already means v2, see Documentation/process/license-rules.rst
>
>   447
>   448     "GPL v2"                      Same as "GPL". It exists for hist=
oric
>   449                                   reasons.
>

Thanks for the explanation!
I'll update =E2=80=9CGPL=E2=80=9D and ".remove" in the next version.

>
> >
> > > Thanks
> > >
> > > > --
> > > > 2.7.4
> > > >