Received: by 2002:a05:6a10:2785:0:0:0:0 with SMTP id ia5csp275959pxb; Thu, 14 Jan 2021 05:50:22 -0800 (PST) X-Google-Smtp-Source: ABdhPJzkbrjexQ8pfuMH2q+dBQgqLePswknm2nLV6+SI5O1sycMIbGctK0j8uo/INf5ZlzEvVAta X-Received: by 2002:a17:906:cd14:: with SMTP id oz20mr4879539ejb.99.1610632221872; Thu, 14 Jan 2021 05:50:21 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1610632221; cv=none; d=google.com; s=arc-20160816; b=qD+SJOoOBqBid6fb3NmGSoP6b/19qO2mX9yY4uZp74ov+WfLqlIbc0jGlioapKwSeD jvDVaBkTZXDj9pVOUaW02MMNNfmDcWdUmwzPGFyKuRZmRtzwTrtf2ZNu2rv7VaLk7S2Z j77ehcTFdvu31EwBAssU26rGj08krzqf1fAAk/2mYpoivj7gsJoiCoyclfNA6nk8oW1V nLOik0hRHt0Qyce1PJ9Uq6O8hhrkjEdUQ/h82yH9dMDHe5an+0DD5DX9HntUHUaJSuH/ Bx7HJeOTEIKYPrDIaHdT++iGM0443w8czXWA0egD+vG2SDV9Vu4LwA7tMR06SgqXzd0o A1+A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-transfer-encoding :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature; bh=TbqE2IlRGagFgBkQ2kCkUrfXzLCjHj/NgUbyVG+QOLU=; b=qaLwVWrrnHwosIj/EhkM6bqw2wEzOPW0XXj+K5xhmnorjK6lIreZWTwaaZoowdnJKZ z6NSKAKOFPrCnlyT2tdX8mW/VBRFHQAOQ8EP7ZCQLPTLZn+UkixLhfc/wcVKZM52EXa0 vg5e5ud1jB7wNUC9VMPAdPJdb0ozuRJPiKw5f2/jws7byJl+moxSotZwV9Cbcm54rl7f 22dMBBQPEtay0AgFL209AopAWZ/E6ZbjCw8EvCSLSvkpuPr7DboPJVFqfJnKf2KCLLx/ p95CnlJzR65Jwc/Q4hK7LooEJEaenwr1Im+0l23khumZUV0SwUyUNVr5ZcXVw3vyjna7 0hLA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=OwOxLsbo; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id g16si2583668edq.329.2021.01.14.05.49.33; Thu, 14 Jan 2021 05:50:21 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=OwOxLsbo; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727063AbhANNsh (ORCPT + 99 others); Thu, 14 Jan 2021 08:48:37 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56056 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725991AbhANNsh (ORCPT ); Thu, 14 Jan 2021 08:48:37 -0500 Received: from mail-wm1-x332.google.com (mail-wm1-x332.google.com [IPv6:2a00:1450:4864:20::332]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C44A7C0613CF for ; Thu, 14 Jan 2021 05:47:56 -0800 (PST) Received: by mail-wm1-x332.google.com with SMTP id r4so4726472wmh.5 for ; Thu, 14 Jan 2021 05:47:56 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to; bh=TbqE2IlRGagFgBkQ2kCkUrfXzLCjHj/NgUbyVG+QOLU=; b=OwOxLsbosDLvoLhRLZ8mzzei4v0t2XhAEbH8Iq2Sxm640+qWBEKYZm4cocQg4aGYiV Xffe/6oKYTXJTmiquE5GGTUFqyH4SWt1o3Mk/HO8mr1iB4/oJKfzT+653Fp1pZ6tPwzi S1stu6wWFThE8hKMRzYPWMNQPSVjWsmHzrcFSQebC+wFsDX7FJfNPmzHzMhUEvcJ4Cv+ by4PSWVqcLWwoS6qTTEpItMusrhWhM+A6A9T+EBRMyqDtNd1C3s6YY82pNWW5Yu/oudv zQUzIvGo47Uv1SukMAsYZkAvpT4tZhYQ7JGE+BCNysEIgarpETIZ2w3ApWtZcqTPbAU2 CxtA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=TbqE2IlRGagFgBkQ2kCkUrfXzLCjHj/NgUbyVG+QOLU=; b=dVL5OSQyY2snGloySF6BZlxgS68hYlnpljwPPN2Jle/d+ZVZaepn8h6E9uTaj7U8Mp 2Vwi4t+tXSLKq5zsUurKcZxjRCuRU7w9RULnX5vUV3IthVpyOqeVKZwyUBPYnAIS7pwd hDU1o79tnqFu8uUb8BW881nwwRNOcMsBw/PSuuwS8jSFzQqNANfm1UdxO9/jIILrXESX 6UNtPBlPNYb++Mf0ghfXoF6imHNuS7EvpUvwacuUeKSCy6hhsr/I+SsQIFn7qNihpUGk yAfKXcQiaYV8+iQ3QDvnH3IKu4JmfYo/w9eOVyoMRCuTs6saITWidjgGtcw7yyhgBY5z daUg== X-Gm-Message-State: AOAM531KATH8m8lmUHW/Ep8brQ9a4sABtk3aYDnua89jHn37SgvmDVeX vABwVzfyaWnTZox/OKMwvPfbfA== X-Received: by 2002:a1c:2905:: with SMTP id p5mr4021448wmp.156.1610632075437; Thu, 14 Jan 2021 05:47:55 -0800 (PST) Received: from dell ([91.110.221.178]) by smtp.gmail.com with ESMTPSA id n9sm9766176wrq.41.2021.01.14.05.47.54 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 14 Jan 2021 05:47:54 -0800 (PST) Date: Thu, 14 Jan 2021 13:47:53 +0000 From: Lee Jones To: Dmitry Osipenko Cc: Rob Herring , Thierry Reding , Jonathan Hunter , Dan Murphy , Sebastian Reichel , devicetree@vger.kernel.org, linux-tegra@vger.kernel.org, linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v8 2/3] mfd: Add driver for Embedded Controller found on Acer Iconia Tab A500 Message-ID: <20210114134753.GY3975472@dell> References: <20201228160547.30562-1-digetx@gmail.com> <20201228160547.30562-3-digetx@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20201228160547.30562-3-digetx@gmail.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 28 Dec 2020, Dmitry Osipenko wrote: > Acer Iconia Tab A500 is an Android tablet device, it has ENE KB930 > Embedded Controller which provides battery-gauge, LED, GPIO and some > other functions. The EC uses firmware that is specifically customized > for Acer A500. This patch adds MFD driver for the Embedded Controller > which allows to power-off / reboot the A500 device, it also provides > a common register read/write API that will be used by the sub-devices. > > Signed-off-by: Dmitry Osipenko > --- > drivers/mfd/Kconfig | 11 ++ > drivers/mfd/Makefile | 1 + > drivers/mfd/acer-ec-a500.c | 202 +++++++++++++++++++++++++++++++++++++ > 3 files changed, 214 insertions(+) > create mode 100644 drivers/mfd/acer-ec-a500.c Looks good to me: For my own reference (apply this as-is to your sign-off block): Acked-for-MFD-by: Lee Jones Do you have a merge plan? -- Lee Jones [李琼斯] Senior Technical Lead - Developer Services Linaro.org │ Open source software for Arm SoCs Follow Linaro: Facebook | Twitter | Blog