Received: by 2002:a05:6a10:2785:0:0:0:0 with SMTP id ia5csp298286pxb; Thu, 14 Jan 2021 06:20:41 -0800 (PST) X-Google-Smtp-Source: ABdhPJzo1IFV/MQ68ggGD5GXv/UbOKlgH4AC064gAWtN30EMH0ogesUXhXM3m6OdcNTqiFWfZcw1 X-Received: by 2002:a05:6402:2553:: with SMTP id l19mr5763879edb.326.1610634041639; Thu, 14 Jan 2021 06:20:41 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1610634041; cv=none; d=google.com; s=arc-20160816; b=h8ltMxtlcj0GbZBwqrgVZJlxV7/Qwg7gphT0YDnRb63Uw6VZFzKECdt0tnF36NiTp+ ZW3xv/F+LASg2c8QfYkFDGdc1l/lLPosv24+sO/Co9qej8doD7BcvfBhlTBZojTomrYM 83vUmHzIL+SWouiS/SA6q4HDRTx6NERwZM+HbusZqrUpIVKaEeNUO6Ib8TLHRZUI9PB0 GA+BdDggEvS95rxvMYCXqfBqatbtlmsxN7RqD8mHIRZ54xgwgQ4HrSE44iYyRStqJ1N2 3BHPHSo4yBRQ1N6RUog4SPvMaVOCXLXfYqjVyKFGv1GSNybtBw8YkmumdVxX0LOjU+IF AfMg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=fUbRy6sqMK/VtzYMVR0QbOcXZcr2khwVmqHoQSc9epc=; b=N1a2PpLhOpKBn2QdV5rqn0AHqUSaiaT3YMFc+86uKwvyr/W5rxRMNa8LNfJPc42E9D Rk6kHTBaq4gDs5M/WgI2j2Wv8EJfH54ux6S+g6TvtoNO60b2l9G9+xyaZ/1Q2P0xP5CY OgqfV9mMhMFHuntWHAOndolTGmc3qpVdXlgGOK2RPSGA+bhnkoVIzIOMtKRKSO5y1IZK BY8XXVxPA+MlE9yUSRYVVrDtR7UgMaEdvTClhP9eXRbF6MnDu24WFeySHIZEVj7Xdzlr k16T4HSrYJCS7T2LTugTgb5tX+u/O5/mbWR4i8MlCUocMT/uPnz/x3mC6PH9lQMxx47P 7agQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=pj7TNwsL; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id e22si2673572edv.437.2021.01.14.06.20.16; Thu, 14 Jan 2021 06:20:41 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=pj7TNwsL; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729184AbhANORu (ORCPT + 99 others); Thu, 14 Jan 2021 09:17:50 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34116 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726175AbhANORu (ORCPT ); Thu, 14 Jan 2021 09:17:50 -0500 Received: from mail-pf1-x42a.google.com (mail-pf1-x42a.google.com [IPv6:2607:f8b0:4864:20::42a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id EB7A0C061574 for ; Thu, 14 Jan 2021 06:17:09 -0800 (PST) Received: by mail-pf1-x42a.google.com with SMTP id a188so3406050pfa.11 for ; Thu, 14 Jan 2021 06:17:09 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=fUbRy6sqMK/VtzYMVR0QbOcXZcr2khwVmqHoQSc9epc=; b=pj7TNwsLApDeIa2eRKSYiIg1yfsyUXau7xgFABNNPyApe1n7KGm8mXeEsExpdZtwwW 9ETjKLVKXDhiyxQd+u0cv5eYujBhuaZyLsY67u0YsKwKim8MoJHagFJjdHm1yW+oSqVC Gm8kA/VE8Rq+S4yYFmOLHIX2yyXBv5a75Ss3RCLSOQqqwnNiLUNx/ThzD2SDFrym6Ceu g3prk77GeB3LNPZ2LSBeLI9yaJxIBnTJhXLf9oIaDP29gz+RYQZvtYHrCkNBMp3Jluix 0xXlOFKOFe2xw48bH6X3PVyUPRBeYi32+Pmg3UsEBpvQCFn9dlDUGBawpaodiRyU4Wt9 hWLg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=fUbRy6sqMK/VtzYMVR0QbOcXZcr2khwVmqHoQSc9epc=; b=GKyCgaZW8fXFLmsnx64vU/7fEWVdhxEmRehKSQggWpZvKSZoSxX1crrMC6Je7T3Ur9 bQfNqCxDjOjCdrsoocLw2R7YwVZF1qmyieIn51W34/LVkqhXfTgkNQ+ntQmnDpyERves cytfXV6g6ehMmCXcwya/fMs4Ij93EHulCsILlBieV8GySP8E+DpzJzZQRNd2wOMvkaxa be0YwPtUzf3Op1C8bBhmbWXnyYPmpky1VqI9FLFE3PZRBNnsnpAH97aA2cKwt7zHzGik 0XIUoKhgMewpsmzVEA8HPsi2x7D3za3FqHxUZKWdM6QN3cYnsG4sbl3gU0aAM6W+MLY0 q3tA== X-Gm-Message-State: AOAM5337K4mIJ/WMki/ZSvQTTaWNheRorxNv8vt860o6oVISBQfOBX/l 6RRiMHe440y8PvGeGfR5YLk5qcSBrBw= X-Received: by 2002:a63:ce58:: with SMTP id r24mr7798553pgi.192.1610633829410; Thu, 14 Jan 2021 06:17:09 -0800 (PST) Received: from localhost ([2401:fa00:8f:203:f580:e184:1fc4:9744]) by smtp.gmail.com with ESMTPSA id y5sm5952510pfp.45.2021.01.14.06.17.08 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 14 Jan 2021 06:17:08 -0800 (PST) Date: Thu, 14 Jan 2021 23:17:06 +0900 From: Sergey Senozhatsky To: John Ogness Cc: Petr Mladek , Sergey Senozhatsky , Sergey Senozhatsky , Steven Rostedt , linux-kernel@vger.kernel.org Subject: Re: [PATCH] printk: fix kmsg_dump_get_buffer length calulations Message-ID: References: <20210113164413.1599-1-john.ogness@linutronix.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210113164413.1599-1-john.ogness@linutronix.de> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On (21/01/13 17:50), John Ogness wrote: > > kmsg_dump_get_buffer() uses @syslog to determine if the syslog > prefix should be written to the buffer. However, when calculating > the maximum number of records that can fit into the buffer, it > always counts the bytes from the syslog prefix. > > Use @syslog when calculating the maximum number of records that can > fit into the buffer. > > Fixes: e2ae715d66bf ("kmsg - kmsg_dump() use iterator to receive log buffer content") > Signed-off-by: John Ogness Acked-by: Sergey Senozhatsky -ss