Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <20210112023619.5713-1-dong.menglong@zte.com.cn>
 <33bb1cd2-c202-0fd5-733d-b44e7e8fa92c@gmail.com> <CADxym3bzFPeCXzkO1iFy+Sx7GhwRGo=VkOUzrDE4KMCjMx0v-w@mail.gmail.com>
 <2b6dcfbf-d534-4a2a-53e0-c942a9120a0f@gmail.com>
In-Reply-To: <2b6dcfbf-d534-4a2a-53e0-c942a9120a0f@gmail.com>
From:   Menglong Dong <menglong8.dong@gmail.com>
Date:   Thu, 14 Jan 2021 22:53:46 +0800
Message-ID: <CADxym3Z088OCMpFvUMG8Ggx3yQXVL0N9=yJ4+CUgxgnTwkEysw@mail.gmail.com>
Subject: Re: [PATCH] ata: remove redundant error print in rb532_pata_driver_probe
To:     Sergei Shtylyov <sergei.shtylyov@gmail.com>
Cc:     axboe@kernel.dk, linux-ide@vger.kernel.org,
        LKML <linux-kernel@vger.kernel.org>,
        Menglong Dong <dong.menglong@zte.com.cn>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Thu, Jan 14, 2021 at 4:30 PM Sergei Shtylyov
<sergei.shtylyov@gmail.com> wrote:
[...]
> >
> > What does this 'MBR' mean? I am a novice~~~
>
>     Generally speaking, Master Boot Record. But I also use it to send you My
> Best Regards. :-)

Haha~,

> > So, is it better to replace 'platform_get_irq' with
> > 'platform_get_irq_optional' here?
>
>     No. You should stop overriding the result to -ENOENT and pass the result
> up the call chain instead. In order to do it, you should only check for (irq < 0).

Well, I didn't even notice this. It does seem to be another problem...

---
 Best Regards
 Menglong Dong