Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <be5cb12a68d9ac2c35ad9dd50d6b168f7cad6837.1609996381.git.viresh.kumar@linaro.org>
 <1e42183ccafa1afba33b3e79a4e3efd3329fd133.1610095159.git.viresh.kumar@linaro.org>
 <CAL_JsqLpbSOk-OST8Oi7uyFVjekX-15713F1FbDCQWfVWgikMw@mail.gmail.com> <20210114050309.wokrhw4o3cjxj5uo@vireshk-i7>
In-Reply-To: <20210114050309.wokrhw4o3cjxj5uo@vireshk-i7>
From:   Rob Herring <robh+dt@kernel.org>
Date:   Thu, 14 Jan 2021 09:01:31 -0600
Message-ID: <CAL_JsqJ=jxBo2JsjNTcBnV_8OrGjUc4ZQEpdVWsfFwWb9YzyFQ@mail.gmail.com>
Subject: Re: [PATCH] of: unittest: Statically apply overlays using fdtoverlay
To:     Viresh Kumar <viresh.kumar@linaro.org>
Cc:     Pantelis Antoniou <pantelis.antoniou@konsulko.com>,
        Frank Rowand <frowand.list@gmail.com>,
        devicetree@vger.kernel.org,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        Linux Kbuild mailing list <linux-kbuild@vger.kernel.org>,
        Vincent Guittot <vincent.guittot@linaro.org>,
        Bill Mills <bill.mills@linaro.org>,
        Anmar Oueja <anmar.oueja@linaro.org>,
        Masahiro Yamada <masahiroy@kernel.org>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Wed, Jan 13, 2021 at 11:03 PM Viresh Kumar <viresh.kumar@linaro.org> wrote:
>
> On 11-01-21, 09:46, Rob Herring wrote:
> > On Fri, Jan 8, 2021 at 2:41 AM Viresh Kumar <viresh.kumar@linaro.org> wrote:
> > >
> > > Now that fdtoverlay is part of the kernel build, start using it to test
> > > the unitest overlays we have by applying them statically.
> >
> > Nice idea.
> >
> > > The file overlay_base.dtb have symbols of its own and we need to apply
> > > overlay.dtb to overlay_base.dtb alone first to make it work, which gives
> > > us intermediate-overlay.dtb file.
> >
> > Okay? If restructuring things helps we should do that. Frank?
>
> Frank, do we want to do something about it ? Maybe make overlay_base.dts an dtsi
> and include it from testcases.dts like the other ones ?

No, because overlay_base.dts is an overlay dt. I think we need an
empty, minimal base.dtb to apply overlay_base.dtbo to.

And then fdtoverlay needs a fix to apply overlays to the root node?

Rob