Received: by 2002:a05:6a10:2785:0:0:0:0 with SMTP id ia5csp368128pxb; Thu, 14 Jan 2021 07:51:41 -0800 (PST) X-Google-Smtp-Source: ABdhPJzFZ+OtEuchzN6fvn3m3w9kFJYwBa4P7XszKLTMrQ7K4GqdL/ecNwO65y6E8GQQZqvrnQf0 X-Received: by 2002:a17:906:1302:: with SMTP id w2mr6068331ejb.413.1610639501364; Thu, 14 Jan 2021 07:51:41 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1610639501; cv=none; d=google.com; s=arc-20160816; b=q6uX0Wm7h18m1si4NUjPcdEKe01uH3XDGrvRrnlDRelOMz6lIsYtUzKKi9q9tWaVA4 xoJmjhvrvTZrWt00xHCf/4kEze4Giq+xRmGLik29N7blJAi02/0M3zSgOE2SBxlG9zQh VifvwsusEvpYs+MHOdUO6VQBmVlHSNyrBiGD5atJKNlCh09mSrau6Bz4Drf3R7j0yZ9f GuaO36XS9j2trcW6RhZkh0+3GbUm3OAIEQxfOZAf4HEipmB6poi64mSbjBE0IlakYTBX RJoRkF2Yuq4Fyzhrj7aHY1+kxMplW+Zwc60aLEUKF0pBjwWCd+rHYf0PBqvYL+weGZfJ nocA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from; bh=SNAxtAe1PZxq+QfDfcQYombp2lvRf6oyR9IJw8pHUMM=; b=Q9OAW+B1dDi+Dq7jgV/c9AJupwDK4k06FKKKrWya0U8nSXUFvgb7pyX+aZLag2dcUZ DJ1ie/3dUohZD4ygcQBOH8QC3/WeiODdDo4CkkDCtKIPnSl+A+EcgPe2GH/LcnQMkOSs FNFxXlaJ26/s+pmth/iTGPRn1QC/2bqek5GoK2vfD4lfCDBDOT8mAmwZHP0+gEi9qs6S /8Zqeke780pOpEyQKBTszNIBdZvHVop//KVoyTD5TmN9Nz1/cALHwi5wpcPisXcwxNIA EPynlwGv5cZrroAkgxby5216emj/PazJ2LUxQImUCYLm5G0VzoZaOWn/qYSi2oDhYtOc T/wA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id v21si2716275edy.237.2021.01.14.07.51.17; Thu, 14 Jan 2021 07:51:41 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729558AbhANPsp (ORCPT + 99 others); Thu, 14 Jan 2021 10:48:45 -0500 Received: from relay4-d.mail.gandi.net ([217.70.183.196]:48951 "EHLO relay4-d.mail.gandi.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729503AbhANPsp (ORCPT ); Thu, 14 Jan 2021 10:48:45 -0500 X-Originating-IP: 86.201.233.230 Received: from localhost.localdomain (lfbn-tou-1-151-230.w86-201.abo.wanadoo.fr [86.201.233.230]) (Authenticated sender: miquel.raynal@bootlin.com) by relay4-d.mail.gandi.net (Postfix) with ESMTPSA id 40F61E0018; Thu, 14 Jan 2021 15:47:59 +0000 (UTC) From: Miquel Raynal To: Martin Blumenstingl , vadivel.muruganx.ramuthevar@linux.intel.com, linux-mtd@lists.infradead.org, miquel.raynal@bootlin.com Cc: richard@nod.at, vigneshr@ti.com, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2] mtd: rawnand: intel: check the mtd name only after setting the variable Date: Thu, 14 Jan 2021 16:47:58 +0100 Message-Id: <20210114154758.32030-1-miquel.raynal@bootlin.com> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20210106140943.98072-1-martin.blumenstingl@googlemail.com> References: MIME-Version: 1.0 X-linux-mtd-patch-notification: thanks X-linux-mtd-patch-commit: 18f62614308be69a2752afb5f6bbad60096ad774 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 2021-01-06 at 14:09:43 UTC, Martin Blumenstingl wrote: > Move the check for mtd->name after the mtd variable has actually been > initialized. > > While here, also drop the NULL assignment to the mtd variable as it's > overwritten later on anyways and the NULL value is never read. > > Fixes: 0b1039f016e8a3 ("mtd: rawnand: Add NAND controller support on Intel LGM SoC") > Signed-off-by: Martin Blumenstingl Applied to https://git.kernel.org/pub/scm/linux/kernel/git/mtd/linux.git mtd/fixes, thanks. Miquel