Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <20210114152323.2382283-1-lee.jones@linaro.org> <20210114152323.2382283-5-lee.jones@linaro.org>
In-Reply-To: <20210114152323.2382283-5-lee.jones@linaro.org>
From:   Benjamin Tissoires <benjamin.tissoires@gmail.com>
Date:   Thu, 14 Jan 2021 17:04:32 +0100
Message-ID: <CAN+gG=HEVi+Hnpj2gywBPR3WCvLwed6CLV7cTFWTn+CZsqRP=A@mail.gmail.com>
Subject: Re: [PATCH 4/5] input: touchscreen: surface3_spi: Remove set but
 unused variable 'timestamp'
To:     Lee Jones <lee.jones@linaro.org>
Cc:     lkml <linux-kernel@vger.kernel.org>,
        Dmitry Torokhov <dmitry.torokhov@gmail.com>,
        Henrik Rydberg <rydberg@bitmath.org>,
        linux-input <linux-input@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

On Thu, Jan 14, 2021 at 4:23 PM Lee Jones <lee.jones@linaro.org> wrote:
>
> Fixes the following W=3D1 kernel build warning(s):
>
>  drivers/input/touchscreen/surface3_spi.c: In function =E2=80=98surface3_=
spi_process_touch=E2=80=99:
>  drivers/input/touchscreen/surface3_spi.c:97:6: warning: variable =E2=80=
=98timestamp=E2=80=99 set but not used [-Wunused-but-set-variable]
>
> Cc: Dmitry Torokhov <dmitry.torokhov@gmail.com>
> Cc: Henrik Rydberg <rydberg@bitmath.org>
> Cc: Benjamin Tissoires <benjamin.tissoires@gmail.com>
> Cc: linux-input@vger.kernel.org
> Signed-off-by: Lee Jones <lee.jones@linaro.org>

Reviewed-by: Benjamin Tissoires <benjamin.tissoires@redhat.com>

Thanks for the cleanup :)

Cheers,
Benjamin

> ---
>  drivers/input/touchscreen/surface3_spi.c | 2 --
>  1 file changed, 2 deletions(-)
>
> diff --git a/drivers/input/touchscreen/surface3_spi.c b/drivers/input/tou=
chscreen/surface3_spi.c
> index 731454599fcee..1da23e5585a0d 100644
> --- a/drivers/input/touchscreen/surface3_spi.c
> +++ b/drivers/input/touchscreen/surface3_spi.c
> @@ -94,9 +94,7 @@ static void surface3_spi_report_touch(struct surface3_t=
s_data *ts_data,
>
>  static void surface3_spi_process_touch(struct surface3_ts_data *ts_data,=
 u8 *data)
>  {
> -       u16 timestamp;
>         unsigned int i;
> -       timestamp =3D get_unaligned_le16(&data[15]);
>
>         for (i =3D 0; i < 13; i++) {
>                 struct surface3_ts_data_finger *finger;
> --
> 2.25.1
>