Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Thu, 14 Jan 2021 16:52:26 +0000
From:   Mark Brown <broonie@kernel.org>
To:     Muhammad Husaini Zulkifli <muhammad.husaini.zulkifli@intel.com>
Cc:     ulf.hansson@linaro.org, lgirdwood@gmail.com, robh+dt@kernel.org,
        devicetree@vger.kernel.org, adrian.hunter@intel.com,
        michal.simek@xilinx.com, linux-mmc@vger.kernel.org,
        linux-kernel@vger.kernel.org, andriy.shevchenko@intel.com,
        Rashmi.A@intel.com, mahesh.r.vaidya@intel.com
Subject: Re: [PATCH v1 7/9] dt-bindings: regulator: keembay: Add DT binding
 documentation
Message-ID: <20210114165226.GH4854@sirena.org.uk>
References: <20210114152700.21916-1-muhammad.husaini.zulkifli@intel.com>
 <20210114152700.21916-8-muhammad.husaini.zulkifli@intel.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="KscVNZbUup0vZz0f"
Content-Disposition: inline
In-Reply-To: <20210114152700.21916-8-muhammad.husaini.zulkifli@intel.com>
User-Agent: Mutt/1.10.1 (2018-07-13)
Precedence: bulk


--KscVNZbUup0vZz0f
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

On Thu, Jan 14, 2021 at 11:26:58PM +0800, Muhammad Husaini Zulkifli wrote:
> Add DT Binding Documentation for Keem Bay SD Regulator.

Please submit patches using subject lines reflecting the style for the
subsystem, this makes it easier for people to identify relevant patches.
Look at what existing commits in the area you're changing are doing and
make sure your subject lines visually resemble what they're doing.
There's no need to resubmit to fix this alone.

> +properties:
> +  compatible:
> +    const: regulator-keembay-sd

Device tree compatible strings should be in the format vendor,device.

> +required:
> +  - compatible
> +  - regulator-name

Why is regulator-name required here?  This is a standard regulator
binding property which is covered by the generic regulator bindings and
should be optional since it is for use by the system integrator to
provide more user friendly diagnostic information about which supply
this is in the system.  If you are attempting to use this for device
identification then you should be using different compatible strings for
the different regulators - even if you were using regulator-name you'd
need to document the values.

--KscVNZbUup0vZz0f
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAmAAdskACgkQJNaLcl1U
h9AMyQf/VgGgzfftUWU23N84Ve6bSZ9At7jEd5Vl/ndNDPbslLtifKeUapcq4Ole
3T0jspGiWG/PXU8sxvLXitZZHZUoZuAgVXSzMjbD8icc4IaL2Gnmi2LJS7vwbSOU
unTsZ7ax4Gwx1snI9kkqQL8wzEsGYw2qNtd1FhKOHSw6mLJpsChnvWDNi6PWRGBc
v1eKy8PcwmnLArlvKFSxe2g2zWwO3CdqLHQL4YROFK4HZ4BxQPxaLRx09nRKPdNy
bw99ZXytcPjKzZSuOq1yzMJA5z2UJl10rT82kw4BeHcwHLzOeHriHu00ldv7B/QQ
btFSO7Prp04F7LkG634QHr9T/LFgxA==
=Q+TQ
-----END PGP SIGNATURE-----

--KscVNZbUup0vZz0f--