Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <20201218031703.3053753-1-saravanak@google.com>
 <X/dpkgTnUk+inKHK@kroah.com> <e28e1f38d87c12a3c714a6573beba6e1@kernel.org>
 <ba2fcbfb-d714-2f73-3bd0-962f49363b62@nvidia.com> <CAGETcx8pdPnH1ndOCoi7Qyz8DDshCfMTzDLQM=oEaCjyds9reA@mail.gmail.com>
 <17703ac8-2238-0b64-3c98-ddadc7ae8a36@nvidia.com> <CAGETcx-=y4Ps41Lb0b_MTCbNTC_ah0cJTmPP+GajywFBc7kEfw@mail.gmail.com>
 <f0240065-a4a0-d985-a696-eba4d42ea580@nvidia.com>
In-Reply-To: <f0240065-a4a0-d985-a696-eba4d42ea580@nvidia.com>
From:   Saravana Kannan <saravanak@google.com>
Date:   Thu, 14 Jan 2021 08:52:03 -0800
Message-ID: <CAGETcx_QmbOcof5T8Wo_zFXKB+qswPN3Cbwz5a6A+m+VrnWg0A@mail.gmail.com>
Subject: Re: [PATCH v1 0/5] Enable fw_devlink=on by default
To:     Jon Hunter <jonathanh@nvidia.com>
Cc:     Marc Zyngier <maz@kernel.org>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        "Rafael J. Wysocki" <rafael@kernel.org>,
        Android Kernel Team <kernel-team@android.com>,
        LKML <linux-kernel@vger.kernel.org>,
        Jisheng Zhang <Jisheng.Zhang@synaptics.com>,
        Kevin Hilman <khilman@baylibre.com>,
        John Stultz <john.stultz@linaro.org>,
        Nicolas Saenz Julienne <nsaenzjulienne@suse.de>,
        linux-tegra <linux-tegra@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Thu, Jan 14, 2021 at 8:48 AM Jon Hunter <jonathanh@nvidia.com> wrote:
>
>
> On 14/01/2021 16:40, Saravana Kannan wrote:
> > On Thu, Jan 14, 2021 at 3:35 AM Jon Hunter <jonathanh@nvidia.com> wrote:
> >>
> >>
> >> On 13/01/2021 21:29, Saravana Kannan wrote:
> >>
> >> ...
> >>
> >>>> I am seeing the same problem on Tegra30 Cardhu A04 where several regulators
> >>>> are continuously deferred and prevents the board from booting ...
> >>>>
> >>>> [    2.518334] platform panel: probe deferral - supplier regulator@11 not ready
> >>>>
> >>>> [    2.525503] platform regulator@1: probe deferral - supplier 4-002d not ready
> >>>>
> >>>> [    2.533141] platform regulator@3: probe deferral - supplier regulator@101 not ready
> >>>>
> >>>> [    2.540856] platform regulator@5: probe deferral - supplier regulator@101 not ready
> >>>>
> >>>> [    2.548589] platform regulator@6: probe deferral - supplier regulator@101 not ready
> >>>>
> >>>> [    2.556316] platform regulator@7: probe deferral - supplier regulator@101 not ready
> >>>>
> >>>> [    2.564041] platform regulator@8: probe deferral - supplier regulator@101 not ready
> >>>>
> >>>> [    2.571743] platform regulator@9: probe deferral - supplier regulator@101 not ready
> >>>>
> >>>> [    2.579463] platform regulator@10: probe deferral - supplier regulator@101 not ready
> >>>>
> >>>> [    2.587273] platform regulator@11: probe deferral - supplier regulator@101 not ready
> >>>>
> >>>> [    2.595088] platform regulator@12: probe deferral - supplier regulator@104 not ready
> >>>>
> >>>> [    2.603837] platform regulator@102: probe deferral - supplier regulator@104 not ready
> >>>>
> >>>> [    2.611726] platform regulator@103: probe deferral - supplier regulator@104 not ready
> >>>>
> >>>> [    2.620137] platform 3000.pcie: probe deferral - supplier regulator@5 not ready
> >>>
> >>> Looks like this is not the whole log? Do you see any "wait for
> >>> supplier" logs? That's what all these boot issues should boil down to.
> >>> And as usual, pointer to DT for this board please.
> >>
> >> Ah yes I see ...
> >>
> >>  platform regulator@1: probe deferral - wait for supplier tps65911@2d
> >
> > Do you mind sharing the full log please? It's hard to tell you
> > anything useful with bits and pieces of logs.
> >
> >> Yes the device-tree for this board can be found here [0]. Looks like
> >> there is a circular dependency between the vddctrl_reg and vddcore_reg.
> >> This is part of coupled regulators which have a two-way linkage [1]. So
> >> this change appears to conflict with this.
> >
> > fw_devlink doesn't track "regulator-coupled-with". So that's probably
> > not it. Also, this patch series was made to handle simple cycles
> > properly. It'll functionally disable the device links it created when
> > it comes to probe ordering. Only two overlapping cycles might cause
> > issues -- and even that, not all the time. So yeah, full log please.
>
>
> No problem. Please find attached.

Thanks! I think you forgot to enable those logs though. Also, while
you are at it, maybe enable the logs in device_link_add() too please?

-Saravana

>
> Cheers
> Jon
>
>
> --
> nvpublic