Received: by 2002:a05:6a10:2785:0:0:0:0 with SMTP id ia5csp416729pxb;
        Thu, 14 Jan 2021 08:59:10 -0800 (PST)
X-Google-Smtp-Source: ABdhPJwik+uPPKzCPBH8qWhoVw5ntYXhFvypSaE3yH3o0FljK6vlYUSZZKEvRx6+mipQqvlPAu+c
X-Received: by 2002:a17:906:e90b:: with SMTP id ju11mr3831780ejb.235.1610643550495;
        Thu, 14 Jan 2021 08:59:10 -0800 (PST)
ARC-Seal: i=1; a=rsa-sha256; t=1610643550; cv=none;
        d=google.com; s=arc-20160816;
        b=dptL2niylm5KhK/TdR55maPj7703A/7sP6vGWbzcw0AZTsOtzOEUdYSrW2mfDazC2P
         d710wuQLRd+AzFka6I+ZWHtKReb8/TeUe8tHIyqLdKvVjWaEW/49Qp1rpVKPsstHzH52
         PpN2kglzFWFsyjm02DjmzHpUXO3TgctfhabD6ALeNnSj7Kp81opNhq69zhnmUrSlJKlK
         rtfdu7Zu0u7K94Ro8JPeQuIspjlqj3KyCUdRd6VyLl2XAMfRQ5KAcqHC6stiw7/W3zcQ
         1qzyiuLusQ6KKBl4b5+Re8Q1sBjxjhIIRqz3xIMwsXAo9VOPDcH8pbUxn9VxTvEj0ft8
         6N3w==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816;
        h=list-id:precedence:dkim-signature:content-transfer-encoding
         :content-language:in-reply-to:mime-version:user-agent:date
         :message-id:from:references:cc:to:subject;
        bh=VVr9Jb7p408lN4F9Eal/RHjNNIRAMwvnH+e2NcECWK0=;
        b=pmsinZkOLFL+ZMFW40Vf73A6nvd91qx5V2RWYGS522UFyx6iKjoe4/PH66wJU8tRtY
         9GHM8her2VtstMXTSxO1++9hm2MLq18PB92RXs4QVD+oSTojNbQJi6D4KqbikSRwKEOi
         vxbjVLQvgIwZeSuT91dXdcrImoiChkaN9Zt67ZYqf0njSSjz1R4QhmijtyI3Rm5xFwmR
         AGwktrDNP3hqtxp8mYHi6lF2UbCVdGu2F94d2+T2UUL43i+C767aHRuQYQ9TO+2zAxfY
         JLOMig930+KH6SiELXUd6VGdtWGe8Pt9broPFalQYUAE+s0WqW+CLVlzHepccEnEvZYm
         NWXw==
ARC-Authentication-Results: i=1; mx.google.com;
       dkim=pass header.i=@nvidia.com header.s=n1 header.b=d9pC8YML;
       spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org;
       dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=nvidia.com
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18])
        by mx.google.com with ESMTP id jj17si1947358ejc.372.2021.01.14.08.58.47;
        Thu, 14 Jan 2021 08:59:10 -0800 (PST)
Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Authentication-Results: mx.google.com;
       dkim=pass header.i=@nvidia.com header.s=n1 header.b=d9pC8YML;
       spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org;
       dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=nvidia.com
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1726695AbhANQ52 (ORCPT <rfc822;lizhong0730@gmail.com>
        + 99 others); Thu, 14 Jan 2021 11:57:28 -0500
Received: from hqnvemgate26.nvidia.com ([216.228.121.65]:1342 "EHLO
        hqnvemgate26.nvidia.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1725854AbhANQ52 (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Thu, 14 Jan 2021 11:57:28 -0500
Received: from hqmail.nvidia.com (Not Verified[216.228.121.13]) by hqnvemgate26.nvidia.com (using TLS: TLSv1.2, AES256-SHA)
        id <B600077cf0000>; Thu, 14 Jan 2021 08:56:47 -0800
Received: from [10.26.73.78] (172.20.145.6) by HQMAIL107.nvidia.com
 (172.20.187.13) with Microsoft SMTP Server (TLS) id 15.0.1473.3; Thu, 14 Jan
 2021 16:56:42 +0000
Subject: Re: [PATCH v1 0/5] Enable fw_devlink=on by default
To:     Saravana Kannan <saravanak@google.com>
CC:     Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        "Rafael J. Wysocki" <rafael@kernel.org>,
        Android Kernel Team <kernel-team@android.com>,
        LKML <linux-kernel@vger.kernel.org>,
        Jisheng Zhang <Jisheng.Zhang@synaptics.com>,
        Kevin Hilman <khilman@baylibre.com>,
        John Stultz <john.stultz@linaro.org>,
        Nicolas Saenz Julienne <nsaenzjulienne@suse.de>,
        Marc Zyngier <maz@kernel.org>,
        linux-tegra <linux-tegra@vger.kernel.org>
References: <20201218031703.3053753-1-saravanak@google.com>
 <56f7d032-ba5a-a8c7-23de-2969d98c527e@nvidia.com>
 <CAGETcx9FAAa+gUOTJX76DGGOAE4g3cTbZhwNQ-pLioYzg=fTOw@mail.gmail.com>
 <17939709-f6f4-fa9c-836f-9779081c4087@nvidia.com>
 <CAGETcx_1x7LFprsEM+-X8Y42-sbajBav5Bik4U=s4Z5XCSZtUg@mail.gmail.com>
From:   Jon Hunter <jonathanh@nvidia.com>
Message-ID: <e11bc6a2-ec9d-ea3b-71f7-13c9f764bbfc@nvidia.com>
Date:   Thu, 14 Jan 2021 16:56:39 +0000
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101
 Thunderbird/68.10.0
MIME-Version: 1.0
In-Reply-To: <CAGETcx_1x7LFprsEM+-X8Y42-sbajBav5Bik4U=s4Z5XCSZtUg@mail.gmail.com>
Content-Type: text/plain; charset="utf-8"
Content-Language: en-US
Content-Transfer-Encoding: 7bit
X-Originating-IP: [172.20.145.6]
X-ClientProxiedBy: HQMAIL101.nvidia.com (172.20.187.10) To
 HQMAIL107.nvidia.com (172.20.187.13)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nvidia.com; s=n1;
        t=1610643407; bh=VVr9Jb7p408lN4F9Eal/RHjNNIRAMwvnH+e2NcECWK0=;
        h=Subject:To:CC:References:From:Message-ID:Date:User-Agent:
         MIME-Version:In-Reply-To:Content-Type:Content-Language:
         Content-Transfer-Encoding:X-Originating-IP:X-ClientProxiedBy;
        b=d9pC8YMLtbTPfFF6dqPv+SvrD/A4t8hzLmSYIQUpuO83iQn32eWRPj+RNpSPiJjg/
         QSJg/Z2cRZq7BkQTnBerwS5Hs67qoGUU5IKpK1MzPtb0gACrLakmQod1KrKl3WPFHT
         QpJ+34pOIXE04LSWEom+OMajS7jRr5grOO6ShF6jZBjI700qkROlcR2krSSE6XLa00
         b4gnUD8AopqIuSnzOPeRcQwo0Lmtfh/0EPjzPpcnln1J5DnhnhX74IhA+5y5oEfCel
         1TcOLJuY8PALA0U6PgxRRAxawkyDOCgx2ZUMpc6nnFQ8BhkQIqFEarGy1007PvpGAZ
         MBTzqqV/RYjPQ==
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


On 14/01/2021 16:47, Saravana Kannan wrote:

...

>> Yes this is the warning shown here [0] and this is coming from
>> the 'Generic PHY stmmac-0:00' device.
> 
> Can you print the supplier and consumer device when this warning is
> happening and let me know? That'd help too. I'm guessing the phy is
> the consumer.


Sorry I should have included that. I added a print to dump this on
another build but failed to include here.

WARNING KERN Generic PHY stmmac-0:00: supplier 2200000.gpio (status 1)

The status is the link->status and looks like the supplier is the
gpio controller. I have verified that the gpio controller is probed
before this successfully.

> So the warning itself isn't a problem -- it's not breaking anything or
> leaking memory or anything like that. But the device link is jumping
> states in an incorrect manner. With enough context of this code (why
> the device_bind_driver() is being called directly instead of going
> through the normal probe path), it should be easy to fix (I'll just
> need to fix up the device link state).


Correct, the board seems to boot fine, we just get this warning.

Cheers
Jon

-- 
nvpublic