Received: by 2002:a05:6a10:2785:0:0:0:0 with SMTP id ia5csp469700pxb; Thu, 14 Jan 2021 10:10:55 -0800 (PST) X-Google-Smtp-Source: ABdhPJzx3AdLd2an2OuEHtj11r/KErMygq14Z5sKGHyN6s5jVgi+KyIVlwYYvfxjwlTvRYKZcdOk X-Received: by 2002:a17:906:b0c2:: with SMTP id bk2mr6301128ejb.223.1610647855333; Thu, 14 Jan 2021 10:10:55 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1610647855; cv=none; d=google.com; s=arc-20160816; b=n7pVApG/H/Dlz59rXRgAz2b2gCmoh7TuTCLFixwB2E0n6oa8GO8WOBWrAMFTei4jXY rEHmgHo4iRK8lAmodrcvRv2XAzQfYUjREPoAJ/1M/VO/bIOvsfgYah2wvLijD8XPWlRw LZe+4NkMrcy9mGVtrkgDjj8Ylo1Z6fAATuA5pXJyQTGrtVfphNJYhEL9QtQox3Qa3Ry2 ivqXy3Epb6OvvuPagyQJ0oai+X7viYhjU/68nwLbFtr15CsdDRb13hzXkwzW7N4gx4/3 tbXq8PTLd50u3mKQA8Pd6npqA82dGFjBdi8JIW2yxMFRFG8mgMA1PYsfCrfYxivNSrba KmMQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from; bh=H2axvZzXN5fIOrxGDOBQ+xCFGjy4ZN5X1xz6XM7OBN8=; b=tvkf45q5jv1ikLF/RkzT5AVsZUIrMS+DGoZQzZTxVekM/84PsM/FzcZGKYspEjs5WI Fc/ICkFuV9y+BgpurVQIC+MH8xjX2echj67jbeGAhfkD/51T7Rno6iCUgvt5T/vzRvHp AcBof1VsqwnUH1gLTN8o9W8r68fMcKhft6wb8LRtPmclL6zA6CPcJlqI3dKzhu8o6Znz Bp7lVh24gw8XJdlHwmofiroWk2RhE8w4mZtyB2IVxI04p+7IX2C8zLlhc+6bDkXmnxbA RCXerla9jxPmIjJYvzu0a+h5whrLN0f+Iiqmn33pEhRimbfA2/D26H16VdH6E8SkleTg w9qQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=collabora.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id g1si2811249ejz.557.2021.01.14.10.10.30; Thu, 14 Jan 2021 10:10:55 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=collabora.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729677AbhANSI5 (ORCPT + 99 others); Thu, 14 Jan 2021 13:08:57 -0500 Received: from bhuna.collabora.co.uk ([46.235.227.227]:51556 "EHLO bhuna.collabora.co.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729590AbhANSIz (ORCPT ); Thu, 14 Jan 2021 13:08:55 -0500 Received: from [127.0.0.1] (localhost [127.0.0.1]) (Authenticated sender: koike) with ESMTPSA id ECB6A1F45D09 From: Helen Koike To: linux-media@vger.kernel.org Cc: hverkuil@xs4all.nl, mchehab@kernel.org, hans.verkuil@cisco.com, laurent.pinchart@ideasonboard.com, sakari.ailus@iki.fi, boris.brezillon@collabora.com, hiroh@chromium.org, nicolas@ndufresne.ca, Brian.Starkey@arm.com, kernel@collabora.com, narmstrong@baylibre.com, linux-kernel@vger.kernel.org, frkoenig@chromium.org, stanimir.varbanov@linaro.org, tfiga@chromium.org Subject: [RFC PATCH v6 06/11] media: vivid: use vb2_ioctls_ext_{d}qbuf hooks Date: Thu, 14 Jan 2021 15:07:33 -0300 Message-Id: <20210114180738.1758707-7-helen.koike@collabora.com> X-Mailer: git-send-email 2.29.2 In-Reply-To: <20210114180738.1758707-1-helen.koike@collabora.com> References: <20210114180738.1758707-1-helen.koike@collabora.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Add vb2 ext hooks and call vb2_set_pixelformat(). This allows more flexibility with buffer handling. Signed-off-by: Helen Koike --- Changes in v6: - New patch to exemplify how drivers would easily support features from Ext Buf --- drivers/media/test-drivers/vivid/vivid-core.c | 2 ++ drivers/media/test-drivers/vivid/vivid-vid-cap.c | 1 + drivers/media/test-drivers/vivid/vivid-vid-out.c | 1 + 3 files changed, 4 insertions(+) diff --git a/drivers/media/test-drivers/vivid/vivid-core.c b/drivers/media/test-drivers/vivid/vivid-core.c index 0dc65ef3aa14..eacb23808c7e 100644 --- a/drivers/media/test-drivers/vivid/vivid-core.c +++ b/drivers/media/test-drivers/vivid/vivid-core.c @@ -723,6 +723,8 @@ static const struct v4l2_ioctl_ops vivid_ioctl_ops = { .vidioc_querybuf = vb2_ioctl_querybuf, .vidioc_qbuf = vb2_ioctl_qbuf, .vidioc_dqbuf = vb2_ioctl_dqbuf, + .vidioc_ext_qbuf = vb2_ioctl_ext_qbuf, + .vidioc_ext_dqbuf = vb2_ioctl_ext_dqbuf, .vidioc_expbuf = vb2_ioctl_expbuf, .vidioc_streamon = vb2_ioctl_streamon, .vidioc_streamoff = vb2_ioctl_streamoff, diff --git a/drivers/media/test-drivers/vivid/vivid-vid-cap.c b/drivers/media/test-drivers/vivid/vivid-vid-cap.c index b9caa4b26209..882b0c4a6591 100644 --- a/drivers/media/test-drivers/vivid/vivid-vid-cap.c +++ b/drivers/media/test-drivers/vivid/vivid-vid-cap.c @@ -169,6 +169,7 @@ static int vid_cap_buf_prepare(struct vb2_buffer *vb) } vb2_set_plane_payload(vb, p, size); + vb2_set_pixelformat(vb, dev->fmt_cap->fourcc); vb->planes[p].data_offset = dev->fmt_cap->data_offset[p]; } diff --git a/drivers/media/test-drivers/vivid/vivid-vid-out.c b/drivers/media/test-drivers/vivid/vivid-vid-out.c index ac1e981e8342..6be61112065d 100644 --- a/drivers/media/test-drivers/vivid/vivid-vid-out.c +++ b/drivers/media/test-drivers/vivid/vivid-vid-out.c @@ -136,6 +136,7 @@ static int vid_out_buf_prepare(struct vb2_buffer *vb) return -EINVAL; } } + vb2_set_pixelformat(vb, dev->fmt_out->fourcc); return 0; } -- 2.29.2