Received: by 2002:a05:6a10:2785:0:0:0:0 with SMTP id ia5csp470745pxb; Thu, 14 Jan 2021 10:12:22 -0800 (PST) X-Google-Smtp-Source: ABdhPJwXOpNksVKGMOaxZWycOGMb7IYxNMQczc0h1RzuKXL0Pw+X9qLPAppLVpyO1zxT33nMTnWA X-Received: by 2002:a05:6402:2707:: with SMTP id y7mr2614700edd.5.1610647941890; Thu, 14 Jan 2021 10:12:21 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1610647941; cv=none; d=google.com; s=arc-20160816; b=xQHMAqDk68TyhkO1mbO27rn78J4IVh+0mdQ+VZE7sTbq2FAwTuQ7c5jSzoc78bnhaY 0aqLbX08vi6KgkrLMBtcQWECGtn8gx8timm0d1kKZUshPJZQ/q6fQBFI+fekUxatjVGB bW1BcjkbJ4VqP45aGyt3NPKapmvw8yCsYS01KH54d6GQ09ZuNuFtHm3iZwqLu59zLi6x PPuG44NwVp1WKG+oDF+okqbwQLanvI5rWWcwex9Yy3Uq1E7gDP+B/2zvy7S8hQPetdpP dQwxHdTp8qWO2dKJOJEKyH9+x9N3KJ+iCk1mgoT982AWArOOw2uVlWgpBkgkZJNhW/U+ JosA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from; bh=HrB56vMVIo2bK/e6GrKwkNAWdtze32EaPGaXKCphPjQ=; b=rWw3RNADOlVIHlkA3L4kQoPKyFr956DTbOSIPHwey5H7buyh82N0rpuUDOjhMGf6kd FHP9uHUyUYxPiIy++O2x9CyNidMTApNtlWvV3wNf+IQ59QqlNYpQSfO0zUIjsqOovOo2 np8hb1i7HvXE+pFlbNb1NW/jkgmUsjloVxOVPyZOhbsH+sxt8F9aIr2xY9gCIDxwwRcb fWFCxV47q4+382ghV5nnU3ITV6hYu7HAIrHl9KHCY12FHDWbF8GcTdZWqSD9BEU+/6DD kHDpD412izPxv+8cLHqRffuzEs35ud1Veih4y+cAQZjQOPPwDNriUKcqKvWCqQCmA4aa sLJA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=collabora.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id hr35si2574983ejc.274.2021.01.14.10.11.57; Thu, 14 Jan 2021 10:12:21 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=collabora.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729734AbhANSJA (ORCPT + 99 others); Thu, 14 Jan 2021 13:09:00 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56008 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729706AbhANSI7 (ORCPT ); Thu, 14 Jan 2021 13:08:59 -0500 Received: from bhuna.collabora.co.uk (bhuna.collabora.co.uk [IPv6:2a00:1098:0:82:1000:25:2eeb:e3e3]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8C29EC0613CF; Thu, 14 Jan 2021 10:08:19 -0800 (PST) Received: from [127.0.0.1] (localhost [127.0.0.1]) (Authenticated sender: koike) with ESMTPSA id A698E1F45D07 From: Helen Koike To: linux-media@vger.kernel.org Cc: hverkuil@xs4all.nl, mchehab@kernel.org, hans.verkuil@cisco.com, laurent.pinchart@ideasonboard.com, sakari.ailus@iki.fi, boris.brezillon@collabora.com, hiroh@chromium.org, nicolas@ndufresne.ca, Brian.Starkey@arm.com, kernel@collabora.com, narmstrong@baylibre.com, linux-kernel@vger.kernel.org, frkoenig@chromium.org, stanimir.varbanov@linaro.org, tfiga@chromium.org Subject: [RFC PATCH v6 07/11] media: vimc: use vb2_ioctls_ext_{d}qbuf hooks Date: Thu, 14 Jan 2021 15:07:34 -0300 Message-Id: <20210114180738.1758707-8-helen.koike@collabora.com> X-Mailer: git-send-email 2.29.2 In-Reply-To: <20210114180738.1758707-1-helen.koike@collabora.com> References: <20210114180738.1758707-1-helen.koike@collabora.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Add vb2 ext hooks and call vb2_set_pixelformat(). This allows more flexibility with buffer handling. Signed-off-by: Helen Koike --- Changes in v6: - New patch to exemplify how drivers would easily support features from Ext Buf --- drivers/media/test-drivers/vimc/vimc-capture.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/media/test-drivers/vimc/vimc-capture.c b/drivers/media/test-drivers/vimc/vimc-capture.c index 5e9fd902cd37..729614d19002 100644 --- a/drivers/media/test-drivers/vimc/vimc-capture.c +++ b/drivers/media/test-drivers/vimc/vimc-capture.c @@ -217,6 +217,8 @@ static const struct v4l2_ioctl_ops vimc_cap_ioctl_ops = { .vidioc_querybuf = vb2_ioctl_querybuf, .vidioc_qbuf = vb2_ioctl_qbuf, .vidioc_dqbuf = vb2_ioctl_dqbuf, + .vidioc_ext_qbuf = vb2_ioctl_ext_qbuf, + .vidioc_ext_dqbuf = vb2_ioctl_ext_dqbuf, .vidioc_expbuf = vb2_ioctl_expbuf, .vidioc_streamon = vb2_ioctl_streamon, .vidioc_streamoff = vb2_ioctl_streamoff, @@ -389,6 +391,7 @@ static void *vimc_cap_process_frame(struct vimc_ent_device *ved, /* Set it as ready */ vb2_set_plane_payload(&vimc_buf->vb2.vb2_buf, 0, vcap->format.sizeimage); + vb2_set_pixelformat(&vimc_buf->vb2.vb2_buf, vcap->format.pixelformat); vb2_buffer_done(&vimc_buf->vb2.vb2_buf, VB2_BUF_STATE_DONE); return NULL; } -- 2.29.2