Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Thu, 14 Jan 2021 19:56:51 +0100
From:   Jonathan =?utf-8?Q?Neusch=C3=A4fer?= <j.neuschaefer@gmx.net>
To:     Andreas Kemnade <andreas@kemnade.info>
Cc:     Jonathan =?utf-8?Q?Neusch=C3=A4fer?= <j.neuschaefer@gmx.net>,
        linux-kernel@vger.kernel.org, Lee Jones <lee.jones@linaro.org>,
        Rob Herring <robh+dt@kernel.org>,
        Thierry Reding <thierry.reding@gmail.com>,
        Uwe =?utf-8?Q?Kleine-K=C3=B6nig?= 
        <u.kleine-koenig@pengutronix.de>,
        Alessandro Zummo <a.zummo@towertech.it>,
        Alexandre Belloni <alexandre.belloni@bootlin.com>,
        Shawn Guo <shawnguo@kernel.org>,
        Sascha Hauer <s.hauer@pengutronix.de>,
        Pengutronix Kernel Team <kernel@pengutronix.de>,
        Fabio Estevam <festevam@gmail.com>,
        NXP Linux Team <linux-imx@nxp.com>,
        Sam Ravnborg <sam@ravnborg.org>,
        Linus Walleij <linus.walleij@linaro.org>,
        Heiko Stuebner <heiko.stuebner@theobroma-systems.com>,
        Stephan Gerhold <stephan@gerhold.net>,
        Lubomir Rintel <lkundrak@v3.sk>,
        Mark Brown <broonie@kernel.org>, allen <allen.chen@ite.com.tw>,
        Mauro Carvalho Chehab <mchehab+huawei@kernel.org>,
        "David S. Miller" <davem@davemloft.net>,
        devicetree@vger.kernel.org, linux-pwm@vger.kernel.org,
        linux-rtc@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
        Heiko Stuebner <heiko@sntech.de>,
        Josua Mayer <josua.mayer@jm0.eu>,
        Arnd Bergmann <arnd@arndb.de>, Daniel Palmer <daniel@0x0f.com>,
        Andy Shevchenko <andy.shevchenko@gmail.com>
Subject: Re: [PATCH v7 3/7] mfd: Add base driver for Netronix embedded
 controller
Message-ID: <YACT87oEA17yJiff@latitude>
References: <20210109180220.121511-1-j.neuschaefer@gmx.net>
 <20210109180220.121511-4-j.neuschaefer@gmx.net>
 <20210112203649.67f66996@aktux>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="HZCy9zKgDQy/QBjw"
Content-Disposition: inline
In-Reply-To: <20210112203649.67f66996@aktux>
Precedence: bulk


--HZCy9zKgDQy/QBjw
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Tue, Jan 12, 2021 at 08:36:49PM +0100, Andreas Kemnade wrote:
> On Sat,  9 Jan 2021 19:02:16 +0100
> Jonathan Neusch=C3=A4fer <j.neuschaefer@gmx.net> wrote:
[...]
> > +static const struct of_device_id of_ntxec_match_table[] =3D {
> > +	{ .compatible =3D "netronix,ntxec", },
> > +	{}
> > +};
> > +
> MODULE_DEVICE_TABLE?

Yes, good idea.

> > +static struct i2c_driver ntxec_driver =3D {
> > +	.driver =3D {
> > +		.name =3D "ntxec",
> > +		.of_match_table =3D of_ntxec_match_table,
> > +	},
> > +	.probe_new =3D ntxec_probe,
> > +	.remove =3D ntxec_remove,
> > +};
> > +module_i2c_driver(ntxec_driver);
>=20
> MODULE_LICENSE()?
>=20
> modpost moans about that here.

I forgot those. Thanks for noticing.
I'll add the MODULE_ lines in v8.


Thanks,
Jonathan

--HZCy9zKgDQy/QBjw
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCgAdFiEEvHAHGBBjQPVy+qvDCDBEmo7zX9sFAmAAk+oACgkQCDBEmo7z
X9szGg//QvOXORc7uh9Jjyie8pM10KL+AGsOtYoNGGd6pZu/uUmCTdY3bJ3PsYNS
tFEETWnnlg7zvIvi5ct92QGwmIYtg2zd1gYQbwOh513AGCArH94ow7g6aJtxk3HA
I8Xd/4pMrMaDZpv9S6xc09EBCLvniWaUxQ+1b/NAf4PgHDQpH/aOcoxG8PxxxsDD
dfBEqCOWR6rAKAy1wA0gdzzSX+v7QMoYnejpAjLdi1Lhnu6v2GhzYsPMiSxC95i+
ZzZna44PPaVE8LiwC2PqORimyXsF63srsY93kZEFfd10qe+zGCZx7qLjBLiKeTK8
JMt7QUz3ll9SWF8oYlMdofO7HHrtmqnWTMjgaYbhYqr2oqOunLWKyF2RUF1OMlU2
0HZS+wX3PGODLsPeyVup3Qx9hrkqQI2AOsQyW1nyDu/idUjC4bPGTK/7QpOGWFwx
eI3riV02jUpETGg93V3OrcHhefNdLJIPd9FGNDuz4gI1nmSggzfcnNlGIWvk1Pdi
ELV+NBvGXnxKPHvjlKSyiI5/oqw4Ernexb+yRnn0spfB8zGzomzUXOkp0WD8a0FA
5KT3UW/KnYg9kAl41zZksLacmuj4gQ7ZKRd2M2rakue0gi7mji1Zd8LZO7K6W4lb
LV4K5c05oLVqjumvUDXEzlrb9KfRz18HrBZs/F1d3+iV/6k0r74=
=fKvQ
-----END PGP SIGNATURE-----

--HZCy9zKgDQy/QBjw--