Received: by 2002:a05:6a10:2785:0:0:0:0 with SMTP id ia5csp623498pxb; Thu, 14 Jan 2021 14:27:21 -0800 (PST) X-Google-Smtp-Source: ABdhPJxpR4DcsWLil7b8gVJYhYX0R6NOoeRhnZ3KV56jsLz6q7HRoNNjJuQsjHrLiLKU9Hu3c5H0 X-Received: by 2002:a05:6402:356:: with SMTP id r22mr2355441edw.244.1610663241572; Thu, 14 Jan 2021 14:27:21 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1610663241; cv=none; d=google.com; s=arc-20160816; b=rVpW/xknWVIaxyjV+dsxpuK5l0gi42VgoG3Vd9T0qrbN2BQrVLJAZO67QMqS4xpVef bHEk6ayS8twdn1fGWOaI89gU6Ih/D4zu1xwujR7a2eyYH1cnfLKqMQ3gljgPhBvrfsdM NjZduUveOjK/Kqb2G6wdwZuLezPUIRtDqbsLp69ViqvIdevVQMymJ8SiS2rfismeiGy9 WM22kegujLd/xy5gDzRLhKPs1oU2PAeZAtmh7F6O6WHOnH49qy3G2nUZFP6On0oxaYdJ n2c5Fy8BrCmC61YW9Yn6xgxK8vpvKgWUTW64DyQvHIr9NRYOHAjaQkuDSqditn7W8t7v 4M+Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:cc:to:subject:message-id:date:from:in-reply-to :references:mime-version:dkim-signature; bh=gRC5Pleb9dUxv3nJaqlApsE2Yyj1i5/5CS0p59ghBkc=; b=JIzZjXcJhDQ4T2YXnlm2ocMLlD2nqMcz5Mbu2dybf/TWGMmnTEo5BqxZY4vvbvXD0W MS1gC7Z09Pua6K6oVaj5nFsDJxLgQi3X6ieyFDYhGNNDJa+er2B3FKnKKxZIhIti+hzb yrxsW9I0bfSUJvAcwcjWy8nO5Uz/oI5hRCyzf6DX2saCYT6YE309tWAHNo8W7ARcjwKT nZdYytwhwSDqS9qS3pjVtOthZh/IcXiloXJjESaZVMVe6MNL4AqqzuGaqLl937FEjWLW PRPdp7Z3pG2+ZpJ8LLDAODb8Po6FJj9DxRIOvdlC0yI9Rz4k+oi5kXegqbOfDs/Dsi87 LGVw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@google.com header.s=20161025 header.b=NuA3EJ3p; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=google.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id p17si2944620ejw.23.2021.01.14.14.26.58; Thu, 14 Jan 2021 14:27:21 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@google.com header.s=20161025 header.b=NuA3EJ3p; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=google.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730723AbhANWZN (ORCPT + 99 others); Thu, 14 Jan 2021 17:25:13 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54812 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730720AbhANWZM (ORCPT ); Thu, 14 Jan 2021 17:25:12 -0500 Received: from mail-pf1-x436.google.com (mail-pf1-x436.google.com [IPv6:2607:f8b0:4864:20::436]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 71EBDC061757 for ; Thu, 14 Jan 2021 14:24:32 -0800 (PST) Received: by mail-pf1-x436.google.com with SMTP id a188so4210063pfa.11 for ; Thu, 14 Jan 2021 14:24:32 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=gRC5Pleb9dUxv3nJaqlApsE2Yyj1i5/5CS0p59ghBkc=; b=NuA3EJ3p4xB56QjPMOsEQQMUhXG3PQ0y8iWnVaCIXTapcQ7PX3/QSUg5osssQ6nGaj nXJUe4amtRfx6WBlML3wsytOVgXf5u3kqra+2KdixvTHv9z4lABT8g0mk1lW/SojZ+EK PkMKhJ1T1u6iB1YcKAH8AE+8Gu9QaZ+l2SS3rakd67ORcNMQNvVx9KN2dJBgTVTgrAK8 JV11HngiDjErzuUzkePUoq+HBWMAR52Q6rYRdwVXEq/tpnvwFg8N9r0Ne1j8nKhdHvax m9qmj+a0tvXZHGHElR23N6c2euo8y2gB7BYZCAGbPbnESrxtBxA/D52GWNDgkwbgA+Jp u/FA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=gRC5Pleb9dUxv3nJaqlApsE2Yyj1i5/5CS0p59ghBkc=; b=muXJO8OWWKbvLIL1xoxoEFqca0IEVf8O8kOgwxwSoYSbCXhzor4QUuf2zbm8XlTmAM RjMT5I2dSqGUj+G8coto8ihf3UswqE0k6lPQ6zYMk5DDX3NbrzG6u3qwas1nYe8K+imD urV+7CeBekH47SIyPLJEy27J2y1qY92bU9+DAwsVGm/somLYTo8LBOwzDOPv2MypHYd+ DXAv5ImrTcR1kbvV4f8+08PqDSd+ZtrTF76LyeK1jOH2JEaiwiznD5X+4g3n48Ngp9AH hZd0Cr/Ce1orCKrJgEC8SXj0UaR5le3+9AzfZtoro/N9bQp8NbOu+Vnz5wgV83kIsi8H NBqg== X-Gm-Message-State: AOAM533+VKBqrPyp8/p1zmowZZtloH1zUv9y3xXLXzCOSuSryqDQaEbM ttLCuia0tGScIL8ay1d2kzlqA9ErJeNWC3baWtgmSQ== X-Received: by 2002:a63:c84a:: with SMTP id l10mr9703913pgi.159.1610663071797; Thu, 14 Jan 2021 14:24:31 -0800 (PST) MIME-Version: 1.0 References: <20201202190824.1309398-1-dlatypov@google.com> In-Reply-To: <20201202190824.1309398-1-dlatypov@google.com> From: Brendan Higgins Date: Thu, 14 Jan 2021 14:24:20 -0800 Message-ID: Subject: Re: [PATCH v2 1/4] kunit: tool: fix unit test cleanup handling To: Daniel Latypov Cc: David Gow , Linux Kernel Mailing List , "open list:KERNEL SELFTEST FRAMEWORK" , Shuah Khan Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Dec 2, 2020 at 11:09 AM Daniel Latypov wrote: > > * Stop leaking file objects. > * Use self.addCleanup() to ensure we call cleanup functions even if > setUp() fails. > * use mock.patch.stopall instead of more error-prone manual approach > > Signed-off-by: Daniel Latypov Tested-by: Brendan Higgins Acked-by: Brendan Higgins