Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <20210113160621.98615-1-fengli@smartx.com> <SN4PR0401MB35985C08E5FFCDF0F5817A9D9BA90@SN4PR0401MB3598.namprd04.prod.outlook.com>
 <87698545-de26-c0ca-01e9-4dc2ddcacc80@grimberg.me> <20210114174311.GB31188@lst.de>
In-Reply-To: <20210114174311.GB31188@lst.de>
From:   Li Feng <fengli@smartx.com>
Date:   Fri, 15 Jan 2021 11:30:06 +0800
Message-ID: <CAHckoCzhJVAWFSYeCAMHZ+fVqzv_1XxvM97QmvCESnEcc5AQuQ@mail.gmail.com>
Subject: Re: [PATCH] nvme: reject the ns when the block size is smaller than a sector
To:     Christoph Hellwig <hch@lst.de>
Cc:     Sagi Grimberg <sagi@grimberg.me>,
        Johannes Thumshirn <Johannes.Thumshirn@wdc.com>,
        "martin.petersen@oracle.com" <martin.petersen@oracle.com>,
        Keith Busch <kbusch@kernel.org>, Jens Axboe <axboe@fb.com>,
        "open list:NVM EXPRESS DRIVER" <linux-nvme@lists.infradead.org>,
        open list <linux-kernel@vger.kernel.org>,
        "lifeng1519@gmail.com" <lifeng1519@gmail.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

Christoph Hellwig <hch@lst.de> =E4=BA=8E2021=E5=B9=B41=E6=9C=8815=E6=97=A5=
=E5=91=A8=E4=BA=94 =E4=B8=8A=E5=8D=881:43=E5=86=99=E9=81=93=EF=BC=9A
>
> On Wed, Jan 13, 2021 at 02:12:59PM -0800, Sagi Grimberg wrote:
> >> But this only catches a physical block size < 512 for NVMe, not any ot=
her block device.
> >>
> >> Please fix it for the general case in blk_queue_physical_block_size().
> >
> > We actually call that later and would probably be better to check here.=
.
>
> We had a series for that a short while ago that got lost.
Where is the series? Or could you advise on how to fix this issue is accept=
able?
This issue will generate an oops, check it here:
https://lkml.org/lkml/2021/1/12/1064

Thanks,
Feng Li