Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: quoted-printable
In-Reply-To: <1601448168-18396-3-git-send-email-srivasam@codeaurora.org>
References: <1601448168-18396-1-git-send-email-srivasam@codeaurora.org> <1601448168-18396-3-git-send-email-srivasam@codeaurora.org>
Subject: Re: [PATCH v3 2/2] arm64: dts: qcom: sc7180-trogdor: Add lpass dai link for HDMI
From:   Stephen Boyd <swboyd@chromium.org>
Cc:     V Sujith Kumar Reddy <vsujithk@codeaurora.org>,
        Srinivasa Rao Mandadapu <srivasam@codeaurora.org>
To:     Srinivasa Rao Mandadapu <srivasam@codeaurora.org>,
        agross@kernel.org, bjorn.andersson@linaro.org,
        devicetree@vger.kernel.org, linux-arm-msm@vger.kernel.org,
        linux-kernel@vger.kernel.org, robh+dt@kernel.org,
        rohitkr@codeaurora.org, srinivas.kandagatla@linaro.org
Date:   Thu, 14 Jan 2021 19:18:17 -0800
Message-ID: <161068069765.3661239.6061499369110570958@swboyd.mtv.corp.google.com>
User-Agent: alot/0.9.1
Precedence: bulk

Quoting Srinivasa Rao Mandadapu (2020-09-29 23:42:48)
> diff --git a/arch/arm64/boot/dts/qcom/sc7180-trogdor.dtsi b/arch/arm64/bo=
ot/dts/qcom/sc7180-trogdor.dtsi
> index 5724982..850b43e 100644
> --- a/arch/arm64/boot/dts/qcom/sc7180-trogdor.dtsi
> +++ b/arch/arm64/boot/dts/qcom/sc7180-trogdor.dtsi
> @@ -231,6 +231,7 @@
> =20
>                 audio-jack =3D <&alc5682>;
> =20
> +               #sound-dai-cells =3D <0>;
>                 #address-cells =3D <1>;
>                 #size-cells =3D <0>;
> =20
> @@ -257,6 +258,17 @@
>                                 sound-dai =3D <&max98357a>;
>                         };
>                 };

Can you please add a newline here?

> +               dai-link@2 {
> +                       link-name =3D "MultiMedia2";
> +                       reg =3D <2>;
> +                       cpu {
> +                               sound-dai =3D <&lpass_cpu 2>;
> +                       };
> +
> +                       codec {
> +                               sound-dai =3D <&msm_dp>;
> +                       };
> +               };
>         };
>  };
> =20
> @@ -782,6 +794,9 @@ hp_i2c: &i2c9 {
>                 reg =3D <MI2S_SECONDARY>;
>                 qcom,playback-sd-lines =3D <0>;
>         };

Can you please add a newline here?

> +       hdmi-primary@0 {

This should be hdmi-primary@2 {

Or a more generic node name should be devised. dai@2 perhaps?

> +               reg =3D <LPASS_DP_RX>;
> +       };
>  };
>