Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <20210114181751.768687-1-jackmanb@google.com>
In-Reply-To: <20210114181751.768687-1-jackmanb@google.com>
From:   Alexei Starovoitov <alexei.starovoitov@gmail.com>
Date:   Thu, 14 Jan 2021 19:23:32 -0800
Message-ID: <CAADnVQJVvwoZsE1K+6qRxzF7+6CvZNzygnoBW9tZNWJELk5c=Q@mail.gmail.com>
Subject: Re: [PATCH bpf-next v7 00/11] Atomics for eBPF
To:     Brendan Jackman <jackmanb@google.com>
Cc:     bpf <bpf@vger.kernel.org>, Alexei Starovoitov <ast@kernel.org>,
        Daniel Borkmann <daniel@iogearbox.net>,
        Andrii Nakryiko <andrii.nakryiko@gmail.com>,
        KP Singh <kpsingh@chromium.org>,
        Florent Revest <revest@chromium.org>,
        LKML <linux-kernel@vger.kernel.org>,
        =?UTF-8?B?QmrDtnJuIFTDtnBlbA==?= <bjorn.topel@gmail.com>,
        John Fastabend <john.fastabend@gmail.com>,
        Yonghong Song <yhs@fb.com>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Thu, Jan 14, 2021 at 10:18 AM Brendan Jackman <jackmanb@google.com> wrote:
>
> There's still one unresolved review comment from John[3] which I
> will resolve with a followup patch.
>
> Differences from v6->v7 [1]:
>
> * Fixed riscv build error detected by 0-day robot.

Applied.
Thanks a lot.

Please address John's request in a followup and these few issues:

- rst doesn't look correct. Example:
rst2man Documentation/networking/filter.rst >/dev/null
Documentation/networking/filter.rst:1053: (WARNING/2) Inline emphasis
start-string without end-string.

> Except ``BPF_ADD`` _without_ ``BPF_FETCH`` (for legacy reasons), all 4 byte
> atomic operations require alu32 mode. Clang enables this mode by default in
> architecture v3 (``-mcpu=v3``). For older versions it can be enabled with
> ``-Xclang -target-feature -Xclang +alu32``.

It reads confusing to me.
I would rephrase 'clang enables this mode by default' into
'clang can generate new atomic instruction when -mcpu=v3 is enabled'.

'For older versions...'
This part I didn't get. The users need clang 12 that is capable to
emit these insns.
What 'older versions' you're talking about?