Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Fri, 15 Jan 2021 07:32:18 +0100
From:   Klaus Jensen <its@irrelevant.dk>
To:     linux-nvme@lists.infradead.org
Cc:     Sagi Grimberg <sagi@grimberg.me>,
        Klaus Jensen <k.jensen@samsung.com>,
        linux-kernel@vger.kernel.org, Jens Axboe <axboe@fb.com>,
        Keith Busch <kbusch@kernel.org>, Christoph Hellwig <hch@lst.de>
Subject: Re: [PATCH v2] nvme: allow use of cmb on v1.4 controllers
Message-ID: <YAE28i5Aq0U40fPB@apples.localdomain>
References: <20210115063046.274495-1-its@irrelevant.dk>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha256;
        protocol="application/pgp-signature"; boundary="1U8gbzxJNV82M3VG"
Content-Disposition: inline
In-Reply-To: <20210115063046.274495-1-its@irrelevant.dk>
Precedence: bulk


--1U8gbzxJNV82M3VG
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Jan 15 07:30, Klaus Jensen wrote:
> From: Klaus Jensen <k.jensen@samsung.com>
>=20
> Since NVMe v1.4 the Controller Memory Buffer must be explicitly enabled
> by the host.
>=20

Sorry, messed up and missed adding the changes for v2.

v2:
  - Do not explicitly check the NVMe version, rely on the presence of
    the new register instead. (Christoph)
  - Use hi_lo_writeq. (Christoph, Keith)
  - Fix missing offset and use pci_bus_address(). (Keith)

--1U8gbzxJNV82M3VG
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQEzBAEBCAAdFiEEUigzqnXi3OaiR2bATeGvMW1PDekFAmABNuwACgkQTeGvMW1P
DelOBggAsOWPWqP1jQiNj9M5TyKKmCMZXVgMRiAyHX0NIXPQJYePYleMU572MNvQ
HJai6Z0+YpnRZCG6XAmHSj61pJ/jum64DSBwRmVMAIjYyv6r/4n56XvP4QobIr9J
cTQ+HN89ueW77SzLgDDwsAplW+9l/siY4o5UDJE1RIXnVpy/HSoyV1hWrQD1hFze
41G5/O9MAx8srSpGbO90tmY/eZ4EvrI8S4AY/2D/CX/ElOkodJsf9PM7qHz/I0Ly
lrneSiU34OhvufoFunmWcN0OWQowHqHLr4Jpm/RxAgJG8ucaB0WlUuMzMdx0VFI0
KVmU3V/zt54k0UAwJy2jYcXY7WXkNA==
=zs9f
-----END PGP SIGNATURE-----

--1U8gbzxJNV82M3VG--