Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Mime-Version: 1.0
Subject: RE: Re: [PATCH v18 3/3] scsi: ufs: Prepare HPB read for cached
 sub-region
Reply-To: daejun7.park@samsung.com
Sender: Daejun Park <daejun7.park@samsung.com>
From:   Daejun Park <daejun7.park@samsung.com>
To:     Can Guo <cang@codeaurora.org>,
        Daejun Park <daejun7.park@samsung.com>
CC:     Greg KH <gregkh@linuxfoundation.org>,
        "avri.altman@wdc.com" <avri.altman@wdc.com>,
        "jejb@linux.ibm.com" <jejb@linux.ibm.com>,
        "martin.petersen@oracle.com" <martin.petersen@oracle.com>,
        "asutoshd@codeaurora.org" <asutoshd@codeaurora.org>,
        "stanley.chu@mediatek.com" <stanley.chu@mediatek.com>,
        "bvanassche@acm.org" <bvanassche@acm.org>,
        "huobean@gmail.com" <huobean@gmail.com>,
        ALIM AKHTAR <alim.akhtar@samsung.com>,
        "linux-scsi@vger.kernel.org" <linux-scsi@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        Sung-Jun Park <sungjun07.park@samsung.com>,
        yongmyung lee <ymhungry.lee@samsung.com>,
        Jinyoung CHOI <j-young.choi@samsung.com>,
        Adel Choi <adel.choi@samsung.com>,
        BoRam Shin <boram.shin@samsung.com>,
        SEUNGUK SHIN <seunguk.shin@samsung.com>
In-Reply-To: <c6a4e4abd856aa03b6b91b619cddbeb7@codeaurora.org>
Message-ID: <20210115075935epcms2p6e7fb72edab9f5f1390164b3c66c016d5@epcms2p6>
Date:   Fri, 15 Jan 2021 16:59:35 +0900
Content-Transfer-Encoding: 7bit
Content-Type: text/plain; charset="utf-8"
CMS-TYPE: 102P
DLP-Filter: Pass
References: <c6a4e4abd856aa03b6b91b619cddbeb7@codeaurora.org>
        <e9b2479d0371e3cbe8aeb6c90ffb5d72@codeaurora.org>
        <20201222015704epcms2p643f0c5011064a7ce56b08331811a8509@epcms2p6>
        <20201222015854epcms2p1bdc30b8fab8ef01502451b75e7fbaf49@epcms2p1>
        <20210113013633epcms2p60b9dccaa405ff568a18d28b94089665b@epcms2p6>
        <CGME20201222015704epcms2p643f0c5011064a7ce56b08331811a8509@epcms2p6>
Precedence: bulk

Hi Can Guo,

> 
> On 2021-01-13 09:36, Daejun Park wrote:
> > Hi Can Guo,
> > 
> >> > +static void
> >> > +ufshpb_set_hpb_read_to_upiu(struct ufshpb_lu *hpb, struct ufshcd_lrb
> >> > *lrbp,
> >> > +				  u32 lpn, u64 ppn,  unsigned int transfer_len)
> >> > +{
> >> > +	unsigned char *cdb = lrbp->ucd_req_ptr->sc.cdb;
> >> > +
> >> > +	cdb[0] = UFSHPB_READ;
> >> 
> >> You are only replacing opcode in cdb[0], but 
> >> ufshcd_add_command_trace()
> >> is
> >> counting on lrbp->cmd->cmnd. This will lead to wrong opcode recorded 
> >> by
> >> UFS ftrace.
> >> 
> > You're comment is good point for improving this patch. But there is no
> > "case" for HPB read (0xF8) in ufshcd_add_command_trace().
> > So I will add codes to support tracing HPB read command in
> > ufshcd_add_command_trace() on next patch.
> > 
> 
> It is not just about ftrace. If HPB READ cmd fails with sense key infos.
> When SCSI layer prints the cmd, it still prints the READ(10) CDB, which 
> is
> misleading.

Oh, thanks. I will fix this problem on next patch.


Daejun