Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1030413AbWILUXp (ORCPT ); Tue, 12 Sep 2006 16:23:45 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1030415AbWILUXp (ORCPT ); Tue, 12 Sep 2006 16:23:45 -0400 Received: from stat9.steeleye.com ([209.192.50.41]:47239 "EHLO hancock.sc.steeleye.com") by vger.kernel.org with ESMTP id S1030413AbWILUXo (ORCPT ); Tue, 12 Sep 2006 16:23:44 -0400 Subject: Re: [PATCH 4/5] mvme147: Scsi_Cmnd to struct scsi_cmnd convertion From: James Bottomley To: Henne Cc: linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org In-Reply-To: <4506FCEE.1070209@nachtwindheim.de> References: <4506FCEE.1070209@nachtwindheim.de> Content-Type: text/plain Date: Tue, 12 Sep 2006 15:23:33 -0500 Message-Id: <1158092613.3461.43.camel@mulgrave.il.steeleye.com> Mime-Version: 1.0 X-Mailer: Evolution 2.2.3 (2.2.3-4.fc4) Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1081 Lines: 30 On Tue, 2006-09-12 at 20:31 +0200, Henne wrote: > Changes obsolete typedef'd Scsi_Cmnd to struct scsi_cmnd. > Signed-off-by: Henrik Kretzschmar Actually, just a single patch for all the coupled drivers would be better, please. > -int wd33c93_queuecommand(Scsi_Cmnd *, void (*done)(Scsi_Cmnd *)); > -int wd33c93_abort(Scsi_Cmnd *); > -int wd33c93_reset(Scsi_Cmnd *, unsigned int); > +int wd33c93_queuecommand(struct scsi_cmnd *, void (*done)(struct scsi_cmnd *)); > +int wd33c93_abort(struct scsi_cmnd *); > +int wd33c93_reset(struct scsi_cmnd *, unsigned int); These prototypes are all unnecessary and can be pulled out of the individual header files. The first two are provided by wd33c93.h and the last one isn't actually in the body of any file. wd33c93_info is also unused and can go. Thanks, James - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/