Received: by 2002:a05:6a10:2785:0:0:0:0 with SMTP id ia5csp245849pxb; Fri, 15 Jan 2021 02:06:49 -0800 (PST) X-Google-Smtp-Source: ABdhPJxXwI47/0IWIfNFEB3a8Kr7nPYfGDKBcOzVshpMBxigzmBfmst/qooFY0SrMBX9pF+Cfhtz X-Received: by 2002:a17:906:c793:: with SMTP id cw19mr8066032ejb.246.1610705209538; Fri, 15 Jan 2021 02:06:49 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1610705209; cv=none; d=google.com; s=arc-20160816; b=n7Bmd0l+lMxgq33MNinIkEDk7vC3u54jaxi+4q+D5jXlA+UoRin1t/XIA4n87IXMGk P8isLPP8Wly3WJ1Rz2h/EFcrpQmwlnfTZypXATl63VHwYSPFtLH92N5/ifso/6V+67B9 7IiAqZCU8spcXZJcY2uBEEo2bFRER32MKrU7PMZcRcn5Qzqhv3ZBBMha1VCL6GMdO9rk tkETgcPIh9VVGeGYDZ50XjVuYh62a0IqYREJw3XID2xWPTFCbUf/H2tQqm/eL0n/U1dQ OzZHqIyntHxZGvzMRkJ6nJI7hbim6jdtEeI5tz7jG3anVOIemPZ8joejFEteJNf4Dyul GxMg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:message-id:date:subject:cc:to:from; bh=Z78ickFe/+b46lSLUZvpf0FopGvFo74pMdUXwKlpLI0=; b=bRHeqwBmGdSyozwKd3bBM2X7cLdJ4LuEp4/7HpxbxVzZWEyeUj42QCQy5/tXIenMWv Jab46jO5dHDLtQA7sUk6POxJZ+MOMmc56nsw+SrxBkFBJCtUtF5Mv4dQpA86+fHacGuE 3LrrtmC6PgrjmiHJNMxLGYH0efR3qImmT0My26xuG/vohPFkxZ26ndQ92y+IvQRO6F/8 8/aJJ98ZjsSS8XnX6yf5Ihi/+IODeS1UjkRGQRJSYBk9KDGD1a6WLNlqwOtL/5GSg3Cm cLVuPJzF42Knx/uoIK76qjh5xjwYarhpGmAzDVr38jTDRLrEBPn/eRiddWALM/OxeD5Q yghw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=alibaba.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id qk3si3639026ejb.83.2021.01.15.02.06.24; Fri, 15 Jan 2021 02:06:49 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=alibaba.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729959AbhAOKE6 (ORCPT + 99 others); Fri, 15 Jan 2021 05:04:58 -0500 Received: from out30-56.freemail.mail.aliyun.com ([115.124.30.56]:43589 "EHLO out30-56.freemail.mail.aliyun.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726918AbhAOKE5 (ORCPT ); Fri, 15 Jan 2021 05:04:57 -0500 X-Alimail-AntiSpam: AC=PASS;BC=-1|-1;BR=01201311R351e4;CH=green;DM=||false|;DS=||;FP=0|-1|-1|-1|0|-1|-1|-1;HT=e01e04423;MF=abaci-bugfix@linux.alibaba.com;NM=1;PH=DS;RN=4;SR=0;TI=SMTPD_---0ULo5zww_1610705034; Received: from j63c13417.sqa.eu95.tbsite.net(mailfrom:abaci-bugfix@linux.alibaba.com fp:SMTPD_---0ULo5zww_1610705034) by smtp.aliyun-inc.com(127.0.0.1); Fri, 15 Jan 2021 18:03:59 +0800 From: Jiapeng Zhong To: gregkh@linuxfoundation.org Cc: jirislaby@kernel.org, linux-kernel@vger.kernel.org, Jiapeng Zhong Subject: [PATCH] drivers/tty: Use bitwise instead of arithmetic operator for flags Date: Fri, 15 Jan 2021 18:03:51 +0800 Message-Id: <1610705031-20332-1-git-send-email-abaci-bugfix@linux.alibaba.com> X-Mailer: git-send-email 1.8.3.1 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Fix the following coccicheck warning: ./drivers/tty/synclink_gt.c:4384:15-16: WARNING: sum of probable bitmasks, consider | ./drivers/tty/synclink_gt.c:4342:39-40: WARNING: sum of probable bitmasks, consider | ./drivers/tty/synclink_gt.c:4280:48-49: WARNING: sum of probable bitmasks, consider | ./drivers/tty/synclink_gt.c:2221:20-21: WARNING: sum of probable bitmasks, consider | Reported-by: Abaci Robot Signed-off-by: Jiapeng Zhong --- drivers/tty/synclink_gt.c | 12 ++++++++---- 1 file changed, 8 insertions(+), 4 deletions(-) diff --git a/drivers/tty/synclink_gt.c b/drivers/tty/synclink_gt.c index c0b384e..d302c08 100644 --- a/drivers/tty/synclink_gt.c +++ b/drivers/tty/synclink_gt.c @@ -2219,7 +2219,7 @@ static void isr_tdma(struct slgt_info *info) */ wr_reg32(info, TDCSR, status); /* clear pending */ - if (status & (BIT5 + BIT4 + BIT3)) { + if (status & (BIT5 | BIT4 | BIT3)) { // another transmit buffer has completed // run bottom half to get more send data from user info->pending_bh |= BH_TRANSMIT; @@ -4265,7 +4265,9 @@ static void sync_mode(struct slgt_info *info) case MGSL_MODE_XSYNC: val |= BIT15 + BIT13; break; - case MGSL_MODE_MONOSYNC: val |= BIT14 + BIT13; break; + case MGSL_MODE_MONOSYNC: + val |= BIT14 | BIT13; + break; case MGSL_MODE_BISYNC: val |= BIT15; break; case MGSL_MODE_RAW: val |= BIT13; break; } @@ -4278,7 +4280,9 @@ static void sync_mode(struct slgt_info *info) case HDLC_ENCODING_NRZI_MARK: val |= BIT11; break; case HDLC_ENCODING_NRZI: val |= BIT11 + BIT10; break; case HDLC_ENCODING_BIPHASE_MARK: val |= BIT12; break; - case HDLC_ENCODING_BIPHASE_SPACE: val |= BIT12 + BIT10; break; + case HDLC_ENCODING_BIPHASE_SPACE: + val |= BIT12 | BIT10; + break; case HDLC_ENCODING_BIPHASE_LEVEL: val |= BIT12 + BIT11; break; case HDLC_ENCODING_DIFF_BIPHASE_LEVEL: val |= BIT12 + BIT11 + BIT10; break; } @@ -4382,7 +4386,7 @@ static void sync_mode(struct slgt_info *info) // reference clock, so take TxC from BRG/16 to get // transmit clock at actual data rate if (info->params.flags & HDLC_FLAG_RXC_DPLL) - val |= BIT6 + BIT5; /* 011, txclk = BRG/16 */ + val |= BIT6 | BIT5; /* 011, txclk = BRG/16 */ else val |= BIT6; /* 010, txclk = BRG */ } -- 1.8.3.1