Received: by 2002:a05:6a10:2785:0:0:0:0 with SMTP id ia5csp249127pxb; Fri, 15 Jan 2021 02:12:41 -0800 (PST) X-Google-Smtp-Source: ABdhPJzvx6ja1tsjffdcnWh3Q3eLkMIgoqklRJlCyds8XavI03OpTRge1S8dLtu9gnLKRlEzkYnu X-Received: by 2002:aa7:c886:: with SMTP id p6mr9031962eds.207.1610705561495; Fri, 15 Jan 2021 02:12:41 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1610705561; cv=none; d=google.com; s=arc-20160816; b=cJGSEwx0bRGUND2sdNTNEF26D0tDaU9gWU9XuovKyuDZFlRy/YwIhSzQuNh8T+4gD7 sbutXNNMDZzPwBSdjuN1JIqD7vop87A/wkcjz0tpQHEOJi7zg9fVT4Bf4PpkEPwtzrX4 RXIZzT1Qhe3mMHcS3Ptnv1S9bAwQVO6AVMfkxfoGA5CMKcKzvkPpTw1uIDpJ1Zjkc2kA EvVKHUYjviaSbe7A1kwQEWYf26YsLE2l1fvN3gfu22M1LygdimTHDaZwxHZxC+l/tY6w PYG2o149M9iJFKiJrZ95Tb3VwvHTUYZb/MM6FUJsQ6g9JHT8g0j/W1wsgfDyV4oxHxTc Rl+Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:message-id:date:subject:cc:to:from; bh=eGd97WZA5kdrQdQQvMRFi3f9mNkO4zSOchVRsqANbNc=; b=p8Sd/TWr4UooPnWH0/qXJlN4j1dWsWLDJzr8hAJ4h/Sw0VK5LD5vHpf8Z7Mud964zE ixAkEaTkYMh31jFpf7ktuLgb+qBhWY2hhoiMVmNWZaUgyzQI+gb4IDrTXK/y16rD1XiO IFQchORIzoNMvYhtpcpQlTA0Mgvic1i+mc0BnDHewHtxMUCvb9MUiz4LQZUIdbHNq4jB 5c1syYreAB+UEJCChcU8HhwhUW17uJXH4krIdRdEObRC2pvIAz4wpaY/PtoaQX9e5ZvJ cHmK4rcmPr6FOs0LRMTO7xqvywK+jTaOcG+u6mtgKN3pPhiP2/EKpcLnqZr2cY44Xa0A mJaQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=alibaba.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id p24si3869060edw.475.2021.01.15.02.12.14; Fri, 15 Jan 2021 02:12:41 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=alibaba.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731332AbhAOKKF (ORCPT + 99 others); Fri, 15 Jan 2021 05:10:05 -0500 Received: from out30-56.freemail.mail.aliyun.com ([115.124.30.56]:54795 "EHLO out30-56.freemail.mail.aliyun.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728287AbhAOKKD (ORCPT ); Fri, 15 Jan 2021 05:10:03 -0500 X-Alimail-AntiSpam: AC=PASS;BC=-1|-1;BR=01201311R191e4;CH=green;DM=||false|;DS=||;FP=0|-1|-1|-1|0|-1|-1|-1;HT=e01e04420;MF=abaci-bugfix@linux.alibaba.com;NM=1;PH=DS;RN=8;SR=0;TI=SMTPD_---0ULo2FI1_1610705350; Received: from j63c13417.sqa.eu95.tbsite.net(mailfrom:abaci-bugfix@linux.alibaba.com fp:SMTPD_---0ULo2FI1_1610705350) by smtp.aliyun-inc.com(127.0.0.1); Fri, 15 Jan 2021 18:09:14 +0800 From: Jiapeng Zhong To: rjui@broadcom.com Cc: sbranden@broadcom.com, bcm-kernel-feedback-list@broadcom.com, linus.walleij@linaro.org, linux-arm-kernel@lists.infradead.org, linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, Jiapeng Zhong Subject: [PATCH] drivers/pinctrl/bcm: Simplify bool comparison Date: Fri, 15 Jan 2021 18:09:09 +0800 Message-Id: <1610705349-24310-1-git-send-email-abaci-bugfix@linux.alibaba.com> X-Mailer: git-send-email 1.8.3.1 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Fix the follow coccicheck warnings: ./drivers/pinctrl/bcm/pinctrl-ns2-mux.c:856:29-38: WARNING: Comparison to bool. Reported-by: Abaci Robot Signed-off-by: Jiapeng Zhong --- drivers/pinctrl/bcm/pinctrl-ns2-mux.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/pinctrl/bcm/pinctrl-ns2-mux.c b/drivers/pinctrl/bcm/pinctrl-ns2-mux.c index 57044ab..0fe4a1f 100644 --- a/drivers/pinctrl/bcm/pinctrl-ns2-mux.c +++ b/drivers/pinctrl/bcm/pinctrl-ns2-mux.c @@ -853,7 +853,7 @@ static int ns2_pin_config_get(struct pinctrl_dev *pctldev, unsigned int pin, switch (param) { case PIN_CONFIG_BIAS_DISABLE: ns2_pin_get_pull(pctldev, pin, &pull_up, &pull_down); - if ((pull_up == false) && (pull_down == false)) + if (!pull_up && !pull_down) return 0; else return -EINVAL; -- 1.8.3.1