Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1030433AbWILUv0 (ORCPT ); Tue, 12 Sep 2006 16:51:26 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1030434AbWILUv0 (ORCPT ); Tue, 12 Sep 2006 16:51:26 -0400 Received: from waste.org ([66.93.16.53]:25577 "EHLO waste.org") by vger.kernel.org with ESMTP id S1030433AbWILUvZ (ORCPT ); Tue, 12 Sep 2006 16:51:25 -0400 Date: Tue, 12 Sep 2006 15:49:52 -0500 From: Matt Mackall To: David Howells Cc: Aubrey , Nick Piggin , linux-kernel@vger.kernel.org, davidm@snapgear.com, gerg@snapgear.com Subject: Re: kernel BUGs when removing largish files with the SLOB allocator Message-ID: <20060912204952.GE19707@waste.org> References: <20060912174339.GA19707@waste.org> <6d6a94c50609032356t47950e40lbf77f15136e67bc5@mail.gmail.com> <17162.1157365295@warthog.cambridge.redhat.com> <6d6a94c50609042052n4c1803eey4f4412f6153c4a2b@mail.gmail.com> <3551.1157448903@warthog.cambridge.redhat.com> <6d6a94c50609051935m607f976j942263dd1ac9c4fb@mail.gmail.com> <44FE4222.3080106@yahoo.com.au> <6d6a94c50609120107w1942a8d8j368dd57a271d0250@mail.gmail.com> <24525.1158089104@warthog.cambridge.redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <24525.1158089104@warthog.cambridge.redhat.com> User-Agent: Mutt/1.5.9i Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 993 Lines: 22 On Tue, Sep 12, 2006 at 08:25:04PM +0100, David Howells wrote: > Matt Mackall wrote: > > > Looking through all the users of kobjsize, it seems we always know > > what the type is (and it's usually a VMA). I instead propose we use > > ksize on objects we know to be SLAB/SLOB-allocated and add a new > > function (kpagesize?) to size other objects where nommu needs it. > > It sounds like we'd need an op in the VMA to do the per-type size thing (the > VMA itself not the VMA ops table). On looking closer, one place where both the current code and my proposed change are wrong are measurements on the init task, where many elements of task_struct are statically allocated. -- Mathematics is the supreme nostalgia of our time. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/