Received: by 2002:a05:6a10:2785:0:0:0:0 with SMTP id ia5csp294425pxb; Fri, 15 Jan 2021 03:32:59 -0800 (PST) X-Google-Smtp-Source: ABdhPJwCTMLof5Jsi1AUgj6gQTZSXQIdP3bXpraHF/Qtm5pujuPeQ50GUdy/6UVmCLZ9PccvZtyi X-Received: by 2002:a50:d491:: with SMTP id s17mr9062447edi.169.1610710379195; Fri, 15 Jan 2021 03:32:59 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1610710379; cv=none; d=google.com; s=arc-20160816; b=uWFMUUuEPBhnEQRggIiD6Tn0Lg+76/N9cDq46eZAE6iZgd1PKW48rPqDdilOCdbXvX mNF5Gc784u5IYSUaO+ms2IXMjF/czxBTDlcCTsnXw5rSYpC+NIXMr2giRkFl2sVZvBwB v+X1yn9lN0alCJnqp9hT6xvamZTPigq8EemMoQFusrjrTVKIItCrFoGdxK6JJJyPohPk oalc48GwjK+wgQ/Fac0EbuRUosOKSNUnneszz9QreXUiv4Fkb1qG5eHjPN6/aTxuaK7W fxDbnB4VZ1vmKYIUMI5vpRb08RlCo9sFVx9rWbBXrgePlspbXkC5E02HmaZwKUW8AbH8 w6yQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=4FnXQPdB7XkD25XWGkZfjD7tnnHBnBRZzLYJB35qua8=; b=gxQg3XP2k0pUr7wpGk3UfEvqI0H8kR0oWoPHXlrawbZvMYEGGIZ0AXw4cezH4JErEZ FPn6y8wD8zOS8MJ+LF+t6Cv6Dx8WvXNreGZNRcxiS3snAgqPexDD5zvzgmvE46+hMVr5 pkx9yLyppQt2Twz6s1t1mLaNMwGs50pynB+Gk0N3piSMgbwyOYD7EJzQy+MABsDySI/7 fUxOKxKUEQDT2/E4HA0B1LcX7JnvZm2ee77ahJiRztTG9ADlNeTC9dVKCJKendiQh5JL npM/h0Q9RmgKUCm6gHvWz+GVNJkObJyot4LXEy71Lkq6OcXlEDayjcgI2h85fsYYJ79c Rmng== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@suse.com header.s=susede1 header.b=h2w+xeXR; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=NONE dis=NONE) header.from=suse.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id p17si4073859ejd.679.2021.01.15.03.32.34; Fri, 15 Jan 2021 03:32:59 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@suse.com header.s=susede1 header.b=h2w+xeXR; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=NONE dis=NONE) header.from=suse.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726280AbhAOLbG (ORCPT + 99 others); Fri, 15 Jan 2021 06:31:06 -0500 Received: from mx2.suse.de ([195.135.220.15]:33982 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725946AbhAOLbG (ORCPT ); Fri, 15 Jan 2021 06:31:06 -0500 X-Virus-Scanned: by amavisd-new at test-mx.suse.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1610710219; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=4FnXQPdB7XkD25XWGkZfjD7tnnHBnBRZzLYJB35qua8=; b=h2w+xeXR3pig4Ms0UCND1/JD594nxWlHhzN5JklZQK1RbofB0kguxnsZKpziDgRdAs5LWU n8Jb6TUtlNWBpIQTsNRIuZHuEcIaDI/Nydo81FUF9OsijNYYljfTyQt8mLGkKqcH18JWW/ Vw9yBVKoLE9M6oZE9PWU6eLeraouTZk= Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id D0EBFACB0; Fri, 15 Jan 2021 11:30:19 +0000 (UTC) Date: Fri, 15 Jan 2021 12:30:19 +0100 From: Petr Mladek To: John Ogness Cc: Sergey Senozhatsky , Sergey Senozhatsky , Steven Rostedt , linux-kernel@vger.kernel.org Subject: Re: [PATCH] printk: ringbuffer: fix line counting Message-ID: References: <20210113144234.6545-1-john.ogness@linutronix.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210113144234.6545-1-john.ogness@linutronix.de> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed 2021-01-13 15:48:34, John Ogness wrote: > Counting text lines in a record simply involves counting the number > of newline characters (+1). However, it is searching the full data > block for newline characters, even though the text data can be (and > often is) a subset of that area. Since the extra area in the data > block was never initialized, the result is that extra newlines may > be seen and counted. > > Restrict newline searching to the text data length. > > Fixes: b6cf8b3f3312 ("printk: add lockless ringbuffer") > Signed-off-by: John Ogness The patch is committed in printk/linux.git, branch printk-rework. I plan to send it for-5.11 the following week after it spends few days in linux-next. Best Regards, Petr