Received: by 2002:a05:6a10:2785:0:0:0:0 with SMTP id ia5csp294703pxb; Fri, 15 Jan 2021 03:33:25 -0800 (PST) X-Google-Smtp-Source: ABdhPJzbYSuLRVQqZggd5oP1FWCsJYGce/0mtfTqliocTYao25XVlETi0Etcft3Xxlr9PYCFLwvz X-Received: by 2002:a50:d888:: with SMTP id p8mr9324585edj.147.1610710404909; Fri, 15 Jan 2021 03:33:24 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1610710404; cv=none; d=google.com; s=arc-20160816; b=Rsbx9LKZZAQHFpJbvC9hNlwopnom8Ch3BulDSqS24IyrqYojCWQSY9yZNzULhXsqVR APoCOuq3Oa3qYfcxyqL9lfcoF+R4IUoCrpD9sCcExRdBNOdXp7O9MJ9iNtJ32tV8yafe fYBqVlUlsKBXY3IDKa+Des/hBo7a86L5AS2Gfm2mhkec8D4PaovdmoLA7Rziu1OWUd9q xWTrWZjI8IyQnHlbEN0gGiM1fZ3ne999/1rl0K5QqrUWXS3l3XGcxHE8yzZXJwwcl9AH syp41nyMXKt1ewlRY62Wq5wogKhxUFrUVn8mUorKQp/1N4klsHssFmAbxp34XLBmI/kN nWJA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=3GHz8S+62EVlouf3aCzWVck64PnR00Hq4PvSyTaWKW8=; b=axIDVmE7YnwgaxyyE9spGsSYMOiJoR6fpGsFgV6VEfivhVtgyrS9UTmk3RJ8N8osDg N2XBdDuYc/zNEPAo773xXW/8P8ihnjgqzeWqCIL0AZ7P5Ywi8Ts4rgkLKMs6VNur5vEz OLtjHBJwyb7p5kbmQ/mipyPvtIrslMlJAzJMAR0Pg/+FCPsdUtUWVtFVB3/TyISHHbmX NyoBoCEMYH+qyFQ8lSFxgaZVC0kSXDdkZUYq6C2RmKVGYuVDnEQ/AO6Vw0+HmC3cVWVN 7RGG++tzOoQUoEcJpk5amRC/YiQZQKwWLRBsz78UJvsj1/0HEg5UQJN+xhgp4gf8cukD K6uA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@suse.com header.s=susede1 header.b=n26BaUW3; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=NONE dis=NONE) header.from=suse.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id d13si3504340ejz.583.2021.01.15.03.33.01; Fri, 15 Jan 2021 03:33:24 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@suse.com header.s=susede1 header.b=n26BaUW3; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=NONE dis=NONE) header.from=suse.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727670AbhAOLbs (ORCPT + 99 others); Fri, 15 Jan 2021 06:31:48 -0500 Received: from mx2.suse.de ([195.135.220.15]:34474 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726030AbhAOLbs (ORCPT ); Fri, 15 Jan 2021 06:31:48 -0500 X-Virus-Scanned: by amavisd-new at test-mx.suse.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1610710261; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=3GHz8S+62EVlouf3aCzWVck64PnR00Hq4PvSyTaWKW8=; b=n26BaUW3wpEbyCAcOmUAJLIHtBqYO1mLmPuRM387wc9pLOC1ebtXfeNwSTFuRHas/AkOxh e+RFHz4+nticbLh7EuygbHmmwzxK2KoqIqxCSb+jk5LCVvNVTfSZZb5YYJ9u86LxH6JqHT m6tr3Nu/9k26Uzx6SoUMhk2cPhxK4i0= Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 72544B80E; Fri, 15 Jan 2021 11:31:01 +0000 (UTC) Date: Fri, 15 Jan 2021 12:31:00 +0100 From: Petr Mladek To: John Ogness Cc: Sergey Senozhatsky , Sergey Senozhatsky , Steven Rostedt , linux-kernel@vger.kernel.org Subject: Re: [PATCH] printk: fix kmsg_dump_get_buffer length calulations Message-ID: References: <20210113164413.1599-1-john.ogness@linutronix.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210113164413.1599-1-john.ogness@linutronix.de> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed 2021-01-13 17:50:13, John Ogness wrote: > kmsg_dump_get_buffer() uses @syslog to determine if the syslog > prefix should be written to the buffer. However, when calculating > the maximum number of records that can fit into the buffer, it > always counts the bytes from the syslog prefix. > > Use @syslog when calculating the maximum number of records that can > fit into the buffer. > > Fixes: e2ae715d66bf ("kmsg - kmsg_dump() use iterator to receive log buffer content") > Signed-off-by: John Ogness The patch is committed in printk/linux.git, branch printk-rework. I plan to send it for-5.11 the following week after it spends few days in linux-next. Best Regards, Petr