Received: by 2002:a05:6a10:2785:0:0:0:0 with SMTP id ia5csp19134pxb; Fri, 15 Jan 2021 04:51:05 -0800 (PST) X-Google-Smtp-Source: ABdhPJznQAoGuGTB9i4cXqkSvxbooRBCIgsk3zA852/9sErRJuDyXZshB3iBpMlX1AVEYcNtkW/r X-Received: by 2002:a05:6402:8d9:: with SMTP id d25mr9271127edz.278.1610715065350; Fri, 15 Jan 2021 04:51:05 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1610715065; cv=none; d=google.com; s=arc-20160816; b=zTVz2D4g2EkasY0Vp0f8GbW/6p2Wi2b4P63RTV+AAG+zrPHMO6P/2BByoW/Ni6McDf DZa4b8XlGIQNY1Tr2enhVhLiKjgma1cl+MprCscprdWS6Bk5VO6GDKcTyEQMZyy050fy XMEvFg/Qc7Ull6CrKJz7ZUaLk9FHO+89QwDWymhPue+96jAVSrgthTt2729i8F1HEBgE tsfLAutABNwVKei3GaiABQMDDQLp77ApnZIY2FOU+C+ZO0BCYdriVL0gXWYH1eHJhIKR UEuV4d954z40msk0ce/HOVtW9gGfqZCdQnzU7s1V+bDjA4nPNtnvEznc/8sWE4EhK0lW QH9g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=x3K4NjQB8eJVbTys7KXlOfnK/yRFWsJ9Xi5d40KGVig=; b=GVb78FfFoczUl9SILfw0UYEd2VTHo8BQReFxZWQC4QUav/zJRENQ5BGlT8SJlYhgb0 4Y8wY7kJ9PI2PVCmvdK+k9AtZFlz2Ip5d68uwAvrgdTCb2hg9lL3Jh0jEVlpgx66Ic9K 4HLWe2XURb4LXcfbYvmJhphtGyrVr0J2Z8QI+TnROHIaTRE7sm3fRfEPoB7O5Y/5nM01 4H33T7s5Vu9YzV3VyKs91GrGP/785/Jm6W549GUx1ZAVRHXvBEt3ydqHhJNL5s+xhqFR 1yrpfMXryWkpW12NKdwCxzs6pMVJomsTmsFAC/hkzw8QNep8Poc/m5tYmGwHwibxPnCn EV5A== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=Ea1OJxUe; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id t2si3693193ejd.302.2021.01.15.04.50.41; Fri, 15 Jan 2021 04:51:05 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=Ea1OJxUe; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2387931AbhAOMsI (ORCPT + 99 others); Fri, 15 Jan 2021 07:48:08 -0500 Received: from mail.kernel.org ([198.145.29.99]:44176 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2387942AbhAOMhP (ORCPT ); Fri, 15 Jan 2021 07:37:15 -0500 Received: by mail.kernel.org (Postfix) with ESMTPSA id B995C235F8; Fri, 15 Jan 2021 12:36:59 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1610714220; bh=VXfr5805xyGmQOvw+YcKrnEABHAuuI+9TLsjuAboq+M=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=Ea1OJxUe6DXofU4EbJEkVMr++dngW+KpyFcGXi58rI6jYfRgMQKlefH61L5/5cVAh UyoJOa8I4dAoEvhbvtre66sYdCUcvivNbK8bCsT7Qm/ro0xr6PsAEMuG3vG/3ATKS2 C3iRUenhEXGqezvbvK8Co99m/5S9FQaryUq1kxs8= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Rohit Maheshwari , Ayush Sawal , Jakub Kicinski Subject: [PATCH 5.10 030/103] chtls: Remove invalid set_tcb call Date: Fri, 15 Jan 2021 13:27:23 +0100 Message-Id: <20210115122007.517258260@linuxfoundation.org> X-Mailer: git-send-email 2.30.0 In-Reply-To: <20210115122006.047132306@linuxfoundation.org> References: <20210115122006.047132306@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Ayush Sawal [ Upstream commit 827d329105bfde6701f0077e34a09c4a86e27145 ] At the time of SYN_RECV, connection information is not initialized at FW, updating tcb flag over uninitialized connection causes adapter crash. We don't need to update the flag during SYN_RECV state, so avoid this. Fixes: cc35c88ae4db ("crypto : chtls - CPL handler definition") Signed-off-by: Rohit Maheshwari Signed-off-by: Ayush Sawal Signed-off-by: Jakub Kicinski Signed-off-by: Greg Kroah-Hartman --- drivers/net/ethernet/chelsio/inline_crypto/chtls/chtls_cm.c | 3 --- 1 file changed, 3 deletions(-) --- a/drivers/net/ethernet/chelsio/inline_crypto/chtls/chtls_cm.c +++ b/drivers/net/ethernet/chelsio/inline_crypto/chtls/chtls_cm.c @@ -2095,9 +2095,6 @@ static void chtls_abort_req_rss(struct s int queue = csk->txq_idx; if (is_neg_adv(req->status)) { - if (sk->sk_state == TCP_SYN_RECV) - chtls_set_tcb_tflag(sk, 0, 0); - kfree_skb(skb); return; }