Received: by 2002:a05:6a10:2785:0:0:0:0 with SMTP id ia5csp27616pxb; Fri, 15 Jan 2021 05:04:34 -0800 (PST) X-Google-Smtp-Source: ABdhPJykkq6YSqDO1v74FdyuBd7gr2GEY9ztaCQo1lhCtAJ007bNmUPd9UHVHDBLBInv/rDysjQk X-Received: by 2002:a50:fc13:: with SMTP id i19mr9860368edr.281.1610715873811; Fri, 15 Jan 2021 05:04:33 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1610715873; cv=none; d=google.com; s=arc-20160816; b=KvTmwOFPRtCQ6jfPrqhhJd5rkFTRTAx9nKOdkqCnYHp5y5xZhtic6qM0PWfO0X9HGJ 1LJq1fkJ/R3CDQeVjjc2wnMt7aqw5e5+zX6YznPXsHTbGsh/rGTDD8bhOgKkRLi4jAjO JCAMg1g65fb+XhrPWZa4eNQhbYGoEODJeBP0y3NjZOUQzCrnixm4geJQYb7UqwvRGW+z Tcica5Ns0rDcE7b5C0k9rOjldLlWe8Q544sqhgFcdHXGGLPij4starpKlaIU2VJlgWBn LbD3+YZIXFNn6wCo5BszvG+aQcZjADcVNhSyIuG5obllZ3tJwF9TNIMUDXrEMsw7VEoN Nn1g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=1EZPVQhMtwoZmI2ck5K0WFuhVyoTDBbmZOtVdxUkJSI=; b=UGtgY8fxO5Z7c06gdDhxWGzuBxqQVTorTTJKcCOynUoR4/P8edC7x8tYBNG64JCFKj kOtnJTFCjdV+0aFgSdXOS+wgbDbJSQCshBBOSWFqmktaUIIU7ztye27RrcwZhSSZokes xL/zblXouQW4P8Ok6dvcAXDW17qan3EPRBTU86kvUEkRSBe1DulA/lUQeXnhJNl4p9ja puo0OALemr2In0IBWJRxw7I5fhz0CwBGjDcmuI3xbJXNThbALXrezxXcOhsDNQKAsO+0 BCYhHwHTH86+gEzg5ngVI6rJcGQOCeuu/mfMyVVabD2LCFntisg2oXRiwjHDpMDw57la e8kA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=tuUGnXHi; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id n7si3754876ejx.635.2021.01.15.05.03.58; Fri, 15 Jan 2021 05:04:33 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=tuUGnXHi; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731510AbhAOMc0 (ORCPT + 99 others); Fri, 15 Jan 2021 07:32:26 -0500 Received: from mail.kernel.org ([198.145.29.99]:36412 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730645AbhAOMcU (ORCPT ); Fri, 15 Jan 2021 07:32:20 -0500 Received: by mail.kernel.org (Postfix) with ESMTPSA id B63A122473; Fri, 15 Jan 2021 12:32:04 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1610713925; bh=nphR8ps349+6qq1hFvi2YirUHYDDjl5TVoBuquO7hkg=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=tuUGnXHixpr/G84rzDMkx2IVj6khhNYth/7cZycou3tDbADeJXG4ZphZ/pQfPJFFF Pl7Sjg4Hdyty4v9/S+7dlp5dPLecgm2D+Zgshva8ia4N3OyG2nzcGN0Y7WdfHWm4Ms rJ+fC5v/hrUPmBMjAT9yGva1lQApoIQaXUnVim6k= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Rohit Maheshwari , Ayush Sawal , Jakub Kicinski Subject: [PATCH 4.19 11/43] chtls: Remove invalid set_tcb call Date: Fri, 15 Jan 2021 13:27:41 +0100 Message-Id: <20210115121957.588707738@linuxfoundation.org> X-Mailer: git-send-email 2.30.0 In-Reply-To: <20210115121957.037407908@linuxfoundation.org> References: <20210115121957.037407908@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Ayush Sawal [ Upstream commit 827d329105bfde6701f0077e34a09c4a86e27145 ] At the time of SYN_RECV, connection information is not initialized at FW, updating tcb flag over uninitialized connection causes adapter crash. We don't need to update the flag during SYN_RECV state, so avoid this. Fixes: cc35c88ae4db ("crypto : chtls - CPL handler definition") Signed-off-by: Rohit Maheshwari Signed-off-by: Ayush Sawal Signed-off-by: Jakub Kicinski Signed-off-by: Greg Kroah-Hartman --- drivers/crypto/chelsio/chtls/chtls_cm.c | 3 --- 1 file changed, 3 deletions(-) --- a/drivers/crypto/chelsio/chtls/chtls_cm.c +++ b/drivers/crypto/chelsio/chtls/chtls_cm.c @@ -1920,9 +1920,6 @@ static void chtls_abort_req_rss(struct s int queue = csk->txq_idx; if (is_neg_adv(req->status)) { - if (sk->sk_state == TCP_SYN_RECV) - chtls_set_tcb_tflag(sk, 0, 0); - kfree_skb(skb); return; }