Received: by 2002:a05:6a10:8c0a:0:0:0:0 with SMTP id go10csp186292pxb; Fri, 15 Jan 2021 10:22:05 -0800 (PST) X-Google-Smtp-Source: ABdhPJy9/cXc7NPGILLeEQHSQ81ENTP6bpPnSEFIqhLXhlmsgXd58mJOezuFtkVYyuGhsqX7nBMB X-Received: by 2002:a17:906:b243:: with SMTP id ce3mr6346857ejb.489.1610734925290; Fri, 15 Jan 2021 10:22:05 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1610734925; cv=none; d=google.com; s=arc-20160816; b=QDmNWUu/6gGu7+wvF3kX6ymDQPpQIhHgaeAIfpLpDblWUchSC3G4XN3ftmWmsSJkjO qUArINolTaTIGWVr5y8DkzUbAgX1HUxwXHjeJnl/pZeMANXVrXh2YYbjENPXIH4vSlLE C4Au1Lor+ZEAv0i1EWs05zN2zfYrNu4q03XWu4YUCFcREbSeuVkTAe/upz38NPl7aZdS o8soS3G+KBsRhdsQjDaMsFE12n9s3Nrpo6QRL6uH3pm1jO723xtIQpV1H+cvJ8eoVizI we/yRLy8Et6D25G+L8cA2qKMkve8o3HVuHX3ah6Wx4/UNgjqPDE+/tZnIPr89wSevPdB aMOQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=GmnTQYGZFT8V4aHtRElOATkEuVPQEpEkCVYessHQgb4=; b=U7LkM1ZhKxypVD55eCDXHg2UVkUfGTjywY1RDMdoI056347UW9YGGDJDieuoB76+qY E0BrZDjRojOFVgpca7IjZn2gKXpB6f1j8j4E/dJ3RdJby8L8ivif9oAOlxKZFN4j/Ce/ VR8YejfGNRBJTfvoaBMIRYvlrNdNayfhRrsIKD/ZA1wG4qD53oMe2RIay094LXcBxqS/ LT+xTe6j7pbOwVzyxPkrPn+ANqzD45drcEr8SKHAlffjcKSPVW8R/H+08FMRNTYqr3E4 pp18MzXztoO86DQbaeHWy77g5QK5mMr1u90r8Pu2kQoue9NAt3UsTj7JYkIiZz4XP8to OHUg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=ao9i4vgD; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id r17si332393ejj.390.2021.01.15.10.21.41; Fri, 15 Jan 2021 10:22:05 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=ao9i4vgD; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2388159AbhAOSTg (ORCPT + 99 others); Fri, 15 Jan 2021 13:19:36 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57168 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2388358AbhAOSR1 (ORCPT ); Fri, 15 Jan 2021 13:17:27 -0500 Received: from mail-wr1-x430.google.com (mail-wr1-x430.google.com [IPv6:2a00:1450:4864:20::430]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 14487C06179B for ; Fri, 15 Jan 2021 10:16:16 -0800 (PST) Received: by mail-wr1-x430.google.com with SMTP id 6so2911319wri.3 for ; Fri, 15 Jan 2021 10:16:16 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=GmnTQYGZFT8V4aHtRElOATkEuVPQEpEkCVYessHQgb4=; b=ao9i4vgDHHQIUekQ87MHFQREuE2D0YpI1oA3cL0opjewp4Err83XY74KoQW+PUQcRb 5/OpZ0hdYs3gjXlaP4yjSWRMs8fpNjQkP5N5s+0qHuSdnNtrQNkslDD5dTRBpdk81T82 4WPof4xIye7KPIpjykKw+as/Cvbr9v1Rl35atrE3W11DRTGEVwpo/EwHgUrj5ekuqI7L UUn7enAqQxpHwWjStPF8uo8DaTyvkZ9pdHdvzPePM1Q8OkvY0mpwg96l4+z6Iw6+1tC0 bxLNZbk/UNcrrkbxvO9Xtzv6XjYJ/EbZQr8gLmniTqceS+jGGfITIBLFZYamuuJSqY2e Qc5w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=GmnTQYGZFT8V4aHtRElOATkEuVPQEpEkCVYessHQgb4=; b=VZ2gFM1s2oqBiW55bJLdRH6lV9nUAWhjwxWgOjLtfmMoeVhyQYdS8l+0EV8VyTqYCv VG3bUUjEkXR9kefbPmmBXj6suChZ2YKCq9rfiPH8GvF4dU2H9tYqdWDNMvN/0fs3pbFe ctBK5RtlvcpolC9XV4W9U4A1zN78FFP3nShB9D6fUNUxlC5N1flISmRmBkjUUHkQiYLz VdJTp5/gXKrU562Er0ZJHj6iUN/bBZD5bA2rUx+isHKSGLDxR7TSUdzYT9uhTYkvoGv4 eBYeuPI0BkkHo/mloeC/Z6aD9SR0K0op/QvaL7SQb/l4D+e2NSQLau7B5yAADkiiB+dn DhLA== X-Gm-Message-State: AOAM5338A3PbsYbOvBClyzObpnDJWePAUt56xw3hwKfqB8OHmfRGulrq mtHCCoSq9mEMqcVDkjO6L6SgBQ== X-Received: by 2002:adf:92a4:: with SMTP id 33mr14241917wrn.347.1610734574855; Fri, 15 Jan 2021 10:16:14 -0800 (PST) Received: from dell.default ([91.110.221.158]) by smtp.gmail.com with ESMTPSA id b133sm14405979wme.33.2021.01.15.10.16.13 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 15 Jan 2021 10:16:14 -0800 (PST) From: Lee Jones To: lee.jones@linaro.org Cc: linux-kernel@vger.kernel.org, Patrik Jakobsson , David Airlie , Daniel Vetter , dri-devel@lists.freedesktop.org Subject: [PATCH 06/29] drm/gma500/mmu: Actually return an error if one occurs Date: Fri, 15 Jan 2021 18:15:38 +0000 Message-Id: <20210115181601.3432599-7-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20210115181601.3432599-1-lee.jones@linaro.org> References: <20210115181601.3432599-1-lee.jones@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Fixes the following W=1 kernel build warning(s): drivers/gpu/drm/gma500/mmu.c: In function ‘psb_mmu_insert_pfn_sequence’: drivers/gpu/drm/gma500/mmu.c:651:6: warning: variable ‘ret’ set but not used [-Wunused-but-set-variable] Cc: Patrik Jakobsson Cc: David Airlie Cc: Daniel Vetter Cc: dri-devel@lists.freedesktop.org Signed-off-by: Lee Jones --- drivers/gpu/drm/gma500/mmu.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/gma500/mmu.c b/drivers/gpu/drm/gma500/mmu.c index 014daf0280485..13aff19aae9ba 100644 --- a/drivers/gpu/drm/gma500/mmu.c +++ b/drivers/gpu/drm/gma500/mmu.c @@ -681,7 +681,7 @@ int psb_mmu_insert_pfn_sequence(struct psb_mmu_pd *pd, uint32_t start_pfn, if (pd->hw_context != -1) psb_mmu_flush(pd->driver); - return 0; + return ret; } int psb_mmu_insert_pages(struct psb_mmu_pd *pd, struct page **pages, -- 2.25.1